aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMark Sapiro <mark@msapiro.net>2019-11-08 13:51:55 -0800
committerMark Sapiro <mark@msapiro.net>2019-11-08 13:51:55 -0800
commit74f050981cd4dca57451ea74a1ec4a8b3dba153f (patch)
tree4334aed7acd8001fd82c07104de97640640f1460
parentb50d34f55aed1164272cced668a83e7fa6f6233a (diff)
downloadmailman2-74f050981cd4dca57451ea74a1ec4a8b3dba153f.tar.gz
mailman2-74f050981cd4dca57451ea74a1ec4a8b3dba153f.tar.xz
mailman2-74f050981cd4dca57451ea74a1ec4a8b3dba153f.zip
Fix possible UnicodeDecodeError in sending subscription confirmation.
-rw-r--r--Mailman/MailList.py5
-rw-r--r--NEWS3
2 files changed, 6 insertions, 2 deletions
diff --git a/Mailman/MailList.py b/Mailman/MailList.py
index b85b1427..12d75aff 100644
--- a/Mailman/MailList.py
+++ b/Mailman/MailList.py
@@ -969,8 +969,9 @@ class MailList(HTMLFormatter, Deliverer, ListAdmin,
cookie = self.pend_new(Pending.SUBSCRIPTION, userdesc)
# Send the user the confirmation mailback
if remote is None:
- by = remote = ''
+ oremote = by = remote = ''
else:
+ oremote = remote
by = ' ' + remote
remote = _(' from %(remote)s')
@@ -997,7 +998,7 @@ class MailList(HTMLFormatter, Deliverer, ListAdmin,
msg['Reply-To'] = self.GetRequestEmail(cookie)
# Is this confirmation a reply to an email subscribe from this
# address?
- if remote.lower().endswith(email.lower()):
+ if oremote.lower().endswith(email.lower()):
autosub = 'auto-replied'
else:
autosub = 'auto-generated'
diff --git a/NEWS b/NEWS
index bdb7fd7e..5da676cb 100644
--- a/NEWS
+++ b/NEWS
@@ -74,6 +74,9 @@ Here is a history of user visible changes to Mailman.
- The paths.py module now extends sys.path with the result of
site.getsitepackages() if available. (LP: #1838866)
+ - A bug causing a UnicodeDecodeError in preparing to send the confirmation
+ request message to a new subscriber has been fixed. (LP: #1851442)
+
2.1.29 (24-Jul-2018)
Bug Fixes