From 74f050981cd4dca57451ea74a1ec4a8b3dba153f Mon Sep 17 00:00:00 2001 From: Mark Sapiro Date: Fri, 8 Nov 2019 13:51:55 -0800 Subject: Fix possible UnicodeDecodeError in sending subscription confirmation. --- Mailman/MailList.py | 5 +++-- NEWS | 3 +++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/Mailman/MailList.py b/Mailman/MailList.py index b85b1427..12d75aff 100644 --- a/Mailman/MailList.py +++ b/Mailman/MailList.py @@ -969,8 +969,9 @@ class MailList(HTMLFormatter, Deliverer, ListAdmin, cookie = self.pend_new(Pending.SUBSCRIPTION, userdesc) # Send the user the confirmation mailback if remote is None: - by = remote = '' + oremote = by = remote = '' else: + oremote = remote by = ' ' + remote remote = _(' from %(remote)s') @@ -997,7 +998,7 @@ class MailList(HTMLFormatter, Deliverer, ListAdmin, msg['Reply-To'] = self.GetRequestEmail(cookie) # Is this confirmation a reply to an email subscribe from this # address? - if remote.lower().endswith(email.lower()): + if oremote.lower().endswith(email.lower()): autosub = 'auto-replied' else: autosub = 'auto-generated' diff --git a/NEWS b/NEWS index bdb7fd7e..5da676cb 100644 --- a/NEWS +++ b/NEWS @@ -74,6 +74,9 @@ Here is a history of user visible changes to Mailman. - The paths.py module now extends sys.path with the result of site.getsitepackages() if available. (LP: #1838866) + - A bug causing a UnicodeDecodeError in preparing to send the confirmation + request message to a new subscriber has been fixed. (LP: #1851442) + 2.1.29 (24-Jul-2018) Bug Fixes -- cgit v1.2.3