Merge commit 'box/song-locks' into ew/song-locks

* commit 'box/song-locks-wip':
  directory: reuse existing directory if found on update
  song: better handling of existing songs when rereading DB
  tag: merge clearMpdTag into tag_free
  song: start avoiding race in updateSongInfo

1 files changed, 2 insertions, 12 deletions

diff --git a/src/tag.c b/src/tag.c
index 2dcaf4ef8..db446836c 100644
--- a/src/tag.c
+++ b/src/tag.c
@@ -296,12 +296,12 @@ void tag_clear_items_by_type(struct mpd_tag *tag, enum tag_type type)
 	}
 }
 
-static void clearMpdTag(struct mpd_tag *tag)
+void tag_free(struct mpd_tag *tag)
 {
 	int i;
 
 	pthread_mutex_lock(&tag_pool_lock);
-	for (i = 0; i < tag->numOfItems; i++)
+	for (i = tag->numOfItems; --i >= 0; )
 		tag_pool_put_item(tag->items[i]);
 	pthread_mutex_unlock(&tag_pool_lock);
 
@@ -314,16 +314,6 @@ static void clearMpdTag(struct mpd_tag *tag)
 		free(tag->items);
 	}
 
-	tag->items = NULL;
-
-	tag->numOfItems = 0;
-
-	tag->time = -1;
-}
-
-void tag_free(struct mpd_tag *tag)
-{
-	clearMpdTag(tag);
 	free(tag);
 }