diff options
author | Max Kellermann <max@duempel.org> | 2014-10-25 20:42:50 +0200 |
---|---|---|
committer | Max Kellermann <max@duempel.org> | 2014-10-25 20:42:50 +0200 |
commit | bc5a53574c64eb51d2cbf31b26f4607e566eeaab (patch) | |
tree | 56cef63f7d9989ed5bbe98abb6025f4a7d0eb275 /COPYING | |
parent | 30df709736fd206a4799244e19e1d5052c75fb6f (diff) | |
download | mpd-bc5a53574c64eb51d2cbf31b26f4607e566eeaab.tar.gz mpd-bc5a53574c64eb51d2cbf31b26f4607e566eeaab.tar.xz mpd-bc5a53574c64eb51d2cbf31b26f4607e566eeaab.zip |
decoder/faad: remove workaround for ancient libfaad2 ABI bug
Many years ago, FAAD had a serious ABI bug: the NeAACDecInit()
prototype in its header declared the "samplerate" parameter to be
"unsigned long *", but internally, the function assumed it was
"uint32_t *" instead. On 32 bit machines, that was no difference, but
on 64 bit, this left one portion of the return value uninitialized;
and worse, on big-endian, the wrong word was filled. This bug had to
be worked around in MPD (commit 9c4e97a6).
A few months later, the bug was fixed in the FAAD CVS in commit 1.117
on file libfaad/decoder.c; the commit message was:
"Use public headers internally to prevent duplicate declarations"
The commit message was too brief at best; the problem was not
duplicate declarations, but a prototype mismatch. No mention of the
bug fix in the ChangeLog.
The MPD project never learned about this bug fix, and so MPD would
always pass a "uin32_t *" dressed up as a "unsigned long *". Nearly 6
years later, it's about time to fix this second ABI problem. Let's
kill the workaround!
Diffstat (limited to 'COPYING')
0 files changed, 0 insertions, 0 deletions