Fixed a problem where GuiBase._getValidValue() would truncate a floating

point Number type to an int if the value was a float instead of a numeric
string. This affected setting floating point values with config_list.

Updated NEWS for 2.1.10 final.

2 files changed, 12 insertions, 2 deletions

diff --git a/Mailman/Gui/GUIBase.py b/Mailman/Gui/GUIBase.py
index 19714e1c..a365acaf 100644
--- a/Mailman/Gui/GUIBase.py
+++ b/Mailman/Gui/GUIBase.py
@@ -99,6 +99,11 @@ class GUIBase:
             return val
         # This is a number, either a float or an integer
         if wtype == mm_cfg.Number:
+            # The int/float code below doesn't work if we are called from
+            # config_list with a value that is already a float.  It will
+            # truncate the value to an int.
+            if isinstance(val, float):
+                return val
             num = -1
             try:
                 num = int(val)
diff --git a/NEWS b/NEWS
index 34345f10..0b85192c 100644
--- a/NEWS
+++ b/NEWS
@@ -1,10 +1,10 @@
 Mailman - The GNU Mailing List Management System
-Copyright (C) 1998-2007 by the Free Software Foundation, Inc.
+Copyright (C) 1998-2008 by the Free Software Foundation, Inc.
 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
 
 Here is a history of user visible changes to Mailman.
 
-2.1.10rc1 (14-Apr-2008)
+2.1.10 (21-Apr-2008)
 
   Security
 
@@ -180,6 +180,11 @@ Internationalization
     - Changed cmd_subscribe.py to properly accept (no)digest without a
       password and to recognize (no)digest and address= case insensitively.
 
+    - Fixed a problem where GuiBase._getValidValue() would truncate a
+      floating point Number type to an int if the value was a float instead
+      of a numeric string. This affected setting floating point values with
+      config_list.
+
   Miscellaneous
 
     - Brad Knowles' mailman daily status report script updated to 0.0.17.