aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEric Wong <normalperson@yhbt.net>2008-08-23 17:31:00 -0700
committerEric Wong <normalperson@yhbt.net>2008-08-23 17:31:00 -0700
commitc75096cf5bdb94e47602117cde9f2f3d58b3e701 (patch)
tree0e6aa1b34731d2c1e80d6cdf8c819b517c66ee17
parentd92d1639e1000eb5041f6e87a744a4536b46cbab (diff)
downloadmpd-c75096cf5bdb94e47602117cde9f2f3d58b3e701.tar.gz
mpd-c75096cf5bdb94e47602117cde9f2f3d58b3e701.tar.xz
mpd-c75096cf5bdb94e47602117cde9f2f3d58b3e701.zip
outputBuffer: close audio device on stop
-rw-r--r--src/outputBuffer.c15
-rw-r--r--src/outputBuffer_audio.h9
2 files changed, 9 insertions, 15 deletions
diff --git a/src/outputBuffer.c b/src/outputBuffer.c
index 92d90184d..541461746 100644
--- a/src/outputBuffer.c
+++ b/src/outputBuffer.c
@@ -173,7 +173,6 @@ static enum action_status ob_do_drop(void)
return ob_finalize_action();
}
-static void close_audio_devices(void);
static enum action_status ob_do_pause(void)
{
assert(pthread_equal(pthread_self(), ob.thread));
@@ -183,7 +182,8 @@ static enum action_status ob_do_pause(void)
* state where it'll just play silence instead of disconnecting
* listeners
*/
- close_audio_devices();
+ dropBufferedAudio();
+ closeAudioDevice();
ob.state = OB_STATE_PAUSE;
return AS_INPROGRESS;
}
@@ -212,13 +212,15 @@ static void ob_seq_player_set(unsigned int seq_num)
cond_leave(&ob_seq_cond);
}
-static enum action_status ob_do_reset(void)
+static enum action_status ob_do_reset(int close)
{
assert(pthread_equal(pthread_self(), ob.thread));
ob.elapsed_time = 0;
ob.total_time = 0;
reader_reset_buffer();
dropBufferedAudio();
+ if (close)
+ closeAudioDevice();
ob.xfade_state = XFADE_DISABLED;
ob_seq_player_set((unsigned int)ob.seq_decoder);
return ob_finalize_action();
@@ -230,7 +232,7 @@ static enum action_status ob_do_stop(void)
if (ob.state == OB_STATE_STOP)
return AS_INPROGRESS;
ob.state = OB_STATE_STOP;
- return ob_do_reset();
+ return ob_do_reset(1);
}
/*
@@ -311,9 +313,10 @@ static enum action_status ob_take_action(void)
}
break;
case OB_ACTION_STOP: return ob_do_stop();
- case OB_ACTION_RESET: return ob_do_reset();
+ case OB_ACTION_RESET: return ob_do_reset(0);
case OB_ACTION_QUIT:
- close_audio_devices();
+ dropBufferedAudio();
+ closeAudioDevice();
ob.state = OB_STATE_QUIT;
return AS_INPROGRESS;
}
diff --git a/src/outputBuffer_audio.h b/src/outputBuffer_audio.h
index fb366f7d7..332c61d87 100644
--- a/src/outputBuffer_audio.h
+++ b/src/outputBuffer_audio.h
@@ -17,12 +17,3 @@ static int open_audio_devices(int reopen)
return -1;
}
-static void close_audio_devices(void)
-{
- assert(pthread_equal(pthread_self(), ob.thread));
- DEBUG(__FILE__":%s %d\n", __func__, __LINE__);
- dropBufferedAudio();
- closeAudioDevice();
- /* DEBUG(__FILE__":%s %d\n", __func__, __LINE__); */
-}
-