aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMark Sapiro <mark@msapiro.net>2022-02-22 02:35:34 -0800
committerMark Sapiro <mark@msapiro.net>2022-02-22 02:35:34 -0800
commite8439277d594a9f1357f5e05edf4607e01b38f31 (patch)
treed331f88d58d93e1a142eb18718186b84c40206ef
parent16c8af52bb280ae959137eed11bf4385d4340f31 (diff)
downloadmailman2-e8439277d594a9f1357f5e05edf4607e01b38f31.tar.gz
mailman2-e8439277d594a9f1357f5e05edf4607e01b38f31.tar.xz
mailman2-e8439277d594a9f1357f5e05edf4607e01b38f31.zip
Avoid 500 Internal Server Error for non-member with private roster.
-rw-r--r--Mailman/Cgi/options.py4
-rw-r--r--NEWS3
2 files changed, 5 insertions, 2 deletions
diff --git a/Mailman/Cgi/options.py b/Mailman/Cgi/options.py
index c5c6425a..cbdeb6e7 100644
--- a/Mailman/Cgi/options.py
+++ b/Mailman/Cgi/options.py
@@ -169,8 +169,8 @@ def main():
if not mlist.isMember(user):
if mlist.private_roster == 0:
doc.addError(_('No such member: %(safeuser)s.'))
- loginpage(mlist, doc, None, language)
- print doc.Format()
+ loginpage(mlist, doc, None, language)
+ print doc.Format()
return
# Avoid cross-site scripting attacks
diff --git a/NEWS b/NEWS
index 064df556..f84ab120 100644
--- a/NEWS
+++ b/NEWS
@@ -11,6 +11,9 @@ Here is a history of user visible changes to Mailman.
- Test for a valid header following a Unix From_ line in bin/cleanarch
has been improved. (LP: #1957025)
+ - A 500 Internal Server Error when requesting the options page for a
+ non-member address on a list with private rosters is avoided.
+ (LP: #1961762)
2.1.39 (13-Dec-2021)