From b88b2b3d79159c3468a579afdbdc3d1f28494faa Mon Sep 17 00:00:00 2001 From: Denis Krjuchkov Date: Sun, 23 Oct 2011 12:51:33 +0600 Subject: output_init: initialize replay gain filters to NULL in ao_base_init() If output plugin fails to init it will try to call ao_base_finish() immediately, which segfaults because replay gain filters are not initialized yet and contain garbage values. --- src/output_init.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src') diff --git a/src/output_init.c b/src/output_init.c index 51fe36c47..3b8a7a9f1 100644 --- a/src/output_init.c +++ b/src/output_init.c @@ -213,6 +213,8 @@ ao_base_init(struct audio_output *ao, ao->cond = g_cond_new(); ao->mixer = NULL; + ao->replay_gain_filter = NULL; + ao->other_replay_gain_filter = NULL; /* the "convert" filter must be the last one in the chain */ -- cgit v1.2.3