From aa7f5dec87e5decd2905056938e0af0e35aa0130 Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Tue, 2 Jun 2009 08:37:30 +0200 Subject: player_thread: don't leak empty music_chunks When a music_chunk only contains a tag but no PCM data, play_chunk() returns true without freeing the chunk. The caller now assumes that the chunk is moved into some music_pipe and does not bother to free it either. --- src/player_thread.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/player_thread.c b/src/player_thread.c index f00d1aba8..add093083 100644 --- a/src/player_thread.c +++ b/src/player_thread.c @@ -447,8 +447,10 @@ play_chunk(struct song *song, struct music_chunk *chunk, } } - if (chunk->length == 0) + if (chunk->length == 0) { + music_buffer_return(player_buffer, chunk); return true; + } pc.elapsed_time = chunk->times; pc.bit_rate = chunk->bit_rate; -- cgit v1.2.3