From 1bb154098dc5b52163ebee2eeb224b736836a936 Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Wed, 10 Sep 2008 11:42:30 +0200 Subject: client: client_input_received() returns 0 Since the caller chain doesn't care about the return value (except for COMMAND_RETURN_KILL, COMMAND_RETURN_CLOSE), just return 0 if there is nothing special. This saves one local variable initialization, and one access to it. Also remove one unreachable "return 1" from client_read(). --- src/client.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'src') diff --git a/src/client.c b/src/client.c index 2ec39dca1..d5a7ce616 100644 --- a/src/client.c +++ b/src/client.c @@ -400,7 +400,7 @@ static int client_process_line(struct client *client) static int client_input_received(struct client *client, int bytesRead) { - int ret = 0; + int ret; char *buf_tail = &(client->buffer[client->bufferLength - 1]); while (bytesRead > 0) { @@ -440,7 +440,7 @@ static int client_input_received(struct client *client, int bytesRead) } } - return ret; + return 0; } static int client_read(struct client *client) @@ -457,8 +457,6 @@ static int client_read(struct client *client) return COMMAND_RETURN_CLOSE; } else return 0; - - return 1; } static void client_manager_register_read_fd(fd_set * fds, int *fdmax) -- cgit v1.2.3