From 56f082c9d46eefda3057b962d15dac50d25b690d Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Tue, 14 Jan 2014 23:07:04 +0100 Subject: util/PeakBuffer: fix nullptr dereference when peak_size==0 --- src/util/PeakBuffer.cxx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'src/util') diff --git a/src/util/PeakBuffer.cxx b/src/util/PeakBuffer.cxx index a3659b8f4..d9b193dd1 100644 --- a/src/util/PeakBuffer.cxx +++ b/src/util/PeakBuffer.cxx @@ -130,8 +130,9 @@ PeakBuffer::Append(const void *data, size_t length) return true; } - if (peak_buffer == nullptr && peak_size > 0) { - peak_buffer = (fifo_buffer *)HugeAllocate(peak_size); + if (peak_buffer == nullptr) { + if (peak_size > 0) + peak_buffer = (fifo_buffer *)HugeAllocate(peak_size); if (peak_buffer == nullptr) return false; -- cgit v1.2.3