From f31c371fbd95d1999b18c6b35596d8f3b71b620c Mon Sep 17 00:00:00 2001 From: Jochen Keil Date: Wed, 11 Mar 2009 09:57:32 +0100 Subject: Removed superfluous if statement in update.c:453 Check for NULL not necessary here --- src/update.c | 50 ++++++++++++++++++++++---------------------------- 1 file changed, 22 insertions(+), 28 deletions(-) (limited to 'src/update.c') diff --git a/src/update.c b/src/update.c index 0abda07a0..1088f5338 100644 --- a/src/update.c +++ b/src/update.c @@ -450,42 +450,36 @@ update_container_file( struct directory* directory, return true; } - // contdir doesn't yet exist - if (contdir == NULL) - { - contdir = make_subdir(directory, name); - contdir->mtime = st->st_mtime; - contdir->device = DEVICE_CONTAINER; + contdir = make_subdir(directory, name); + contdir->mtime = st->st_mtime; + contdir->device = DEVICE_CONTAINER; - while ((vtrack = plugin->container_scan(pathname, ++tnum)) != NULL) - { - struct song* song = song_file_new(vtrack, contdir); - if (song == NULL) - return true; + while ((vtrack = plugin->container_scan(pathname, ++tnum)) != NULL) + { + struct song* song = song_file_new(vtrack, contdir); + if (song == NULL) + return true; - // shouldn't be necessary but it's there.. - song->mtime = st->st_mtime; + // shouldn't be necessary but it's there.. + song->mtime = st->st_mtime; - song->tag = plugin->tag_dup(map_directory_child_fs(contdir, vtrack)); + song->tag = plugin->tag_dup(map_directory_child_fs(contdir, vtrack)); - songvec_add(&contdir->songs, song); - song = NULL; + songvec_add(&contdir->songs, song); + song = NULL; - modified = true; + modified = true; - g_free(vtrack); - } + g_free(vtrack); + } - if (tnum == 1) - { - delete_directory(contdir); - return false; - } - else - return true; + if (tnum == 1) + { + delete_directory(contdir); + return false; } - // something went wrong, so return true to return update_regular_file - return true; + else + return true; } static void -- cgit v1.2.3