From c855415c733d712aa0f129fbfdef2af11e289234 Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Fri, 29 Aug 2008 09:38:37 +0200 Subject: tag: added a pool for tag items The new source tag_pool.c manages a pool of reference counted tag_item objects. This is used to merge tag items of the same type and value, saving lots of memory. Formerly, only the value itself was pooled, wasting memory for all the pointers and tag_item structs. The following results were measured with massif. Started MPD on amd64, typed "mpc", no song being played. My music database contains 35k tagged songs. The results are what massif reports as "peak". 0.13.2: total 14,131,392; useful 11,408,972; extra 2,722,420 eric: total 18,370,696; useful 15,648,182; extra 2,722,514 mk f34f694: total 15,833,952; useful 13,111,470; extra 2,722,482 mk now: total 12,837,632; useful 10,626,383; extra 2,211,249 This patch set saves 20% memory, and does a good job in reducing heap fragmentation. --- src/tag.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/tag.h') diff --git a/src/tag.h b/src/tag.h index afded5d7d..21dbfa487 100644 --- a/src/tag.h +++ b/src/tag.h @@ -21,6 +21,7 @@ #include "mpd_types.h" #include "os_compat.h" +#include "gcc.h" enum tag_type { TAG_ITEM_ARTIST, @@ -42,7 +43,7 @@ extern const char *mpdTagItemKeys[]; struct tag_item { enum tag_type type; char value[1]; -} mpd_unused; +} mpd_packed; struct tag { int time; -- cgit v1.2.3