From 52dca859c7ad32ac0869f75326ea82731d7d2271 Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Thu, 19 Dec 2013 10:30:26 +0100 Subject: util/PeakBuffer: use IsEmpty() instead of IsNull() The DynamicFifoBuffer methods never return nullptr when the buffer is empty or full; instead, they return an empty buffer. This bug caused an endless loop. --- src/event/FullyBufferedSocket.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/event/FullyBufferedSocket.cxx') diff --git a/src/event/FullyBufferedSocket.cxx b/src/event/FullyBufferedSocket.cxx index e7869cd66..375132e34 100644 --- a/src/event/FullyBufferedSocket.cxx +++ b/src/event/FullyBufferedSocket.cxx @@ -60,7 +60,7 @@ FullyBufferedSocket::Flush() assert(IsDefined()); const auto data = output.Read(); - if (data.IsNull()) { + if (data.IsEmpty()) { IdleMonitor::Cancel(); CancelWrite(); return true; -- cgit v1.2.3