From 7bf638b0deedf02aea46e72f6f3c848e86f2ce0d Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Thu, 29 Jan 2015 08:21:51 +0100 Subject: decoder/DsdLib: use new[] to allocate the ID3 buffer Don't abort the process if there's not enough memory. This buffer is not important and can be large. --- src/decoder/plugins/DsdLib.cxx | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'src/decoder/plugins/DsdLib.cxx') diff --git a/src/decoder/plugins/DsdLib.cxx b/src/decoder/plugins/DsdLib.cxx index 180981620..d826970f7 100644 --- a/src/decoder/plugins/DsdLib.cxx +++ b/src/decoder/plugins/DsdLib.cxx @@ -128,15 +128,17 @@ dsdlib_tag_id3(InputStream &is, if (count < 10 || count > 1024 * 1024) return; - id3_byte_t *const id3_buf = static_cast(xalloc(count)); + id3_byte_t *const id3_buf = new id3_byte_t[count]; + if (id3_buf == nullptr) + return; if (!decoder_read_full(nullptr, is, id3_buf, count)) { - free(id3_buf); + delete[] id3_buf; return; } struct id3_tag *id3_tag = id3_tag_parse(id3_buf, count); - free(id3_buf); + delete[] id3_buf; if (id3_tag == nullptr) return; -- cgit v1.2.3