From 9eed41911f5b65bb51d2395388439918e799cade Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Tue, 11 Nov 2008 17:13:44 +0100 Subject: decoder: return void from decode() methods The stream_decode() and file_decode() methods returned a boolean, indicating whether they were able to decode the song. This is redundant, since we already know that: if decoder_initialized() has been called (and dc.state==DECODE), the plugin succeeded. Change both methods to return void. --- src/decoder/oggflac_plugin.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'src/decoder/oggflac_plugin.c') diff --git a/src/decoder/oggflac_plugin.c b/src/decoder/oggflac_plugin.c index 17770a2a7..6199f72ae 100644 --- a/src/decoder/oggflac_plugin.c +++ b/src/decoder/oggflac_plugin.c @@ -284,17 +284,15 @@ static bool oggflac_try_decode(struct input_stream *inStream) return ogg_stream_type_detect(inStream) == FLAC; } -static bool +static void oggflac_decode(struct decoder * mpd_decoder, struct input_stream *inStream) { OggFLAC__SeekableStreamDecoder *decoder = NULL; FlacData data; - bool ret = true; init_FlacData(&data, mpd_decoder, inStream); if (!(decoder = full_decoder_init_and_read_metadata(&data, 0))) { - ret = false; goto fail; } @@ -329,8 +327,6 @@ oggflac_decode(struct decoder * mpd_decoder, struct input_stream *inStream) fail: oggflac_cleanup(&data, decoder); - - return ret; } static const char *const oggflac_Suffixes[] = { "ogg", "oga", NULL }; -- cgit v1.2.3