From ff70dbd316c12bf8c1edc140f0a73f0c53b81e43 Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Sat, 14 Nov 2009 22:27:04 +0100 Subject: decoder/modplug: check ModPlug_Read() < 0 Negative return values are not documented here, but since the function prototype is signed, let's be sure. --- src/decoder/modplug_plugin.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'src/decoder/modplug_plugin.c') diff --git a/src/decoder/modplug_plugin.c b/src/decoder/modplug_plugin.c index 1d373a466..4c3302383 100644 --- a/src/decoder/modplug_plugin.c +++ b/src/decoder/modplug_plugin.c @@ -139,10 +139,8 @@ mod_decode(struct decoder *decoder, struct input_stream *is) do { ret = ModPlug_Read(f, audio_buffer, MODPLUG_FRAME_SIZE); - - if (ret == 0) { + if (ret <= 0) break; - } total_time += ret * sec_perbyte; cmd = decoder_data(decoder, NULL, -- cgit v1.2.3