From 028fd268b89163c9c6e938794064339f0989d6a0 Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Thu, 16 Jan 2014 08:43:57 +0100 Subject: db/upnp/WorkQueue: simplify start() --- src/db/upnp/WorkQueue.hxx | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'src/db') diff --git a/src/db/upnp/WorkQueue.hxx b/src/db/upnp/WorkQueue.hxx index 723254251..274b85995 100644 --- a/src/db/upnp/WorkQueue.hxx +++ b/src/db/upnp/WorkQueue.hxx @@ -90,7 +90,7 @@ public: * @param arg initial parameter to thread function. * @return true if ok. */ - bool start(int nworkers, void *(*workproc)(void *), void *arg) + bool start(unsigned nworkers, void *(*workproc)(void *), void *arg) { const ScopeLock protect(mutex); @@ -99,11 +99,12 @@ public: assert(n_threads == 0); assert(threads == nullptr); - threads = new pthread_t[nworkers]; + n_threads = nworkers; + threads = new pthread_t[n_threads]; - for (int i = 0; i < nworkers; i++) { + for (unsigned i = 0; i < nworkers; i++) { int err; - if ((err = pthread_create(&threads[n_threads++], 0, workproc, arg))) { + if ((err = pthread_create(&threads[i], 0, workproc, arg))) { LOGERR(("WorkQueue:%s: pthread_create failed, err %d\n", name.c_str(), err)); return false; -- cgit v1.2.3