From 74842fd6d4d1cd35c7e80935e42d9b010751be49 Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Fri, 10 Jan 2014 20:13:17 +0100 Subject: db/upnp: getprop() returns const char * Return the return value, instead returning it in a reference parameter. Reduces bloat by reducing unnecessary std::string usage. --- src/db/upnp/Object.hxx | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) (limited to 'src/db/upnp') diff --git a/src/db/upnp/Object.hxx b/src/db/upnp/Object.hxx index c05f39e47..4949146e8 100644 --- a/src/db/upnp/Object.hxx +++ b/src/db/upnp/Object.hxx @@ -56,13 +56,11 @@ public: * @param[out] value * @return true if found. */ - bool getprop(const std::string &name, std::string &value) const - { + const char *getprop(const char *name) const { auto it = m_props.find(name); if (it == m_props.end()) - return false; - value = it->second; - return true; + return nullptr; + return it->second.c_str(); } void clear() -- cgit v1.2.3