From b5ba94f1de06c621da937241eedfcfb100f26a09 Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Sat, 8 Nov 2014 19:25:01 +0100 Subject: tag/Set: do AlbumArtist/Artist fallback only if AlbumArtist is not disabled On "list albumartist", songs that have no AlbumArtist tag will use the Artist tag. However, if AlbumArtist is disabled via "metadata_to_use", the TagBuilder::AddItem() call is ignored, and PrintUniqueTag() attempts to print a nullptr string. This commit fixes the problem by attempting the fallback only if AlbumArtist is not disabled. --- NEWS | 2 ++ 1 file changed, 2 insertions(+) (limited to 'NEWS') diff --git a/NEWS b/NEWS index 94ce8d4ba..f18e9ff0f 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,6 @@ ver 0.19.3 (not yet released) +* protocol + - fix "(null)" result string to "list" when AlbumArtist is disabled * database - upnp: fix breakage due to malformed URIs * decoder -- cgit v1.2.3 From ff6f1655f0441f2fa8a1947bf242ea2cce6ba7a7 Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Mon, 10 Nov 2014 08:45:19 +0100 Subject: input/curl: ignore ResponseBoundary() while seeking While seeking, metadata must not be updated. ResponseBoundary() was added in MPD 0.19.1, but I forgot to add the IsSeeking() check there. This caused the "seekable" flag to reset. --- NEWS | 2 ++ 1 file changed, 2 insertions(+) (limited to 'NEWS') diff --git a/NEWS b/NEWS index f18e9ff0f..3d28b44c8 100644 --- a/NEWS +++ b/NEWS @@ -3,6 +3,8 @@ ver 0.19.3 (not yet released) - fix "(null)" result string to "list" when AlbumArtist is disabled * database - upnp: fix breakage due to malformed URIs +* input + - curl: another fix for redirected streams * decoder - audiofile: fix crash while playing streams - ffmpeg: support opus -- cgit v1.2.3 From 8ff0d99092acfe8e80eba9709c2e93727f9e47b9 Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Mon, 10 Nov 2014 09:00:50 +0100 Subject: decoder/audiofile: fix bit rate calculation --- NEWS | 1 + 1 file changed, 1 insertion(+) (limited to 'NEWS') diff --git a/NEWS b/NEWS index 3d28b44c8..933a980db 100644 --- a/NEWS +++ b/NEWS @@ -7,6 +7,7 @@ ver 0.19.3 (not yet released) - curl: another fix for redirected streams * decoder - audiofile: fix crash while playing streams + - audiofile: fix bit rate calculation - ffmpeg: support opus ver 0.19.2 (2014/11/02) -- cgit v1.2.3 From 8d036c4b7c3a09bd55bdc86a4fb7b5d525a805c2 Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Mon, 10 Nov 2014 22:52:17 +0100 Subject: pcm/SoxrResampler: round output buffer size up The old formula calculates the output buffer size with "regular" rounding (to the nearest integer), however sometimes, that is insufficient and the last sample cannot be resampled. This causes audible distortions. By changing the formula to consider the worst case (always round up), this problem is eliminated. --- NEWS | 1 + 1 file changed, 1 insertion(+) (limited to 'NEWS') diff --git a/NEWS b/NEWS index 933a980db..b1cc2cf04 100644 --- a/NEWS +++ b/NEWS @@ -9,6 +9,7 @@ ver 0.19.3 (not yet released) - audiofile: fix crash while playing streams - audiofile: fix bit rate calculation - ffmpeg: support opus +* fix distorted audio with soxr resampler ver 0.19.2 (2014/11/02) * input -- cgit v1.2.3 From 134cb6a0171192b7d621697f84196ce670a3ce21 Mon Sep 17 00:00:00 2001 From: Misty De Meo Date: Mon, 10 Nov 2014 19:38:22 -0800 Subject: Main: fix compilation on OS X using non-Apple compilers Commit d42c0f1dc5063d50a62817b63a1c2a4507c46071 added an OS X-specific method of calling mpd_main_after_fork(), which uses Grand Central Dispatch. Since this uses a block literal, it breaks compilation on compilers which don't support the block extension, e.g. non-Apple compilers. This affects users on older OS X releases with GCD (which depend on older Clang releases, or Apple GCCs, which don't support the C++11 features MPD needs); or which don't support GCD at all (10.5 and lower). This patch changes the #ifdef so that the non-GCD code is used as it was on OS X before this patch if blocks aren't available, via checking __BLOCKS__ macro. --- NEWS | 1 + 1 file changed, 1 insertion(+) (limited to 'NEWS') diff --git a/NEWS b/NEWS index b1cc2cf04..52f4671e3 100644 --- a/NEWS +++ b/NEWS @@ -10,6 +10,7 @@ ver 0.19.3 (not yet released) - audiofile: fix bit rate calculation - ffmpeg: support opus * fix distorted audio with soxr resampler +* fix build failure on Mac OS X with non-Apple compilers ver 0.19.2 (2014/11/02) * input -- cgit v1.2.3 From 7886a14b74f58896670bb8c0573646cd1a947d05 Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Tue, 11 Nov 2014 11:18:51 +0100 Subject: decoder/opus: fix mistyped LoadEOSPacket() return value --- NEWS | 1 + 1 file changed, 1 insertion(+) (limited to 'NEWS') diff --git a/NEWS b/NEWS index 52f4671e3..9f7cd74fa 100644 --- a/NEWS +++ b/NEWS @@ -9,6 +9,7 @@ ver 0.19.3 (not yet released) - audiofile: fix crash while playing streams - audiofile: fix bit rate calculation - ffmpeg: support opus + - opus: fix bogus duration on streams * fix distorted audio with soxr resampler * fix build failure on Mac OS X with non-Apple compilers -- cgit v1.2.3 From 23465ad9855f4878fd7210bf076fed938a409b7d Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Tue, 11 Nov 2014 10:56:36 +0100 Subject: decoder/opus: improved error logging --- NEWS | 1 + 1 file changed, 1 insertion(+) (limited to 'NEWS') diff --git a/NEWS b/NEWS index 9f7cd74fa..8a6f33c1b 100644 --- a/NEWS +++ b/NEWS @@ -10,6 +10,7 @@ ver 0.19.3 (not yet released) - audiofile: fix bit rate calculation - ffmpeg: support opus - opus: fix bogus duration on streams + - opus: improved error logging * fix distorted audio with soxr resampler * fix build failure on Mac OS X with non-Apple compilers -- cgit v1.2.3 From c98cb1d6f9704e1fefcc28938bcedb8a4d84a7e5 Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Tue, 11 Nov 2014 07:41:01 +0100 Subject: decoder/opus: support chained streams --- NEWS | 1 + 1 file changed, 1 insertion(+) (limited to 'NEWS') diff --git a/NEWS b/NEWS index 8a6f33c1b..342e14eb6 100644 --- a/NEWS +++ b/NEWS @@ -10,6 +10,7 @@ ver 0.19.3 (not yet released) - audiofile: fix bit rate calculation - ffmpeg: support opus - opus: fix bogus duration on streams + - opus: support chained streams - opus: improved error logging * fix distorted audio with soxr resampler * fix build failure on Mac OS X with non-Apple compilers -- cgit v1.2.3 From e5217e6ce97d4a0f972223f5eb6308e9b5e8df8f Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Tue, 11 Nov 2014 11:21:42 +0100 Subject: release v0.19.3 --- NEWS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'NEWS') diff --git a/NEWS b/NEWS index 342e14eb6..bf6bf11b6 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,4 @@ -ver 0.19.3 (not yet released) +ver 0.19.3 (2014/11/11) * protocol - fix "(null)" result string to "list" when AlbumArtist is disabled * database -- cgit v1.2.3