From d3c93c1c77eaa8d4d3def73a04cba9f5bfa9c5ef Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Tue, 28 Apr 2009 09:32:38 +0200 Subject: tag: use g_ascii_strcasecmp() instead of strcasecmp() strcasecmp() is locale dependent, making it a bad choice for internal string comparisons. --- src/tag.c | 4 ++-- src/tag_ape.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/tag.c b/src/tag.c index 69c4c19bd..a75ef6ba5 100644 --- a/src/tag.c +++ b/src/tag.c @@ -89,7 +89,7 @@ void tag_lib_init(void) memset(ignore_tag_items, true, TAG_NUM_OF_ITEM_TYPES); - if (0 == strcasecmp(value, "none")) + if (0 == g_ascii_strcasecmp(value, "none")) return; temp = c = s = g_strdup(value); @@ -99,7 +99,7 @@ void tag_lib_init(void) quit = 1; *s = '\0'; for (i = 0; i < TAG_NUM_OF_ITEM_TYPES; i++) { - if (strcasecmp(c, tag_item_names[i]) == 0) { + if (g_ascii_strcasecmp(c, tag_item_names[i]) == 0) { ignore_tag_items[i] = false; break; } diff --git a/src/tag_ape.c b/src/tag_ape.c index 459f3450b..d1249fcb2 100644 --- a/src/tag_ape.c +++ b/src/tag_ape.c @@ -126,7 +126,7 @@ tag_ape_load(const char *file) /* we only care about utf-8 text tags */ if (!(flags & (0x3 << 1))) { for (i = 0; i < 7; i++) { - if (strcasecmp(key, apeItems[i]) == 0) { + if (g_ascii_strcasecmp(key, apeItems[i]) == 0) { if (!ret) ret = tag_new(); tag_add_item_n(ret, tagItems[i], -- cgit v1.2.3