From d1ba27d820dc96c41cc3814801c12392060692dc Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Fri, 16 Oct 2009 17:37:54 +0200 Subject: update: song_file_new() cannot fail Removed the NULL check. If that NULL check was correct, that would have been a memory leak (vtrack). --- src/update.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/update.c b/src/update.c index 593198cb9..4aa48f25c 100644 --- a/src/update.c +++ b/src/update.c @@ -459,8 +459,6 @@ update_container_file( struct directory* directory, while ((vtrack = plugin->container_scan(pathname, ++tnum)) != NULL) { struct song* song = song_file_new(vtrack, contdir); - if (song == NULL) - return true; // shouldn't be necessary but it's there.. song->mtime = st->st_mtime; @@ -468,7 +466,6 @@ update_container_file( struct directory* directory, song->tag = plugin->tag_dup(map_directory_child_fs(contdir, vtrack)); songvec_add(&contdir->songs, song); - song = NULL; modified = true; -- cgit v1.2.3