From cf797657ed619f4908a3d47b7e37c25fb7133454 Mon Sep 17 00:00:00 2001
From: Max Kellermann <max@duempel.org>
Date: Tue, 12 Aug 2014 15:33:45 +0200
Subject: AllCommands: close connection after syntax error

Stop HTTP clients from exploiting MPD via forged POST requests.
---
 NEWS                        | 1 +
 src/command/AllCommands.cxx | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/NEWS b/NEWS
index 4351f3d99..64e2d0fbd 100644
--- a/NEWS
+++ b/NEWS
@@ -8,6 +8,7 @@ ver 0.19 (not yet released)
   - "list" on album artist falls back to the artist tag
   - "list" and "count" allow grouping
   - new "search"/"find" filter "modified-since"
+  - close connection after syntax error
 * database
   - proxy: forward "idle" events
   - proxy: forward the "update" command
diff --git a/src/command/AllCommands.cxx b/src/command/AllCommands.cxx
index d29950eeb..6a4b18198 100644
--- a/src/command/AllCommands.cxx
+++ b/src/command/AllCommands.cxx
@@ -369,7 +369,9 @@ command_process(Client &client, unsigned num, char *line)
 
 		current_command = nullptr;
 
-		return CommandResult::ERROR;
+		/* this client does not speak the MPD protocol; kick
+		   the connection */
+		return CommandResult::FINISH;
 	}
 
 	unsigned argc = 1;
-- 
cgit v1.2.3