From 9f3db5a70b4181fef6a70ef84b70fdd5b3c3e451 Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Wed, 13 Jun 2012 21:23:34 +0200 Subject: directory: require db lock for _{add,remove}_song() --- src/directory.c | 2 ++ src/update_walk.c | 8 ++++++++ 2 files changed, 10 insertions(+) diff --git a/src/directory.c b/src/directory.c index 930881129..e886698d6 100644 --- a/src/directory.c +++ b/src/directory.c @@ -186,6 +186,7 @@ directory_lookup_directory(struct directory *directory, const char *uri) void directory_add_song(struct directory *directory, struct song *song) { + assert(holding_db_lock()); assert(directory != NULL); assert(song != NULL); assert(song->parent == directory); @@ -197,6 +198,7 @@ void directory_remove_song(G_GNUC_UNUSED struct directory *directory, struct song *song) { + assert(holding_db_lock()); assert(directory != NULL); assert(song != NULL); assert(song->parent == directory); diff --git a/src/update_walk.c b/src/update_walk.c index 0fcfaf37e..6a953f522 100644 --- a/src/update_walk.c +++ b/src/update_walk.c @@ -236,7 +236,10 @@ update_archive_tree(struct directory *directory, char *name) if (song == NULL) { song = song_file_load(name, directory); if (song != NULL) { + db_lock(); directory_add_song(directory, song); + db_unlock(); + modified = true; g_message("added %s/%s", directory_get_path(directory), name); @@ -374,7 +377,9 @@ update_container_file(struct directory *directory, &add_tag_handler, song->tag); g_free(child_path_fs); + db_lock(); directory_add_song(contdir, song); + db_unlock(); modified = true; @@ -438,7 +443,10 @@ update_song_file(struct directory *directory, return; } + db_lock(); directory_add_song(directory, song); + db_unlock(); + modified = true; g_message("added %s/%s", directory_get_path(directory), name); -- cgit v1.2.3