aboutsummaryrefslogtreecommitdiffstats
path: root/src (follow)
Commit message (Collapse)AuthorAgeFilesLines
...
* | lib/nfs/Connection: add assertionMax Kellermann2014-12-141-0/+2
| |
* | lib/nfs/Connection: fix reconnect after mount failureMax Kellermann2014-12-141-1/+1
| | | | | | | | | | | | | | When mounting had not yet finished, SocketMonitor::IsDefined() was always false, due to the workaround at the beginning of the function that calls SocketMonitor::Steal(). This commit drops the IsDefined() check because it was never necessary and breaks reconnect.
* | lib/nfs/Connection: fix typo in code commentMax Kellermann2014-12-141-1/+1
| |
* | lib/nfs/Connection: fix memory leak (and assertion failure)Max Kellermann2014-12-143-0/+28
| | | | | | | | | | | | | | | | | | | | | | nfs_destroy_context() will invoke all pending callbacks with err==-EINTR. In CancellableCallback::Callback(), this will invoke NfsConnection::DeferClose(), which however is only designed to be called from nfs_service(). In non-debug mode, this will leak memory because nfs_close_async() is never called. Workaround: before nfs_destroy_context(), invoke nfs_close_async() on all pending file handles.
* | lib/nfs/Connection: move code to Service()Max Kellermann2014-12-142-12/+28
| |
* | lib/nfs/Connection: add assertionsMax Kellermann2014-12-141-0/+2
| |
* | lib/nfs/Connection: move code to method InternalClose()Max Kellermann2014-12-142-3/+17
| |
* | lib/nfs/Connection: make in_service and in_event debug-only flagsMax Kellermann2014-12-142-0/+11
| |
* | lib/nfs/Connection: fix crash while canceling a failing Open()Max Kellermann2014-12-141-2/+4
| | | | | | | | | | | | | | The method NfsConnection::CancellableCallback::Callback() will always invoke NfsConnection::Close() on the file handle, even if the void pointer is not a nfsfh. This can happen if the Open() was not successful, e.g. when the file does not exist.
* | event/Loop: read the "again" flag while holding mutexMax Kellermann2014-12-141-1/+2
| |
* | lib/nfs/Connection: add assertionsMax Kellermann2014-12-141-0/+31
| |
* | util/HugeAllocator: disable MEM_LARGE_PAGES on WindowsMax Kellermann2014-12-121-1/+2
| | | | | | | | | | | | MEM_LARGE_PAGES does not appear to work. Instead, MEM_RESERVE appears to be necessary. Until I figure this out, this large pages are disabled.
* | input/Init: eliminate double colon from log messageMax Kellermann2014-12-121-1/+1
| |
* | playlist/Print: don't skip non-existent songs in "listplaylist"Max Kellermann2014-12-091-6/+7
| | | | | | | | | | | | | | | | Skipping those songs silently will confuse the client, because commands specifying the song index within a playlist (e.g. playlistdelete) will be out of sync. This copies spl_print()'s behavior to playlist_file_print().
* | Merge tag 'v0.18.20' into v0.19.xMax Kellermann2014-12-082-2/+7
|\|
| * decoder/ffmpeg: support FFmpeg 2.5Max Kellermann2014-12-081-0/+5
| | | | | | | | | | | | Version 2.5 fixed an API oddity, however it broke API compatibility, at least with C++. Disable the workaround when a libavformat version is detected that is recent enough.
| * thread/Id: drop "::" prefix before pthread function namesMax Kellermann2014-12-081-2/+2
| | | | | | | | | | | | The "::" to explicitly refer to the global namespace appeared like a good idea in C++, but it breaks with C libraries that implement standard functions using macros (e.g. musl).
* | Output: start with a null mixer.Nix2014-12-011-0/+1
| | | | | | | | | | | | | | | | | | | | | | There are code paths (mostly error cases) in which it is possible to initialize an AudioOutput and then kill it without ever calling audio_output_new(). In such a case, its destructor will attempt to free a mixer that was never initialized, leading to an attempt to take out a lock on a mutex that was similarly never initialized, which hangs forever. Fix by always initializing the mixer appropriately.
* | Merge tag 'v0.18.19' into v0.19.xMax Kellermann2014-11-261-4/+5
|\|
| * archive/zzip: fix inverted error handlerMax Kellermann2014-11-241-4/+5
| | | | | | | | | | Set the Error when zzip_seek()==-1 and not on success. Fixes a crash after seeking.
* | lib/nfs/FileReader: clean up on disconnectMax Kellermann2014-11-251-1/+1
| | | | | | | | | | Avoids crash because Close() invokes a call on a destructed NfsConnection.
* | lib/nfs/FileReader: move code to CancelOrClose()Max Kellermann2014-11-252-0/+16
| |
* | lib/nfs/FileReader: reset state in OnNfsConnectionFailed()Max Kellermann2014-11-251-0/+2
| | | | | | | | | | Avoid calling NfsConnection::RemoveLease(), because the lease has been removed already.
* | lib/nfs/FileReader: update "state" in OnNfsError()Max Kellermann2014-11-251-0/+24
| | | | | | | | | | | | Clean up the "state" to indicate that there is no longer any asynchronous operation. Fixes another NFS-related crash due to cleanup of a non-existing asynchronous operation.
* | lib/nfs/Manager: defer NfsConnection destructionMax Kellermann2014-11-252-9/+54
| | | | | | | | | | Avoids a crash that occurs when NfsConnection::OnSocketReady() dereferences itself before returning.
* | lib/nfs/Connection: broadcast error before closing connectionMax Kellermann2014-11-251-4/+4
| | | | | | | | | | | | During the NfsLease::OnNfsConnectionFailed() call, the old (defunct) nfs_context may be used to close file handles. Such code does not yet exist, but will be added soon to fix other bugs.
* | lib/nfs/Connection: cancel DeferredMonitor on disconnectMax Kellermann2014-11-251-0/+4
| | | | | | | | | | Fixes potential second mount attempt after the old connection to the NFS server was shut down.
* | lib/nfs/FileReader: include Compiler.h for "final" fallbackMax Kellermann2014-11-251-0/+1
| |
* | decoder/mp4v2: remove because of incompatible licenseMax Kellermann2014-11-253-359/+0
| | | | | | | | | | | | | | | | | | libmp4v2 is licensed under MPL 1.1, which is incompatible with GPLv2. Unfortunately, this means that we must remove the plugin. More information can be found in the Debian bug report: http://bugs.debian.org/767504
* | event/DeferredMonitor: include cleanupMax Kellermann2014-11-252-3/+2
| |
* | decoder/{dsdiff,dsf,opus}: fix deadlock while seekingMax Kellermann2014-11-242-3/+3
| |
* | Java/File: fix include guardMax Kellermann2014-11-241-1/+1
| |
* | Merge tag 'v0.18.18' into v0.19.xMax Kellermann2014-11-184-4/+8
|\|
| * Client: assume uid==0 is local socketMax Kellermann2014-11-182-2/+2
| | | | | | | | | | A negative uid value means it's not a "local socket" (PF_LOCAL). uid==0 means user "root" connected.
| * event/ServerSocket: fix get_remote_uid() error valueMax Kellermann2014-11-181-1/+1
| | | | | | | | Must return -1 on error, not 0. 0 is root.
| * Construct a Null AllocatedPath if the filename conversion into UTF8 failedFlorent Le Coz2014-11-111-1/+5
| |
| * decoder/ffmpeg: support opusMax Kellermann2014-11-101-1/+2
| |
* | QueueCommands: workaround for buggy clients that send "add /"Max Kellermann2014-11-181-1/+10
| |
* | decoder/opus: add MIME types audio/ogg and application/oggMax Kellermann2014-11-121-0/+7
| |
* | decoder/opus: support chained streamsMax Kellermann2014-11-111-1/+36
| |
* | decoder/opus: move code to HandleEOS()Max Kellermann2014-11-111-1/+8
| |
* | decoder/opus: improved error loggingMax Kellermann2014-11-111-4/+11
| |
* | decoder/opus: fix mistyped LoadEOSPacket() return valueMax Kellermann2014-11-111-1/+1
| |
* | decoder/opus: eliminate flag "found_opus"Max Kellermann2014-11-111-5/+3
| | | | | | | | Check opus_decoder!=nullptr instead.
* | decoder/opus: add constexpr output_buffer_framesMax Kellermann2014-11-111-8/+10
| |
* | Main: fix compilation on OS X using non-Apple compilersMisty De Meo2014-11-111-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit d42c0f1dc5063d50a62817b63a1c2a4507c46071 added an OS X-specific method of calling mpd_main_after_fork(), which uses Grand Central Dispatch. Since this uses a block literal, it breaks compilation on compilers which don't support the block extension, e.g. non-Apple compilers. This affects users on older OS X releases with GCD (which depend on older Clang releases, or Apple GCCs, which don't support the C++11 features MPD needs); or which don't support GCD at all (10.5 and lower). This patch changes the #ifdef so that the non-GCD code is used as it was on OS X before this patch if blocks aren't available, via checking __BLOCKS__ macro.
* | pcm/SoxrResampler: round output buffer size upMax Kellermann2014-11-101-1/+2
| | | | | | | | | | | | | | | | The old formula calculates the output buffer size with "regular" rounding (to the nearest integer), however sometimes, that is insufficient and the last sample cannot be resampled. This causes audible distortions. By changing the formula to consider the worst case (always round up), this problem is eliminated.
* | decoder/audiofile: fix bit rate calculationMax Kellermann2014-11-101-1/+1
| |
* | input/curl: ignore ResponseBoundary() while seekingMax Kellermann2014-11-101-0/+4
| | | | | | | | | | | | While seeking, metadata must not be updated. ResponseBoundary() was added in MPD 0.19.1, but I forgot to add the IsSeeking() check there. This caused the "seekable" flag to reset.
* | tag/Set: do AlbumArtist/Artist fallback only if AlbumArtist is not disabledMax Kellermann2014-11-081-0/+2
| | | | | | | | | | | | | | | | | | | | On "list albumartist", songs that have no AlbumArtist tag will use the Artist tag. However, if AlbumArtist is disabled via "metadata_to_use", the TagBuilder::AddItem() call is ignored, and PrintUniqueTag() attempts to print a nullptr string. This commit fixes the problem by attempting the fallback only if AlbumArtist is not disabled.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-06 16:24:20 +0000