aboutsummaryrefslogtreecommitdiffstats
path: root/src (follow)
Commit message (Collapse)AuthorAgeFilesLines
...
| * tag_ape: removed redundant length checkMax Kellermann2009-07-191-3/+4
| | | | | | | | | | Extend the tagLen check after reading it. Removed the second (redundant) check after the subtraction.
| * ape: check the tag size (fixes integer underflow)Max Kellermann2009-07-181-1/+1
| | | | | | | | | | | | | | The expression "tagLen - size > 0" may result in an integer underflow and a buffer overflow, when "size" is larger than "tagLen". "size" is read from the input file, and must not be trusted. This patch changes the expression to "tagLen > size", which is a lot safer.
* | decoder_control: protect command, state with a mutexMax Kellermann2009-08-136-31/+241
| | | | | | | | | | | | Replace decoder_control.notify with decoder_control.mutex and decoder_control.cond. Lock the mutex on all accesses to decoder_control.command and decoder_control.state.
* | use daemon() when the C library provides itMike Frysinger2009-08-131-6/+18
| | | | | | | | | | | | | | For systems that cannot support fork() (like no-mmu Linux), use daemon() if it is available for the daemonizing code. Signed-off-by: Mike Frysinger <vapier@gentoo.org>
* | tag_id3: moved id3_genre_name() call to tag_id3_import_text()Max Kellermann2009-08-041-6/+6
| | | | | | | | | | The ID3_FRAME_GENRE field is queried only in tag_id3_import_text(). Don't pass the tag type to import_id3_string().
* | tag_id3: splitted function tag_id3_import_frame()Max Kellermann2009-08-041-119/+91
| | | | | | | | | | | | Splitted tag_id3_import_frame() into two specialized functions: tag_id3_import_text() and tag_id3_import_comment(). Use id3_frame_field() instead of directly accessing id3_frame.fields.
* | tag_id3: corrected parameter typesMax Kellermann2009-08-041-2/+3
| | | | | | | | | | Changed "int type" to "enum tag_type". Converted "int is_id3v1" to "bool".
* | tag_id3: converted tag_is_id3v1() to an inline functionMax Kellermann2009-08-041-1/+6
| | | | | | | | Prefer C over CPP.
* | tag_id3: no CamelCaseMax Kellermann2009-08-041-57/+64
| | | | | | | | Renamed functions.
* | ffmpeg_plugin: convert metadata to generic formatAnton Khirnov2009-08-031-1/+3
| |
* | command: moved command_process_list() to client.cMax Kellermann2009-07-293-35/+30
| |
* | playlist: CamelCaseIsBadCourtney Cavin2009-07-2811-107/+128
| | | | | | | | Renamed all playlist functions to non-CamelCase.
* | input/lastfm: Ensure multiple identical xml entities are decoded.Courtney Cavin2009-07-281-6/+5
| | | | | | | | | | Previously, if two identical entities appeared in one string, only the first would get decoded. This fixes that bug.
* | client: splitted client.c into several piecesMax Kellermann2009-07-2811-875/+1129
| | | | | | | | | | The soure file client.c has nearly 1000 lines, time for splitting it into smaller pieces to improve readability.
* | client: moved struct client to client_internal.hMax Kellermann2009-07-282-44/+69
| | | | | | | | Prepare splitting client.c into several sources.
* | input/lastfm: use metadataCourtney Cavin2009-07-281-43/+297
| | | | | | | | | | | | Added a patch to flush out the last.fm input plugin slightly. It basically turns it into a wrapper for the appropriate plugin. Most notably metadata is now extracted.
* | cmdline: obey $(sysconfdir) for default mpd.conf locationMax Kellermann2009-07-281-1/+0
| | | | | | | | | | | | | | | | | | | | | | Instead of hard-coding the path "/etc/mpd.conf", use the configured $(sysconfdir) path. This can be set with: ./configure --sysconfdir=/etc Note that this changes the default path to "/usr/local/etc/mpd.conf", given the default prefix "/usr/local". This is actually more correct than the old default.
* | client: moved some code to client_list_X()Max Kellermann2009-07-231-13/+51
| | | | | | | | Make the client list management a separate sub-library.
* | client: don't include socket headersMax Kellermann2009-07-231-10/+0
| | | | | | | | | | The client code uses portable GLib I/O functions and doesn't need the OS specific socket headers.
* | player_thread: don't use precalculated size_to_timeMax Kellermann2009-07-232-22/+4
| | | | | | | | | | | | | | Calculate the total play time with the audio_format object each time, using audio_format_time_to_size(). The function audioFormatSizeToTime() is not needed anymore, and will be removed with this patch.
* | player_thread: moved code to update_song_tag()Max Kellermann2009-07-231-19/+27
| |
* | pcm_convert: use GError for error handlingMax Kellermann2009-07-2310-115/+177
| | | | | | | | | | Don't abort the whole MPD process when the conversion fails. This has been a denial-of-service attack vector for years.
* | pcm_resample_fallback: don't include glib.hMax Kellermann2009-07-221-1/+0
| | | | | | | | This library does not use GLib directly.
* | pcm_resample_fallback: removed G_GNUC_UNUSED attributeMax Kellermann2009-07-222-6/+3
| |
* | pcm_channels: num_channels is unsignedMax Kellermann2009-07-222-12/+12
| | | | | | | | | | You cannot have a negative number of channels, let's pass it as uint8_t instead of int8_t.
* | pcm_byteswap: converted NULL checks to assertionsMax Kellermann2009-07-222-10/+5
| | | | | | | | | | It is illegal to pass a NULL buffer to pcm_byteswap_X(). The result of this is that pcm_byteswap_X() never returns NULL.
* | pcm_convert: added pcm_convert_state.byteswap_bufferMax Kellermann2009-07-222-3/+8
| | | | | | | | | | | | Currently, byteswapping is performed on the format_buffer. This can go wrong when this buffer is used twice during one run. Add a separate buffer for swapping the byte order.
* | filter/volume: check the flag audio_format.reverse_endianMax Kellermann2009-07-221-0/+7
| | | | | | | | The volume plugin does not work for reverse_endian samples.
* | audio_format: added API documentationMax Kellermann2009-07-221-0/+48
| |
* | audio_format: initialize reverse_endian in audio_format_init()Max Kellermann2009-07-221-0/+1
| | | | | | | | | | This line was missing in the reverse_endian patch, and led to undefined values and crashes in that attribute.
* | daemon: daemonize_close_stdin() optimised.Michal Nazarewicz2009-07-222-12/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changed function to first close standard input (this may fail but we don't care) and then try to open /dev/null (this may fail but it shouldn't on Unix platforms plus we don't know what to do in such case anyways). Since standard input has the "zeroth" descriptor number next "open" will use it. Since there is no "/dev/null" on Windows (It's not even a valid path!) the second step is skipped if WIN32 is defined. As a final touch, since the function consists of merely two function calls it has been moved to header file and declared static inline. [mk: un-inline daemonize_close_stdin()]
* | cmdline: renamed options.stderr to options.log_stderrEugeny N Dzhurinsky2009-07-223-6/+6
| | | | | | | | | | | | | | On FreeBSD, "stderr" is a macro, and using this name for a struct member breaks the build. [mk: renamed _stderr to log_stderr]
* | Merge branch 'master' of git://git.infradead.org/users/dwmw2/mpdMax Kellermann2009-07-1921-60/+240
|\ \ | | | | | | | | | | | | | | | Conflicts: Makefile.am
| * | Support wrong-endian ALSA outputDavid Woodhouse2009-07-191-2/+50
| | |
| * | Add reverse_endian field to struct audio_format and handle conversionDavid Woodhouse2009-07-196-5/+151
| | |
| * | Add audio_format_init() functionDavid Woodhouse2009-07-1915-53/+39
| | | | | | | | | | | | | | | It makes no difference right now, but we're about to add an endianness flag and will want to make sure it's correctly initialised every time.
* | | tag_ape: simplified the apeItems arrayMax Kellermann2009-07-191-22/+12
| | | | | | | | | | | | | | | Make "enum tag_type" the array index, and convert apeItems to a sparse array.
* | | tag_ape: moved code to tag_ape_import_item()Max Kellermann2009-07-191-12/+22
| | | | | | | | | | | | Improve code readability.
* | | tag_ape: converted apeItems and tagItems to global varsMax Kellermann2009-07-191-20/+20
| | | | | | | | | | | | Don't initialize those arrays each time tag_ape_load() is called.
* | | client: return "enum command_return" instead of "int"Max Kellermann2009-07-191-16/+24
| | | | | | | | | | | | | | | Several functions work with the wrong return type, this patch fixes them.
* | | removed buffer2array.cMax Kellermann2009-07-192-164/+0
| | |
* | | command: use the tokenizer libraryMax Kellermann2009-07-191-4/+50
| | |
* | | conf: use the tokenizer libraryMax Kellermann2009-07-191-62/+82
| | |
* | | tokenizer: new library replacing buffer2array()Max Kellermann2009-07-192-0/+235
| | | | | | | | | | | | | | | The new code is more robust and more flexible. It provides detailed error information in GError objects.
* | | daemon: Moved empty Windows version functions to header fileMichal Nazarewicz2009-07-192-21/+36
| | | | | | | | | | | | | | | | | | | | | On Windows only daemonize_close_stdin() function does something. Other functions are either empty or generate an error. Those have been moved to header file and declared static inline so compiler can remove the call all together.
* | | conf: replaced gcc "const" attribute with "pure"Michal Nazarewicz2009-07-191-13/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The functions were not "const" (they examined values pointed by arguments passed to them, quoting gcc's doc: "Note that a function that has pointer arguments and examines the data pointed to must _not_ be declared 'const'.") but rather "pure" and still not all of them. Note also, that even some of the functions declared "pure" are not pure, however, due to reasons stated in source code the attribute has been kept.
* | | daemon: added "group" configuration optionMichal Nazarewicz2009-07-195-18/+35
|/ / | | | | | | | | | | | | | | | | | | | | | | | | The "group" configuration option is similar to "user" as it sets user set what group MPD shall run as. With "user" option, MPD changed GID to the GID of the user, however, more control could be desired. Moreover, the patch changes the way of checking whether no setuid(2)/setgid(2) is required -- previously user names were compered, now UID and GIDs are compered (ie. the one we already have (getuid(2)/getgid(2)) with the one we want to change to).
* | Merged release 0.15.1 from branch 'v0.15.x'Max Kellermann2009-07-166-19/+14
|\|
| * output/httpd: removed duplicate sys/types.h includeMax Kellermann2009-07-141-4/+0
| | | | | | | | | | The first patch by Patrick didn't work, because his "#ifdef HAVE_OSX" line would have required config.h.
| * decoder/flac: fix assertion failure in tag_free() callMax Kellermann2009-07-061-2/+1
| | | | | | | | | | | | Initialize flac_data.tag right after flac_data_init(). This way, the "goto fail" won't jump to the point where tag_free(NULL) can be called.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-17 07:11:16 +0000