Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | db/upnp: move "objid" declaration down | Max Kellermann | 2014-01-21 | 1 | -2/+2 | |
| | | | | | | | | Don't allocate the object when it's not needed. | |||||
* | | db/upnp: eliminate redundant Namei() parameter "oobjid" | Max Kellermann | 2014-01-21 | 1 | -12/+7 | |
| | | | | | | | | | | The caller should better obtain the object id from the returned UPnPDirObject instance. | |||||
* | | db/upnp: remove redundant objid.empty() check from VisitServer() | Max Kellermann | 2014-01-21 | 1 | -4/+0 | |
| | | | | | | | | If Namei() succeeds, the object id is guaranteed to be set. | |||||
* | | db/upnp: use std::move() to extract server name | Max Kellermann | 2014-01-21 | 1 | -1/+1 | |
| | | | | | | | | Reduce runtime overhead. | |||||
* | | db/upnp: use vector::front() instead of [0] | Max Kellermann | 2014-01-21 | 1 | -5/+5 | |
| | | ||||||
* | | db/upnp: don't use stringToTokens() in ParseDuration() | Max Kellermann | 2014-01-21 | 1 | -4/+20 | |
| | | | | | | Reduce bloat. | |||||
* | | db/upnp: don't construct redundant empty vector<string> in Visit() | Max Kellermann | 2014-01-21 | 1 | -1/+1 | |
| | | | | | | | | We know already that vpath is empty, let's use this instance. | |||||
* | | db/upnp: simplify GetSong() | Max Kellermann | 2014-01-21 | 1 | -20/+18 | |
| | | ||||||
* | | LightSong: add attribute "real_uri" | Max Kellermann | 2014-01-21 | 4 | -25/+30 | |
| | | | | | | | | | | The UPnP database plugin can now show relative song URIs for remote songs. | |||||
* | | DetachedSong: add attribute "real_uri" | Max Kellermann | 2014-01-21 | 7 | -11/+62 | |
| | | | | | | | | Prepare for UPnP songs that retain there database identity. | |||||
* | | DetachedSong: remove parameter names from "defaulted" constructors | Max Kellermann | 2014-01-21 | 1 | -2/+2 | |
| | | | | | | Suppresses gcc warnings. | |||||
* | | db/upnp: fix empty song URI | Max Kellermann | 2014-01-21 | 1 | -3/+6 | |
| | | | | | | | | Fall back to UPnPDirObject::url if there is no override. | |||||
* | | DetachedSong: use "default" copy/move constructors | Max Kellermann | 2014-01-21 | 1 | -10/+2 | |
| | | | | | | | | Remove unnecessary explicit code. | |||||
* | | pcm/SoxrResampler: Add configurable quality levels | Chase Geigle | 2014-01-21 | 3 | -3/+73 | |
| | | ||||||
* | | PlaylistSong: modify the given song object in-place | Max Kellermann | 2014-01-21 | 4 | -74/+55 | |
| | | | | | | | | Reduce bloat. | |||||
* | | PlaylistSong: remove redundant "secure" check | Max Kellermann | 2014-01-21 | 1 | -3/+3 | |
| | | | | | | | | This has been verified already in the caller. | |||||
* | | PlaylistSong: recurse after applying base_uri | Max Kellermann | 2014-01-20 | 1 | -3/+3 | |
| | | | | | | | | Allows applying map_to_relative_path() with base_uri. | |||||
* | | PlaylistSong: remove the IsInDatabase() check | Max Kellermann | 2014-01-20 | 1 | -4/+0 | |
| | | | | | | | | | | No caller passes a database song to this function, but if he does, this check doesn't make sense. | |||||
* | | PlaylistSong: don't map relative URI to absolute path | Max Kellermann | 2014-01-20 | 1 | -18/+2 | |
| | | | | | | | | This didn't make sense. | |||||
* | | CommandLine: show the current git tag and commit id | Max Kellermann | 2014-01-20 | 1 | -1/+5 | |
| | | ||||||
* | | PlaylistSong: pass reference variables internally | Max Kellermann | 2014-01-20 | 1 | -18/+17 | |
| | | ||||||
* | | Merge branch 'v0.18.x' | Max Kellermann | 2014-01-20 | 10 | -53/+53 | |
|\| | ||||||
| * | Queue: rename struct queue to Queue | Max Kellermann | 2014-01-20 | 10 | -53/+53 | |
| | | | | | | | | | | Works around a build failure on Solaris because annoyingly, Solaris reserves the name "queue". This rename was pending anyway. | |||||
| * | Queue: make the constructor "explicit" | Max Kellermann | 2014-01-20 | 1 | -1/+1 | |
| | | ||||||
* | | Song: make the "parent" attribute mandatory | Max Kellermann | 2014-01-19 | 6 | -21/+16 | |
| | | | | | | | | | | The Song class is only used for database songs now. A Song without a Directory is not possible anymore. | |||||
* | | Directory: use Song::Export() | Max Kellermann | 2014-01-19 | 1 | -15/+1 | |
| | | ||||||
* | | LightSong: new class to be used by DatabasePlugin callbacks | Max Kellermann | 2014-01-19 | 42 | -223/+404 | |
| | | | | | | | | | | Detach the Song class completely from the public API, only to be used by SimpleDatabase and the update thread. | |||||
* | | db/proxy: simplify error handling in GetSong() | Max Kellermann | 2014-01-19 | 1 | -11/+9 | |
| | | | | | | | | | | Check mpd_response_finish() before using mpd_song. Don't skip this check even if the mpd_song is non-nullptr. | |||||
* | | db/simple: make borrowed_song_count "mutable" | Max Kellermann | 2014-01-19 | 2 | -3/+3 | |
| | | | | | | | | Simpler to use than const_cast. | |||||
* | | Tag: pack attributes tighter | Max Kellermann | 2014-01-19 | 2 | -7/+7 | |
| | | | | | | | | This saves another 3% memory. | |||||
* | | Song: embed the Tag object statically into class Song | Max Kellermann | 2014-01-19 | 14 | -47/+26 | |
| | | | | | | | | | | Reduces overhead because we need to manage only one memory allocation. According to valgrind/massif, we save 7%. | |||||
* | | Song: use the VarSize library | Max Kellermann | 2014-01-18 | 2 | -13/+19 | |
| | | ||||||
* | | db/upnp: move Tag from UPnPDirObject to Song | Max Kellermann | 2014-01-18 | 1 | -11/+14 | |
| | | | | | | | | | | The UPnPDirObject is a temporary object, we can move its contents. This reduces runtime overhead. | |||||
* | | db/upnp/Discovery: eliminate attribute "last_seen" | Max Kellermann | 2014-01-18 | 2 | -6/+4 | |
| | | ||||||
* | | db/upnp/Discovery: use monotonic clock instead of time() | Max Kellermann | 2014-01-18 | 2 | -10/+18 | |
| | | ||||||
* | | db/upnp/Discovery: eliminate full copy in getServer() | Max Kellermann | 2014-01-18 | 2 | -9/+17 | |
| | | ||||||
* | | db/upnp: use getServer() in Visit() | Max Kellermann | 2014-01-18 | 1 | -17/+9 | |
| | | | | | | | | Reduce bloat. | |||||
* | | db/upnp/Discovery: eliminate Error attribute | Max Kellermann | 2014-01-18 | 3 | -51/+32 | |
| | | | | | | | | | | Move code to method Start() and add Error& parameters to several methods. | |||||
* | | db/upnp: remove unnecessary m_superdir nullptr checks | Max Kellermann | 2014-01-18 | 1 | -3/+3 | |
| | | ||||||
* | | db/upnp: pass ContentDirectoryService references | Max Kellermann | 2014-01-18 | 1 | -27/+27 | |
| | | ||||||
* | | db/upnp: cache m_path.back() | Max Kellermann | 2014-01-18 | 2 | -16/+18 | |
| | | ||||||
* | | db/upnp: add UpnpMakeAction() helper function | Max Kellermann | 2014-01-18 | 2 | -30/+78 | |
| | | ||||||
* | | db/upnp/ixmlwrap: getFirstElementValue() returns const char * | Max Kellermann | 2014-01-18 | 5 | -27/+33 | |
| | | | | | | | | Eliminate the std::string bloat. | |||||
* | | db/upnp: merge duplicate nullptr check | Max Kellermann | 2014-01-18 | 1 | -2/+2 | |
| | | ||||||
* | | db/upnp: free IXML_Document *request manually | Max Kellermann | 2014-01-18 | 1 | -38/+40 | |
| | | ||||||
* | | db/upnp/Device: move code to method Parse() | Max Kellermann | 2014-01-18 | 4 | -31/+39 | |
| | | | | | | | | Forward the Error to the caller. | |||||
* | | db/upnp/Device: use ContentDirectoryDescriptor's move operator | Max Kellermann | 2014-01-18 | 3 | -7/+7 | |
| | | | | | | | | Reduce bloat. | |||||
* | | db/upnp/Discovery: don't copy XML to std::string | Max Kellermann | 2014-01-18 | 3 | -4/+4 | |
| | | | | | | | | Pass "const char *" to Expat. | |||||
* | | db/upnp/Discovery: fix memory leak | Max Kellermann | 2014-01-18 | 1 | -0/+1 | |
| | | ||||||
* | | db/upnp: remove unused typedef DevServIt | Max Kellermann | 2014-01-18 | 1 | -2/+0 | |
| | |