| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
| |
| |
| |
| | |
No idea why it was created in directory.h, but it should be in
dirvec.h.
|
| |
| |
| |
| |
| |
| | |
Remove clutter from directory.c. Everything which saves or loads
to/from the hard disk goes to directory_save.c, and code which sends
directory information to the client is moved into directory_print.c.
|
| |
| |
| |
| | |
Use sizeof(buffer) instead.
|
| |
| |
| |
| | |
Removed a superfluous closure.
|
| |
| |
| |
| |
| |
| |
| | |
Commit 0bfe7802 broke update for new files in the root directory,
because music_root->path was an empty string and not NULL. There were
some NULL tests missing. Change them to !isRootDirectory(path)
instead of path!=NULL.
|
| |
| |
| |
| |
| | |
For the root directory, let's set path to an empty string. This saves
a few checks.
|
| |
| |
| |
| |
| | |
Also convert directory_get_path() to an inline function, which returns
a constant string.
|
| |
| |
| |
| |
| |
| | |
Pass const songvec pointers to songvec_find() and songvec_for_each().
[ew: already merged songvec_for_each() cosntification somewhere...]
|
| |
| |
| |
| |
| |
| |
| |
| | |
CamelCase is ugly, rename the functions.
[ew: "directory_get_directory" was too confusing, using
"directory_get_subdir" instead (old function was named
"getSubDirectory")]
|
| |
| |
| |
| | |
Yet another CamelCase removal patch.
|
| |
| |
| |
| | |
The same can be achieved with directory_print(db_get_directory()).
|
| |
| |
| |
| |
| |
| | |
Taming the directory.c monster, part II: move the database management
stuff to database. directory.c should only contain code which works
on directory objects.
|
| |
| |
| |
| |
| | |
The function isRootDirectory() is tiny and can be converted to an
inline function. Don't allow name==NULL.
|
| |
| |
| |
| | |
Eliminate duplicated code.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Instead of returning 0 or -1, return true on success and false on
failure. This seems more natural, and when the C library was
designed, there was no "bool" data type.
[ew:
changing to bool semantics but sticking with integer type
since bool is C99 and I don't require a C99 compiler,
and I don't feel like writing compatibility wrappers to
support it. _Bool is usually (always?) a signed int
anyways.
]
|
| |
| |
| |
| |
| | |
This function was never used on remote songs. Replace the runtime
check with an assertion.
|
| |
| |
| |
| | |
CamelCase is ugly... rename all functions.
|
| |
| |
| |
| |
| |
| | |
Provide separate constructors for creating a remote song, a local
song, and one for loading data from a song file. This way, we can add
more assertions.
|
| |
| |
| |
| |
| | |
Check the old status before assigning. This saves a temporary
variable.
|
| |
| |
| |
| |
| |
| | |
Include only headers which are really used.
[ew: this is totally different from Max's branch]
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Again, a data type which can be forward-declared.
[ew:
* used "struct mpd_song" instead to avoid token duplication
(like I did with "struct mpd_tag") as there's no good
abbreviation for "song" and identical tokens on the same
line don't read well
* rewritten using
perl -i -p -e 's/\bSong\b/struct mpd_song/g' src/*.[ch]
since it was too hard to merge
* also, I don't care much for forward declarations
]
|
| |
| |
| |
| |
| | |
The struct can be forward-declared by other headers, which relaxes the
header dependencies.
|
| |
| |
| |
| |
| |
| | |
exploreDirectory() duplicates some code in updateDirectory(). Merge
both functions, and use directory_is_empty() to determine whether
update or explore mode should be used.
|
| |
| |
| |
| |
| | |
directory_is_empty() is a tiny inline function which determine if a
directory has any child objects (sub directories or songs).
|
| |
| |
| |
| |
| |
| | |
The source directory.c mixes several libraries: directory object
management, database management and database update, resulting in a
1000+ line monster. Move the whole database update code to update.c.
|
| |
| |
| |
| |
| |
| |
| |
| | |
Having all functions as static (non-inline) functions generates GCC
warnings, and duplicates binary code across several object files.
Most of dirvec's methods are too complex for becoming inline
functions. Move them all to dirvec.c and publish the prototypes in
dirvec.h.
|
| |
| |
| |
| | |
Somehow I must have missed this in commit 22e40b61.
|
| |
| |
| |
| |
| |
| | |
The "packed" attribute may have negative side effects on performance.
Remove the "packed" attribute, and increase the size of "song.url" to
a multiple of the machine word size.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
> From: Igor Vagulin <hidden@address.private.email>
> To: warren.dukes@gmail.com
> Date: Wed, 08 Oct 2008 03:09:15 +0400
> CC: jat@spatialrift.net, normalperson@yhbt.net
> Subject: mpd bug: create-db with fs locale differ from latin1 and utf8
>
> Hi Warren,
>
> I discover a bug in mpd from trunk. I make a patch and decide to send to
> maintainer in hope it may be useful.
>
> Bug triggers folowing steps:
> - Set filesystem_charset to something not latin1 and utf8.(For me
> fs-charset was KOI8-R)
> - Put some music in music directory with non ascii characters in path.
> - run mpg with --create-db option, so mpd will try to find all music
> files in music directory.
>
> Result: music files with non latin characters in path don't added to db.
>
> Bug happen because function newSong don't translate path into fs charset
> before send it to plugin tagDupFuntion. On my machine tagDupFunction
> can't find file when it was. Small patch in attach fix problem.
Signed-off-by: Eric Wong <normalperson@yhbt.net>
|
|/
|
|
|
|
|
| |
With commit 6dcd7fea (if I am not mistaken) the error returned when
you try to save to an existing playlist is wrong. Instead of
MPD_ACK_ERROR_EXIST, MPD_ACK_ERROR_NO_EXIST is returned. This is
obviously wrong and breaks gmpc.
|
|
|
|
| |
oops :x
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* ew/update-thrsafe:
directory: serialize song deletes from playlist during update
directory: use songvec_for_each for iterators
dbUtils: more cleanups
song: Add song_print_url_x
dbUtils/directory: traverseAllIn forEachSong returns -1 on error
songvec: lock traversals for thread-safe updates/reads
song: add print_song_info_x for iterators tha pass void *
songvec: add songvec_for_each iterator
song: replace printSong* with song_print_*
Assert if we don't have song or song->url set
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This makes the update code thread-safe and doesn't penalize
the playlist code by complicating it with complicated and
error-prone locks (and the associated overhead, not everybody
has a thread-implementation as good as NPTL).
The update task blocks during the delete; but the update task is
a slow task anyways so we can block w/o people caring too much.
This was also our only freeSong call site, so remove that
function.
Note that deleting entire directories is not fully thread-safe,
yet; as their traversals are not yet locked.
|
| |
| |
| |
| | |
Get rid of songvec_write so we can enforce proper locking
|
| |
| |
| |
| |
| |
| |
| | |
Remove unnecessary wrapper function now that we have
song_print_url_x and also return the results directly
since we'll know the song_print_* functions will all
return -1 on error.
|
| |
| |
| |
| |
| | |
It'll be handy for passing throug songvec_for_each like
song_print_info_x.
|
| |
| |
| |
| | |
Being consistent with most UNIX functions...
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Only one lock is used for all songvec traversals since
they're rarely changed. Also, minimize lock time and
release it before calling iterator functions since they
may block (updateSongInfo => stat/open/seek/read).
This lock only protects songvecs (and all of them) during
traversals; not the individual song structures themselves.
|
| |
| |
| |
| |
| | |
traverseAllIn will be modified to take < 0 as errors instead of
non-zero...
|
| |
| |
| |
| |
| | |
This is so we can more consistently deal with locking
needed for thread-safety in iterator functions.
|
| |
| |
| |
| |
| |
| | |
This make argument order more consistent for iterators.
Additionally, these now return ssize_t results for error
checking.
|
| |
| |
| |
| | |
song objects cannot exist without a path or URL
|
| |
| |
| |
| |
| | |
More power to those who can't afford newer computers
capable of installing/building/running newer toolchains.
|
|/
|
|
|
|
|
| |
Upgrading a toolchain is still a nasty operation and they're
never easy to build, so don't force people to upgrade from their
old compilers (especially since some people are still stuck with
Linux 2.4 and gcc 2.95).
|
|
|
|
|
|
|
|
| |
* Add missing headers in Makefile.am
* remove mp4ff.dsp (Win32 crap)
* Add scripts, m4, bs, autogen.sh to allow for hotfixes by the
SCM-challenged. (downloading the source via git is NOT a
lightweight operation for everybody).
|
|
|
|
|
|
|
| |
We already know if a song is a URL or not based on whether it
has parentDir defined or not. Hopefully one day in the future
we can drop HTTP support from MPD entirely when an HTTP
filesystem comes along and we can access streams via open(2).
|
|
|
|
|
|
| |
Reduce the number of allocations we make, so there's less
pressure on the allocator and less overhead to keep track
of the allocations in.
|
|
|
|
|
|
| |
Having an enum type is much nicer than an anonymous integer plus CPP
macros. Note that the old code didn't save any space by declaring the
variable 8 bit, due to padding.
|
|
|
|
|
| |
It didn't save us any lines of code nor did it do anything
useful since we would overwrite everything anyways.
|
|
|
|
|
| |
There's no reason to scan the playlist for a song we
just allocated.
|