aboutsummaryrefslogtreecommitdiffstats
path: root/src (follow)
Commit message (Collapse)AuthorAgeFilesLines
* fs/io/FileOutputStream: don't auto-delete file on WIN32Max Kellermann2015-02-061-0/+2
| | | | | | | | | The file handle is never reset to INVALID_HANDLE_VALUE, and thus the destructor will assume the operation shall be cancelled and will delete the temporary file. This was a major breakage for saving the database file and the state file.
* TagBuilder: allow adding duplicate tag types in Complement()Max Kellermann2015-02-061-1/+10
| | | | | | | | | | Build a table of pre-existing tag types before adding new items. The old way would check HasType() each time, which would return true after the first instance of that tag type had been added, preventing duplicate tag types to be merged. This broke duplicate tag types loaded from the state file, because this code path uses TagBuilder::Complement().
* db/update/Walk: use std::unique_ptr instead of std::auto_ptrMax Kellermann2015-01-291-1/+1
| | | | | std::auto_ptr is deprecated, and std::unique_ptr is much better anyway.
* Avoid integer overflow in MonotonicClock{S,MS,US}PHO2015-01-291-6/+6
| | | | | This is Darwin specific: the previous implementation was causing an integer overflow when base.numer is very large. On PPC Darwin, the timebase info is 1000000000/33330116 and this is too large for integer arithmetic.
* decoder/DsdLib: use new[] to allocate the ID3 bufferMax Kellermann2015-01-291-3/+5
| | | | | Don't abort the process if there's not enough memory. This buffer is not important and can be large.
* decoder/DsdLib: free ID3 buffer right after id3_tag_parse()Max Kellermann2015-01-291-5/+2
| | | | Merge two free() calls.
* decoder/DsdLib: raise ID3 tag limit to 1 MBMax Kellermann2015-01-291-1/+1
| | | | | A bug report was submitted with a 600 kB ID3 tag that could not be read by MPD.
* Merge branch 'v0.18.x' into v0.19.xMax Kellermann2015-01-2610-660/+3
|\
| * {playlist,input}/despotify: remove defunct pluginMax Kellermann2015-01-269-668/+0
| |
| * util/list: disable gcc5 warningMax Kellermann2015-01-231-0/+4
| | | | | | | | | | This file has been removed in newer MPD versions, so don't care about it now.
| * ClientProcess: cast enum to int before passing to printf()Max Kellermann2015-01-231-3/+3
| | | | | | | | Fixes gcc5 warning.
* | Test the existence of strndup(3) before using it.PHO2015-01-261-5/+6
| | | | | | | | This can eliminate the ad-hoc "#ifdef WIN32" and can also support other platforms lacking it as well (including Darwin 9).
* | thread/Name: include stdio.h if HAVE_PRCTLMax Kellermann2015-01-211-1/+4
| | | | | | | | | | Caused a build failure with uClibc because snprintf() was not available.
* | input/async: reset the "open" flag after seeking successfullyMax Kellermann2015-01-061-0/+5
| | | | | | | | | | | | | | | | | | Fixes a problem with the "curl" input plugin: IsEOF() always returns true because the "open" flag was cleared by CurlInputStream::RequestDone() when end-of-stream was reached. This flag stays false even when seeking to another position has succeeded. This patch resets the "open" flag to true after seeking successfully.
* | thread/Name: disable pthread_setname_np() on NetBSDMax Kellermann2015-01-061-2/+6
| | | | | | | | | | | | | | NetBSD's pthread_setname_np() prototype is incompatible with the rest of the world, and it requires to pass the string argument as a non-const pointer. Instead of working around this misdesign, I hereby disable the feature on NetBSD.
* | thread/Name: enable FormatThreadName() with prctl()Max Kellermann2015-01-061-1/+5
| | | | | | | | | | | | Add macro HAVE_THREAD_NAME which is set when any method to set the thread name is available. Use that macro in FormatThreadName() instead of just checking for HAVE_PTHREAD_SETNAME_NP.
* | thread/Name: indent preprocessor commandsMax Kellermann2015-01-061-3/+3
| |
* | db/simple: fix implicit nullptr/bool conversionMax Kellermann2014-12-263-5/+5
| | | | | | | | | | Return false on error, not nullptr.
* | fs/Traits, ...: work around -Wtautological-pointer-compareMax Kellermann2014-12-265-1/+32
| | | | | | | | New in clang 3.6.
* | db/lazy, input/mms: add "override" keywordsMax Kellermann2014-12-263-4/+6
| | | | | | | | Fixes -Winconsistent-missing-override (clang 3.6).
* | Merge branch 'v0.18.x' into v0.19.xMax Kellermann2014-12-2618-51/+110
|\|
| * db/proxy, output/shout: fix implicit nullptr/bool conversionMax Kellermann2014-12-262-4/+4
| | | | | | | | Return false on error, not nullptr.
| * db/{simple,proxy}, ...: add "override" keywordsMax Kellermann2014-12-267-22/+26
| | | | | | | | Fixes -Winconsistent-missing-override (clang 3.6).
| * util/{ASCII,UriUtil}, ...: work around -Wtautological-pointer-compareMax Kellermann2014-12-2610-0/+51
| | | | | | | | New in clang 3.6.
| * DatabaseGlue: convert nullptr check to assertionMax Kellermann2014-12-261-3/+2
| |
| * util/ASCII: fix indentMax Kellermann2014-12-261-10/+10
| |
| * Compiler.h: add macro CLANG_CHECK_VERSION()Max Kellermann2014-12-261-0/+7
| |
| * Compiler.h: add macro GCC_OLDER_THAN()Max Kellermann2014-12-262-4/+12
| |
| * util/Manual: reimplement GCC_CHECK_VERSION() using GCC_MAKE_VERSION()Max Kellermann2014-12-261-4/+3
| |
| * Compiler.h: add macro GCC_MAKE_VERSION()Max Kellermann2014-12-261-6/+4
| |
* | decoder/ffmpeg: support interleaved floating pointMax Kellermann2014-12-231-0/+1
| |
* | input/mms: limit the mmsx_read() sizeMax Kellermann2014-12-231-0/+7
| |
* | decoder/DsdLib: add missing stdlib.h includeMax Kellermann2014-12-231-0/+1
| |
* | DSF ID3 tags hitting 4k size limitJan Brittenson2014-12-231-6/+12
| | | | | | | | | | | | | | | | | | Here's a change to dynamically allocate the DSD ID3 tag buffer. Pretty much anything with cover art is going to exceed the existing, static 4k limit... Here's a change to dynamically allocate the buffer and sanity check it at some upper limit. I rather arbitrarily pulled 256k out of thin air just to keep a corrupt file from causing it to trying to allocate a buffer larger than available memory.
* | Merge tag 'v0.18.21' into v0.19.xMax Kellermann2014-12-172-5/+8
|\|
| * playlist/embcue: fix filename suffix detectionk442014-12-161-1/+1
| | | | | | | | | | The definition of the playlist_plugin struct member of the embcue plugin was incorrect.
| * decoder/ffmpeg: detect and fix negative time stampsMax Kellermann2014-12-151-4/+7
| | | | | | | | | | Works around assertion failure due to something that appears to be a (minor) FFmpeg bug.
* | LogBackend: force-flush stderr on WIN32Max Kellermann2014-12-171-0/+6
| | | | | | | | setvbuf() does not seem to have an effect on Windows.
* | LogInit: make stderr line-bufferedMax Kellermann2014-12-171-0/+3
| | | | | | | | | | Make sure everything gets logged right away. No delays because stdio's buffer is not yet full.
* | util/HugeAllocator: enable MEM_COMMIT on WindowsMax Kellermann2014-12-171-1/+3
| | | | | | | | | | Without MEM_COMMIT, the reserved address space is not accessible, and MPD crashes.
* | storage/nfs: add timeoutMax Kellermann2014-12-152-3/+13
| |
* | storage/nfs: clear last_error in SetState()Max Kellermann2014-12-151-0/+1
| | | | | | | | Fixes bogus assertion failure.
* | lib/nfs/Connection: unregister socket with SocketMonitor::Steal()Max Kellermann2014-12-151-1/+1
| | | | | | | | | | SocketMonitor::Cancel() does not actually unregister the socket; it only disables the event.
* | lib/nfs/Connection: implement mount timeoutMax Kellermann2014-12-152-2/+31
| |
* | lib/nfs/Connection: add debug flag "in_destroy"Max Kellermann2014-12-152-0/+11
| |
* | lib/nfs/Connection: add assertionMax Kellermann2014-12-141-0/+2
| |
* | lib/nfs/Connection: fix reconnect after mount failureMax Kellermann2014-12-141-1/+1
| | | | | | | | | | | | | | When mounting had not yet finished, SocketMonitor::IsDefined() was always false, due to the workaround at the beginning of the function that calls SocketMonitor::Steal(). This commit drops the IsDefined() check because it was never necessary and breaks reconnect.
* | lib/nfs/Connection: fix typo in code commentMax Kellermann2014-12-141-1/+1
| |
* | lib/nfs/Connection: fix memory leak (and assertion failure)Max Kellermann2014-12-143-0/+28
| | | | | | | | | | | | | | | | | | | | | | nfs_destroy_context() will invoke all pending callbacks with err==-EINTR. In CancellableCallback::Callback(), this will invoke NfsConnection::DeferClose(), which however is only designed to be called from nfs_service(). In non-debug mode, this will leak memory because nfs_close_async() is never called. Workaround: before nfs_destroy_context(), invoke nfs_close_async() on all pending file handles.
* | lib/nfs/Connection: move code to Service()Max Kellermann2014-12-142-12/+28
| |