Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | screen_search: use filelist_new() instead of g_malloc0() | Max Kellermann | 2008-11-30 | 1 | -1/+1 | |
| | | | | | | Using the advanced search led to a segmentation fault, because with g_malloc0(), the filelist's "entries" array was not allocated. Use the "official" filelist constructor instead. | |||||
* | list_window: converted "flags" to one "bool" variable | Max Kellermann | 2008-11-27 | 7 | -12/+11 | |
| | | | | | | Currently, there is only one known list_window flag ("hide_cursor"). Replace the "flags" bit field with a boolean variable. If we run out of space some day, we can convert that to bool:1. | |||||
* | list_window: use "bool" instead of "int" | Max Kellermann | 2008-11-27 | 12 | -67/+66 | |
| | | | | | For flags and return values, use the "bool" data type instead of "int". | |||||
* | list_window: fixed endless loop in non-wrapped search | Max Kellermann | 2008-11-27 | 1 | -4/+5 | |
| | | | | | | When the cursor was at the end of a list and the user pressed 'n', ncmpc would hang in an endless loop forever. The same bug was fixed in the backwards search. | |||||
* | screen_artist: fixes for the ncmpc-mini build | Max Kellermann | 2008-11-25 | 1 | -1/+7 | |
| | | | | | Disable the highlighting code which has slipped out of the NCMPC_MINI checks. | |||||
* | ncmpc-mini: disable scrolling | Max Kellermann | 2008-11-25 | 3 | -1/+19 | |
| | | | | | The scrolling code broke in the ncmpc-mini build. Disable it when --enable-mini was specified. | |||||
* | po: improved translatable strings for easier translation | Max Kellermann | 2008-11-25 | 9 | -27/+25 | |
| | | | | Remove exclamation marks and other markup from the strings. | |||||
* | screen: simplify screen list strings | Max Kellermann | 2008-11-25 | 1 | -24/+20 | |
| | | | | | Removed the colon and the spaces from the translatable screen names. This aims to simplify the translator's job. | |||||
* | list_window: reset cursor when list is empty | Max Kellermann | 2008-11-25 | 1 | -1/+3 | |
| | | | | | Due to a side effect of the old "if" condition, the cursor was never reset to the origin when the list was cleared. | |||||
* | screen_lyrics: reset cursor when the song changes | Max Kellermann | 2008-11-25 | 1 | -0/+2 | |
| | | | | | When the view is changed and a new song is about to be displayed, reset the list's state and scroll back to the origin. | |||||
* | removed gcc.h | Max Kellermann | 2008-11-24 | 2 | -71/+1 | |
| | | | | gcc.h has been replaced with GLib's G_GNUC_ macros. | |||||
* | screen_search.c: replaced mpd_unused by G_GNUC_UNUSED | Thomas Jansen | 2008-11-24 | 1 | -5/+4 | |
| | ||||||
* | screen_play.c: replaced mpd_unused by G_GNUC_UNUSED | Thomas Jansen | 2008-11-24 | 1 | -5/+6 | |
| | ||||||
* | screen_lyrics.c: replaced mpd_unused by G_GNUC_UNUSED | Thomas Jansen | 2008-11-24 | 1 | -3/+3 | |
| | ||||||
* | screen_keydef.c: replaced mpd_unused by G_GNUC_UNUSED | Thomas Jansen | 2008-11-24 | 1 | -4/+3 | |
| | ||||||
* | screen_help.c: replaced mpd_unused by G_GNUC_UNUSED | Thomas Jansen | 2008-11-24 | 1 | -4/+3 | |
| | ||||||
* | screen_file.c: replaced mpd_unused by G_GNUC_UNUSED | Thomas Jansen | 2008-11-24 | 1 | -4/+3 | |
| | ||||||
* | screen_browser.c: replaced mpd_unused by G_GNUC_UNUSED | Thomas Jansen | 2008-11-24 | 1 | -2/+1 | |
| | ||||||
* | screen_artist.c: replaced mpd_unused by G_GNUC_UNUSED | Thomas Jansen | 2008-11-24 | 1 | -3/+3 | |
| | ||||||
* | main.c: replaced mpd_unused by G_GNUC_UNUSED | Thomas Jansen | 2008-11-24 | 1 | -11/+11 | |
| | ||||||
* | lyrics.c: replaced mpd_unused by G_GNUC_UNUSED | Thomas Jansen | 2008-11-24 | 1 | -3/+2 | |
| | ||||||
* | lirc: use GLib's G_GNUC_UNUSED instead of mpd_unused | Max Kellermann | 2008-11-23 | 1 | -2/+2 | |
| | | | | | The header gcc.h is going to fade away, in favor of GLib's G_GNUC_ macros. | |||||
* | screen_play: scroll long song names in the playlist | Matt Portas | 2008-11-21 | 1 | -1/+20 | |
| | | | | | If the song name under the cursor is too long for the terminal, scroll it like in the statusbar. | |||||
* | screen_search: don't include ncurses.h directly | Max Kellermann | 2008-11-19 | 1 | -1/+0 | |
| | | | | | | screen.h has a check whether to include ncursesw/ncurses.h or ncurses.h. screen_search.c doesn't need to include it a second time, and was missing the check. | |||||
* | screen_song: support CMD_SCREEN_LYRICS | Max Kellermann | 2008-11-19 | 1 | -0/+10 | |
| | | | | Show the lyrics of the song currently being displayed. | |||||
* | screen_song: free the song pointer | Max Kellermann | 2008-11-19 | 1 | -0/+5 | |
| | | | | Fix a memory leak. | |||||
* | screen_lyrics: support CMD_VIEW | Max Kellermann | 2008-11-19 | 1 | -0/+10 | |
| | | | | Jump to the song viewer screen. | |||||
* | screen_song: include cleanup | Max Kellermann | 2008-11-19 | 1 | -5/+0 | |
| | ||||||
* | screen_song: check CMD_VIEW only if song screen is enabled | Max Kellermann | 2008-11-19 | 3 | -0/+6 | |
| | ||||||
* | screen_song: new screen which views song information | Max Kellermann | 2008-11-18 | 8 | -0/+225 | |
| | | | | | This new screen views all information available on a song: its location, file name, and tags. | |||||
* | libmpdclient: converted MPD_ERROR_ constants to enum | Max Kellermann | 2008-11-18 | 1 | -11/+35 | |
| | ||||||
* | libmpdclient: convert MPD_ACK_ constants to enum | Max Kellermann | 2008-11-18 | 1 | -14/+17 | |
| | ||||||
* | command: change 'locate' default hotkey to 'G' | Max Kellermann | 2008-11-18 | 1 | -1/+1 | |
| | | | | Use the same hotkey as ncmpcpp. | |||||
* | screen_browser: always declare variable "entry" | Max Kellermann | 2008-11-18 | 1 | -2/+0 | |
| | | | | | The local variable "entry" was only declared when lyrics were enabled, but it is now used by CMD_LOCATE, too. | |||||
* | screen: method cmd() returns bool | Max Kellermann | 2008-11-18 | 8 | -54/+54 | |
| | | | | Return true/false instead of 1/0. | |||||
* | ncu: include config.h, fix mouse and color support | Max Kellermann | 2008-11-18 | 1 | -0/+1 | |
| | | | | | Due to config.h not being included, mouse and color support was always disabled. | |||||
* | command: added CMD_LOCATE to locate song in database | Max Kellermann | 2008-11-18 | 8 | -0/+80 | |
| | | | | | Pressing 'l' switches to the file browser (screen_file) and locates the previously selected song in the server's database. | |||||
* | screen_lyrics: duplicate current song | Max Kellermann | 2008-11-18 | 1 | -4/+9 | |
| | | | | | | Don't store a pointer to the song passed to screen_lyrics_switch(), duplicate it instead. In the long term, it is too unsafe to work with a foreign pointer. | |||||
* | screen_{file,artist,search}: repaint only if screen is visible | Max Kellermann | 2008-11-18 | 3 | -3/+6 | |
| | | | | | Don't repaint the screen after browser_cmd() if another screen has been selected meanwhile. | |||||
* | filelist: filelist_find_song() returns position instead of pointer | Max Kellermann | 2008-11-18 | 3 | -6/+8 | |
| | | | | | | Making the function return the index makes it more flexible: those who want the pointer can use filelist_get(), and the others may use the index for other purposes. | |||||
* | screen_browser: eliminated local variable "entity" | Max Kellermann | 2008-11-18 | 1 | -2/+0 | |
| | | | | "entity" is not being used after its initial assignment. | |||||
* | screen_browser: check if filelist is set | Max Kellermann | 2008-11-18 | 1 | -3/+8 | |
| | | | | | | | When calling browser_change_directory() before a filelist was set, ncmpc would crash due to a NULL pointer dereference. This scenario is not possible currently, since the open() method allocates the filelist. | |||||
* | screen_browser: use bool for return values | Max Kellermann | 2008-11-18 | 2 | -23/+23 | |
| | | | | Return true/false instead of 0/-1. | |||||
* | screen_lyrics: added gettext markers | Max Kellermann | 2008-11-18 | 1 | -6/+9 | |
| | ||||||
* | Makefile.am: added screen_play.h to $(ncmpc_headers) | Max Kellermann | 2008-11-17 | 1 | -0/+1 | |
| | | | | screen_play.h was missing in the tarball. | |||||
* | screen_utils: check for NULL password | Max Kellermann | 2008-11-17 | 1 | -1/+10 | |
| | | | | | | | Fix a NULL pointer dereference and a memory leak: check if screen_read_password() returns NULL, and don't call mpd_sendPasswordCommand(NULL) in this case. Free the password when done. | |||||
* | lirc: refactored event handler | Thomas Jansen | 2008-11-10 | 4 | -57/+55 | |
| | | | | | | | * moved lirc_event to lirc.c and split out the parts that depend on variables in main.c into three separate functions * changed keyboard_event accordingly to avoid duplicate code * merged lirc_event with ncmpc_lirc_get_command | |||||
* | mpdclient: use g_utf8_collate() | Max Kellermann | 2008-11-07 | 1 | -8/+3 | |
| | | | | | Use one g_utf8_collate() call instead of g_utf8_collate_key() twice plus strcmp(). | |||||
* | wreadln: return NULL instead of empty string | Max Kellermann | 2008-11-07 | 4 | -8/+6 | |
| | | | | | | No wreadln() caller cares about an empty string. Simplify the callers by returning NULL instead of an allocated empty string. This fixes several memory leaks. | |||||
* | mpdclient: removed _utf8 suffix from function names | Max Kellermann | 2008-11-07 | 6 | -13/+13 | |
| | | | | | All functions must receive UTF-8 file names. Delete all which still work with locale strings, and remove the _utf8 suffix from the others. |