aboutsummaryrefslogtreecommitdiffstats
path: root/src (follow)
Commit message (Collapse)AuthorAgeFilesLines
* playlist: fix "currentsong" at end-of-playlistEric Wong2008-10-041-4/+11
| | | | | | | The current song information could get cleared if we got to the end of the playlist and mpd is not in repeat mode. This also prevents "currentsong" from returning information if mpd is not playing.
* Switch to C99 types (retaining compat with old compilers)Eric Wong2008-09-2931-132/+150
| | | | | | | | | | | | | | | Seeing the "mpd_" prefix _everywhere_ is mind-numbing as the mind needs to retrain itself to skip over the first 4 tokens of a type to get to its meaning. So avoid having extra characters on my terminal to make it easier to follow code at 2:30 am in the morning. Please report any new issues you may come across on Free toolchains. I realize how difficult it can be to build/maintain cross-compiling toolchains and I have no intention of forcing people to upgrade their toolchains to build mpd. Tested with gcc 2.95.4 and and gcc 4.3.1 on x86-32.
* allow searching for albums with an empty tagEric Wong2008-09-292-1/+25
| | | | | | | | | | | | | | | | | | | | tfing wrote: > I have quite some files with an empty album tag as they do not come > from a particular album. > > If I want to look for those files and browse them, this happens: > :: nc localhost 6600 > OK MPD 0.12.0 > find album "" > ACK [2@0] {find} too few arguments for "find" > > I'd like to be able to browse those files in a client like gmpc. > So these 2 items would have to be developed: > - list album should report that some files have an empty tag > - it should be possible to search for an empty tag with the find command Patch-by: Marc Pavot ref: http://musicpd.org/mantis/view.php?id=464
* Merge branch 'ew/directory'Eric Wong2008-09-2912-375/+341
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ew/directory: directory: remove redundant sanitizePathDup update: move path sanitation up the stack to avoid extra copies clean up updateInit calling and error handling directory: isRootDirectory() is a one-liner directory: writeDirectoryInfo propagates errors directory: make it clear that DIRECTORY_MTIME is deprecated directory: remove "Mp3" references playlist: deleteASongFromPlaylist takes a const Song * songvec: songvec_delete takes a const Song pointer directory: remove shortname arguments everywhere path: add mpd_basename() function directory.h: remove directory_sigChldHandler decl directory: replace DirectoryList with dirvec directory: remove unused CPP defines songvec_free => songvec_destroy directory.c: kill unnecessary includes
| * directory: remove redundant sanitizePathDupEric Wong2008-09-291-15/+7
| | | | | | | | | | | | | | We already sanitize and duplicated our paths before calling updateInit() to get pre-pthread_create() error-checking along with heap allocation reduction because we don't have to redupe because our parent stack went away.
| * update: move path sanitation up the stack to avoid extra copiesEric Wong2008-09-293-30/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove yet another use of our old malloc-happy linked list implementation and replace it with a simple array of strings. This also implements more eager error handling of invalid paths (still centralized in updateInit) so we can filter out bad paths before we spawn a thread. This also does its part to fix the "update" command inside list mode which lost its static variable in ada24f9a921ff95d874195acf253b5a9dd12213d (although it was broken and requires the fix in 769939b62f7557f8e7c483223d68a8b39af43e37, too).
| * clean up updateInit calling and error handlingEric Wong2008-09-283-13/+22
| | | | | | | | | | Move error reporting to command.c so directory.c does not deal with client error handling any more.
| * directory: isRootDirectory() is a one-linerEric Wong2008-09-281-4/+1
| | | | | | | | Improving the signal to noise ratio...
| * directory: writeDirectoryInfo propagates errorsEric Wong2008-09-281-28/+19
| | | | | | | | | | If a write failed, it's a good sign subsequent writes will fail, too, so propgate errors all the way up the stack.
| * directory: make it clear that DIRECTORY_MTIME is deprecatedEric Wong2008-09-281-1/+1
| | | | | | | | A long time ago in an mpd far away...
| * directory: remove "Mp3" referencesEric Wong2008-09-283-22/+22
| | | | | | | | | | MPD has supported more audio formats than just MP3 for over five years...
| * playlist: deleteASongFromPlaylist takes a const Song *Eric Wong2008-09-282-2/+2
| | | | | | | | We don't change the song pointer there, either.
| * songvec: songvec_delete takes a const Song pointerEric Wong2008-09-282-2/+2
| | | | | | | | We don't modify the Song when we delete it
| * directory: remove shortname arguments everywhereEric Wong2008-09-281-79/+40
| | | | | | | | | | | | It was a huge confusing mess of parameter passing around and around. Add a few extra assertions to ensure we're handling parent/child relationships properly.
| * path: add mpd_basename() functionEric Wong2008-09-282-0/+20
| | | | | | | | | | | | | | This is like basename(3) but with predictable semantics independent of C library or build options used. This is also much more strict and does not account for trailing slashes (mpd should never deal with trailing slashes on internal functions).
| * directory.h: remove directory_sigChldHandler declEric Wong2008-09-281-2/+0
| | | | | | | | | | We no longer fork for directory updates, so we no longer have children to reap.
| * directory: replace DirectoryList with dirvecEric Wong2008-09-284-197/+175
| | | | | | | | | | Small memory reduction compared to songvec since most users have much fewer dirs than songs, but still nice to have.
| * directory: remove unused CPP definesEric Wong2008-09-281-4/+0
| | | | | | | | We no longer for for updates
| * songvec_free => songvec_destroyEric Wong2008-09-283-3/+3
| | | | | | | | | | "free" implies the songvec structure itself is freed, which is not the case.
| * directory.c: kill unnecessary includesEric Wong2008-09-281-4/+0
| |
* | Merge branch 'mk/flac'Eric Wong2008-09-294-128/+131
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * mk/flac: flac: removed FlacData.chunk_length flac: merged flacSendChunk() into flac_common_write() flac: removed generic sample size support flac: added special functions for 8 and 32 bit flac: added optimized converter for 16 bit flac: use signed integers in flac_convert_stereo16() flac: moved code from flacWrite() to _flac_common.c flac: assume the buffer is empty in flacWrite() II
| * | flac: removed FlacData.chunk_lengthMax Kellermann2008-09-294-9/+3
| | | | | | | | | | | | | | | chunk_length can be converted to a local variable, because it is always reset to 0 after it was used.
| * | flac: merged flacSendChunk() into flac_common_write()Max Kellermann2008-09-291-11/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since flacSendChunk() is a trivial function and is only used in one location, move the code there. The advantage is that calling decoder_data() directly returns the decoder_command value, so we can eliminate one decoder_get_command() call. [ew: using the terser API in the main branch, it always eliminated the dc_intr()/dc_seek() call, but I agree that killing a camel, err.. camelCase function is a good thing]
| * | flac: removed generic sample size supportMax Kellermann2008-09-291-31/+27
| | | | | | | | | | | | | | | | | | | | | | | | Support for bit rates except 16 bits (and 8 bits on little endian) has always been broken. Since we added optimized functions for 8, 16, 24/32 bits, we can remove the generic flac_convert() function. Instead of removing it, convert it to a wrapper function for flac_convert_*().
| * | flac: added special functions for 8 and 32 bitMax Kellermann2008-09-291-0/+37
| | | | | | | | | | | | | | | Same optimization for 8 and 32 bit files, like the previous patch for 16 bit. Along the way, this patch adds 24 bit FLAC support!
| * | flac: added optimized converter for 16 bitMax Kellermann2008-09-291-0/+17
| | | | | | | | | | | | | | | | | | flac_convert_16() runs a lot faster than the generic (and quite buggy) function flac_convert(). flac_convert_16() is only used for non-stereo files, since there is already flac_convert_stereo16().
| * | flac: use signed integers in flac_convert_stereo16()Max Kellermann2008-09-291-6/+4
| | | | | | | | | | | | | | | | | | By mistake, I casted the sample value to uint16_t, which is wrong. This patch simplifies the code by using a int16_t pointer instead of casting to int16_t* every time.
| * | flac: moved code from flacWrite() to _flac_common.cMax Kellermann2008-09-294-120/+90
| | | | | | | | | | | | | | | | | | | | | There is still a lot of duplicated code in flac_plugin.c and oggflac_plugin.c. Move code from flac_plugin.c to _flac_common.c, and use the new function flac_common_write() also in oggflac_plugin.c, porting lots of optimizations over to it.
| * | flac: assume the buffer is empty in flacWrite() IIMax Kellermann2008-09-291-6/+2
| |/ | | | | | | | | The previous patch on this topic was incomplete: it still added data->chunk_length when calling flac_convert(). Remove this, too.
* | Merge branch 'mk/pcm'Eric Wong2008-09-291-18/+28
|\ \ | | | | | | | | | | | | | | | * mk/pcm: pcm_utils: added pcm_range() pcm_utils: added inline function pcm_dither()
| * | pcm_utils: added pcm_range()Max Kellermann2008-09-291-10/+18
| | | | | | | | | | | | | | | | | | | | | Make the code more readable by moving the range checks to pcm_range(). gcc does quite a good job at optimizing it: the resulting binary is exactly the same, although it contains a parametrized shift instead of hard-coded boundaries.
| * | pcm_utils: added inline function pcm_dither()Max Kellermann2008-09-291-8/+10
| |/ | | | | | | | | Merge some code into an inline function, so we can optimize it later only once.
* / command: don't clobber next list value when preparsingEric Wong2008-09-291-3/+6
|/ | | | | | | This only breaks "update" under list command mode and no other commands. This can be done more optimally without the extra heap allocation via xstrdup(); but is uncommon enough to not matter.
* directory: update playlist version if updatedEric Wong2008-09-281-1/+6
| | | | | | | | | | | | If we updated the mpd metadata database; then there's a chance some of those songs in the playlist will have updated metadata. So be on the safe side and increment the playlist version number if _any_ song changed (this is how all released versions of mpd did it, too). This bug was introduced recently when making "update" threaded. Thanks to stonecrest for the bug report.
* playlist: fix currentsong info after swapping songsEric Wong2008-09-281-0/+4
| | | | | | | | | | We forgot to update the playlist.queued marker if playlist.current changed. Additionally, if the queue cleared in any other mode, attempt to requeue (as it's a harmless no-op otherwise). Thanks to stonecrest for the bug report.
* playlist: reset after we've hit the endEric Wong2008-09-281-0/+6
| | | | | If repeat is off, we reset (and reshuffle in random mode) the playlist.
* advance to the next song on decoder errorsEric Wong2008-09-283-6/+17
| | | | | | Fix this regression introduced in the core rewrite so that we now skip to the next song when we encounter an error with the song we tried to decode.
* song: removed type SongListMax Kellermann2008-09-264-45/+2
| | | | SongList has been superseded by struct songvec.
* command: fix command "addid"Max Kellermann2008-09-261-1/+1
| | | | | | With patch 8d2830b3, I broke "addid": it did not return the id of the new song, because of a typo in the return condition (== instead of !=).
* Revert "directory: serialize freeSong() within the main thread"Eric Wong2008-09-231-9/+1
| | | | | | | | This reverts commit efefaee1f9535012be2fbfea8f0f870904daad5d. Conflicts: src/directory.c
* songvec: avoid free(NULL)Eric Wong2008-09-231-2/+4
| | | | Potentially broken free() implementations don't like it
* directory: use songvec_free to prevent memory leaks.Eric Wong2008-09-231-2/+1
|
* directory: fix leak introduced with threaded updateEric Wong2008-09-231-1/+1
| | | | | Use freeList() instead of free() to free all elements in the list.
* directory: serialize freeSong() within the main threadEric Wong2008-09-231-1/+10
| | | | | | | | | | | | | | | | | | It's possible the playlist will be accessing a song that is to be freed in the update thread. Rather than going through the complexity (and potential to make mistakes) of locking the playlist (as well as losing CPU cycles/pipelining due to barriers with mutexes), we'll just line up all songs to be freed in the main thread. It's relatively uncommon to call freeSong() heavily (as it is to update); so the extra, temporary memory usage won't be very noticeable. Additionally, if a song is renamed and it contains unique tag item; this has the additional side effect of preventing unnecessary fragmentation where an item is freed and shortly reallocated.
* log: remove umask() calls, just change open(2) argsEric Wong2008-09-221-8/+2
| | | | The umask calls were remants of when we used fopen().
* Remove EINTR checking for open(2)Eric Wong2008-09-222-4/+2
| | | | open(2) should only interrupt on "slow" devices, afaik...
* directory: don't leak file handles if we get a corrupt dbEric Wong2008-09-221-1/+1
|
* Merge branch 'ew/directory'Eric Wong2008-09-228-221/+102
|\ | | | | | | | | | | | | * ew/directory: songvec: remove songvec_prune directory: update do its work inside a thread directory: use enum update_return for return values
| * songvec: remove songvec_pruneEric Wong2008-09-223-27/+0
| | | | | | | | | | | | Any pruned files will be noticed during update and pruned from the live database, so this inefficient function can go away and never come back.
| * directory: update do its work inside a threadEric Wong2008-09-225-125/+56
| | | | | | | | | | | | | | | | | | A lot of the preparation was needed (and done in previous months) in making update thread-safe, but here it is. This was the first thing I made work inside a thread when I started mpd-uclinux many years ago, and also the last thing I've done in mainline mpd to work inside a thread, go figure.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 15:35:06 +0000