aboutsummaryrefslogtreecommitdiffstats
path: root/src (follow)
Commit message (Collapse)AuthorAgeFilesLines
* free info entity while iteratingMax Kellermann2008-09-151-0/+2
| | | | | | Memory leak: the function mpdclient_playlist_update_changes() did not free the entity which was returned by mpd_getNextInfoEntity(). Add a mpd_freeInfoEntity() call at the end of each iteration.
* manage tag string allocations in a poolMax Kellermann2008-09-154-44/+200
| | | | | | There are many duplicated strings in the tag database, e.g. many songs having the same artist. Don't allocate such strings twice, manage all strings in a pool.
* added support for unix domain socketsMax Kellermann2008-09-151-1/+58
| | | | | | If a host name starts with a slash, it is assumed to be a unix domain socket path. The port is ignored. This code is disabled on WIN32, until someone tests it.
* lyrics: missing "break"Max Kellermann2008-09-151-1/+2
| | | | If get_text_line() fails, we should break from the loop.
* lyrics: converted global variables to staticMax Kellermann2008-09-152-6/+3
| | | | | | The variables "lyrics_text_rows" and "lw" were declared in src_lyrics.h as static, but they were only actually used in screen_lyrics.c. Move both there.
* fix unused parameter warningsMax Kellermann2008-09-158-47/+59
| | | | | Add the "unused" attribute to all function parameters which are indeed going to be ignored.
* imported gcc.h from mpdMax Kellermann2008-09-152-1/+71
| | | | gcc.h contains a useful set of macros for setting attributes.
* don't declare local variable "options"Max Kellermann2008-09-153-13/+15
| | | | | | | | | In main.c, the global variable "options" is used all over, except in main(), which contains a shadowing declaration of it. Remove this local variable, and use the global "options" instead. Also don't pollute conf.c's namespace with the global variable with a CPP hack (to be removed when we have fixed more of ncmpc's namespace pollution).
* use size_t and unsigned integersMax Kellermann2008-09-1518-114/+130
|
* fixed mixed declaration + codeMax Kellermann2008-09-153-16/+19
| | | | | Although they are allowedd in C99, try to avoid them. Move variable declarations to the top of the current scope.
* fix shadow warningsMax Kellermann2008-09-1510-144/+148
| | | | | Rename local variables and function parameters, so they don't shadow global variables.
* include cleanupMax Kellermann2008-09-1536-167/+173
| | | | | | A header should include all headers which he needs. Move local includes on top, and let foo.c include foo.h in the first line, to automatically test its dependencies.
* screen_auth() returns resultMax Kellermann2008-09-151-1/+2
| | | | | | screen_auth() returns an int, and its result is actually being used. Only the "return" was missing in its implementation. Return _screen_auth()'s result.
* fix function prototypesMax Kellermann2008-09-1515-39/+84
| | | | | | Add missing prototypes, and fix wrong prototypes. Convert lots of functions to "static" when they are only used within the current source file.
* const pointersMax Kellermann2008-09-1533-134/+135
| | | | | Convert pointers to const whenever it is possible. Fixes all those -Wconst warnings.
* clock: don't initialize static variables with zeroMax Kellermann2008-09-151-1/+1
| | | | | | Uninitialized static variables are put into BSS, which is automatically zeroed. Initializing doesn't hurt, but in this case, there were elements missing, emitting a gcc warning.
* screen: moved code to paint_top_window2()Max Kellermann2008-09-151-68/+74
| | | | | | Nearly all of the code in paint_top_window() is on indent level 2, just because it depends on a condition. Make this more readable and move to indent level 1 by moving this code to a separate function.
* use !NDEBUG instead of DEBUGMax Kellermann2008-09-154-7/+7
| | | | | NDEBUG is more commonly used than DEBUG, e.g. in assert.h. Convert all macros to NDEBUG, and declare NDEBUG when debugging is disabled.
* code style, indent with tabsMax Kellermann2008-09-1529-4250/+3931
| | | | | | | Follow the same code style als MPD itself. This patch only fixes parts of the code which are going to be touched in the following bunch of patches, i.e. there will be more "code style" patches in the future.
* remove unused static functionsMax Kellermann2008-09-1518-72/+17
| | | | Also remove some commented code and unused function parameters.
* splash: removed the useless splash screenMax Kellermann2008-09-157-142/+2
| | | | | The code looks strange and spews lots of warnings. Since it does nothing useful, and wastes the user's precious time, simply remove it.
* improve escaping of URLsAndreas Obergrusberger2008-01-181-5/+5
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@7141 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* make item highlighiting more appropriateAndreas Obergrusberger2007-11-301-4/+1
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@7062 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* cmd_select_all addedAndreas Obergrusberger2007-11-306-0/+96
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@7061 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* fixed 0001496Andreas Obergrusberger2007-08-261-0/+13
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@6817 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Removed nested functionsAndreas Obergrusberger2007-08-263-213/+335
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@6811 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* 2 critical bugs in leoslyrics lyrics src fixedAndreas Obergrusberger2007-06-171-2/+7
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@6630 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* fix segfaultAndreas Obergrusberger2007-03-292-3/+8
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@5773 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* ugh!Andreas Obergrusberger2007-03-141-1/+1
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@5621 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* way too much stuff to describe hereAndreas Obergrusberger2007-02-1611-38/+127
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@5346 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* lyrics updates, leoslyrics fixesAndreas Obergrusberger2007-02-015-16/+12
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@5314 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* fix user plugin dir; code cleanupAndreas Obergrusberger2007-01-053-10/+16
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@5220 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* fix error display on lyrics screenAndreas Obergrusberger2007-01-031-7/+7
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@5219 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* added a plugin system for lyrics sourcesAndreas Obergrusberger2007-01-038-304/+566
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@5217 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* Daniel rocked the houseAndreas Obergrusberger2006-11-115-12/+51
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@5041 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* go to root/parent dir key addedAndreas Obergrusberger2006-11-084-9/+36
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@5034 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* filelist sorting improvedAndreas Obergrusberger2006-10-282-0/+40
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@4953 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* you can specify %shortalbum% for playlist song markup, parent directory is ↵Andreas Obergrusberger2006-10-052-1/+30
| | | | | | shown in the browse screen title git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@4871 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* http://musicpd.org/mantis/view.php?id=1324Andreas Obergrusberger2006-09-091-1/+6
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@4757 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* multi liner ;) fixed segfaultAndreas Obergrusberger2006-09-082-8/+7
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@4749 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* disable splash by defaultAndreas Obergrusberger2006-09-081-1/+1
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@4744 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* oppps forgot 2 files...Andreas Obergrusberger2006-09-082-0/+126
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@4742 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* due to bensonk's demand i added a splash screen.Andreas Obergrusberger2006-09-0710-21/+124
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@4741 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* use older revision till serious bugfixAndreas Obergrusberger2006-08-281-394/+376
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@4704 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* make compilation work againAndreas Obergrusberger2006-08-261-3/+6
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@4697 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* code cleanupAndreas Obergrusberger2006-08-261-210/+225
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@4695 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* fix a bug the makes utf8 names behave evilAndreas Obergrusberger2006-08-251-2/+2
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@4683 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* spelling fixes by avutonAndreas Obergrusberger2006-08-125-5/+5
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@4615 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* fix a bug that doubled empty lines when loading lyrics from hdAndreas Obergrusberger2006-08-081-1/+1
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@4601 09075e82-0dd4-0310-85a5-a0d7c8717e4f
* avuton fixed some warningsAndreas Obergrusberger2006-08-082-4/+7
| | | | git-svn-id: https://svn.musicpd.org/ncmpc/branches/tradiaz@4600 09075e82-0dd4-0310-85a5-a0d7c8717e4f
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-28 11:09:27 +0000