aboutsummaryrefslogtreecommitdiffstats
path: root/src (follow)
Commit message (Collapse)AuthorAgeFilesLines
* input/async: reset the "open" flag after seeking successfullyMax Kellermann2015-01-061-0/+5
| | | | | | | | | Fixes a problem with the "curl" input plugin: IsEOF() always returns true because the "open" flag was cleared by CurlInputStream::RequestDone() when end-of-stream was reached. This flag stays false even when seeking to another position has succeeded. This patch resets the "open" flag to true after seeking successfully.
* thread/Name: disable pthread_setname_np() on NetBSDMax Kellermann2015-01-061-2/+6
| | | | | | | NetBSD's pthread_setname_np() prototype is incompatible with the rest of the world, and it requires to pass the string argument as a non-const pointer. Instead of working around this misdesign, I hereby disable the feature on NetBSD.
* thread/Name: enable FormatThreadName() with prctl()Max Kellermann2015-01-061-1/+5
| | | | | | Add macro HAVE_THREAD_NAME which is set when any method to set the thread name is available. Use that macro in FormatThreadName() instead of just checking for HAVE_PTHREAD_SETNAME_NP.
* thread/Name: indent preprocessor commandsMax Kellermann2015-01-061-3/+3
|
* db/simple: fix implicit nullptr/bool conversionMax Kellermann2014-12-263-5/+5
| | | | | Return false on error, not nullptr.
* fs/Traits, ...: work around -Wtautological-pointer-compareMax Kellermann2014-12-265-1/+32
| | | | New in clang 3.6.
* db/lazy, input/mms: add "override" keywordsMax Kellermann2014-12-263-4/+6
| | | | Fixes -Winconsistent-missing-override (clang 3.6).
* Merge branch 'v0.18.x' into v0.19.xMax Kellermann2014-12-2618-51/+110
|\
| * db/proxy, output/shout: fix implicit nullptr/bool conversionMax Kellermann2014-12-262-4/+4
| | | | | | | | Return false on error, not nullptr.
| * db/{simple,proxy}, ...: add "override" keywordsMax Kellermann2014-12-267-22/+26
| | | | | | | | Fixes -Winconsistent-missing-override (clang 3.6).
| * util/{ASCII,UriUtil}, ...: work around -Wtautological-pointer-compareMax Kellermann2014-12-2610-0/+51
| | | | | | | | New in clang 3.6.
| * DatabaseGlue: convert nullptr check to assertionMax Kellermann2014-12-261-3/+2
| |
| * util/ASCII: fix indentMax Kellermann2014-12-261-10/+10
| |
| * Compiler.h: add macro CLANG_CHECK_VERSION()Max Kellermann2014-12-261-0/+7
| |
| * Compiler.h: add macro GCC_OLDER_THAN()Max Kellermann2014-12-262-4/+12
| |
| * util/Manual: reimplement GCC_CHECK_VERSION() using GCC_MAKE_VERSION()Max Kellermann2014-12-261-4/+3
| |
| * Compiler.h: add macro GCC_MAKE_VERSION()Max Kellermann2014-12-261-6/+4
| |
* | decoder/ffmpeg: support interleaved floating pointMax Kellermann2014-12-231-0/+1
| |
* | input/mms: limit the mmsx_read() sizeMax Kellermann2014-12-231-0/+7
| |
* | decoder/DsdLib: add missing stdlib.h includeMax Kellermann2014-12-231-0/+1
| |
* | DSF ID3 tags hitting 4k size limitJan Brittenson2014-12-231-6/+12
| | | | | | | | | | | | | | | | | | Here's a change to dynamically allocate the DSD ID3 tag buffer. Pretty much anything with cover art is going to exceed the existing, static 4k limit... Here's a change to dynamically allocate the buffer and sanity check it at some upper limit. I rather arbitrarily pulled 256k out of thin air just to keep a corrupt file from causing it to trying to allocate a buffer larger than available memory.
* | Merge tag 'v0.18.21' into v0.19.xMax Kellermann2014-12-172-5/+8
|\|
| * playlist/embcue: fix filename suffix detectionk442014-12-161-1/+1
| | | | | | | | | | The definition of the playlist_plugin struct member of the embcue plugin was incorrect.
| * decoder/ffmpeg: detect and fix negative time stampsMax Kellermann2014-12-151-4/+7
| | | | | | | | | | Works around assertion failure due to something that appears to be a (minor) FFmpeg bug.
* | LogBackend: force-flush stderr on WIN32Max Kellermann2014-12-171-0/+6
| | | | | | | | setvbuf() does not seem to have an effect on Windows.
* | LogInit: make stderr line-bufferedMax Kellermann2014-12-171-0/+3
| | | | | | | | | | Make sure everything gets logged right away. No delays because stdio's buffer is not yet full.
* | util/HugeAllocator: enable MEM_COMMIT on WindowsMax Kellermann2014-12-171-1/+3
| | | | | | | | | | Without MEM_COMMIT, the reserved address space is not accessible, and MPD crashes.
* | storage/nfs: add timeoutMax Kellermann2014-12-152-3/+13
| |
* | storage/nfs: clear last_error in SetState()Max Kellermann2014-12-151-0/+1
| | | | | | | | Fixes bogus assertion failure.
* | lib/nfs/Connection: unregister socket with SocketMonitor::Steal()Max Kellermann2014-12-151-1/+1
| | | | | | | | | | SocketMonitor::Cancel() does not actually unregister the socket; it only disables the event.
* | lib/nfs/Connection: implement mount timeoutMax Kellermann2014-12-152-2/+31
| |
* | lib/nfs/Connection: add debug flag "in_destroy"Max Kellermann2014-12-152-0/+11
| |
* | lib/nfs/Connection: add assertionMax Kellermann2014-12-141-0/+2
| |
* | lib/nfs/Connection: fix reconnect after mount failureMax Kellermann2014-12-141-1/+1
| | | | | | | | | | | | | | When mounting had not yet finished, SocketMonitor::IsDefined() was always false, due to the workaround at the beginning of the function that calls SocketMonitor::Steal(). This commit drops the IsDefined() check because it was never necessary and breaks reconnect.
* | lib/nfs/Connection: fix typo in code commentMax Kellermann2014-12-141-1/+1
| |
* | lib/nfs/Connection: fix memory leak (and assertion failure)Max Kellermann2014-12-143-0/+28
| | | | | | | | | | | | | | | | | | | | | | nfs_destroy_context() will invoke all pending callbacks with err==-EINTR. In CancellableCallback::Callback(), this will invoke NfsConnection::DeferClose(), which however is only designed to be called from nfs_service(). In non-debug mode, this will leak memory because nfs_close_async() is never called. Workaround: before nfs_destroy_context(), invoke nfs_close_async() on all pending file handles.
* | lib/nfs/Connection: move code to Service()Max Kellermann2014-12-142-12/+28
| |
* | lib/nfs/Connection: add assertionsMax Kellermann2014-12-141-0/+2
| |
* | lib/nfs/Connection: move code to method InternalClose()Max Kellermann2014-12-142-3/+17
| |
* | lib/nfs/Connection: make in_service and in_event debug-only flagsMax Kellermann2014-12-142-0/+11
| |
* | lib/nfs/Connection: fix crash while canceling a failing Open()Max Kellermann2014-12-141-2/+4
| | | | | | | | | | | | | | The method NfsConnection::CancellableCallback::Callback() will always invoke NfsConnection::Close() on the file handle, even if the void pointer is not a nfsfh. This can happen if the Open() was not successful, e.g. when the file does not exist.
* | event/Loop: read the "again" flag while holding mutexMax Kellermann2014-12-141-1/+2
| |
* | lib/nfs/Connection: add assertionsMax Kellermann2014-12-141-0/+31
| |
* | util/HugeAllocator: disable MEM_LARGE_PAGES on WindowsMax Kellermann2014-12-121-1/+2
| | | | | | | | | | | | MEM_LARGE_PAGES does not appear to work. Instead, MEM_RESERVE appears to be necessary. Until I figure this out, this large pages are disabled.
* | input/Init: eliminate double colon from log messageMax Kellermann2014-12-121-1/+1
| |
* | playlist/Print: don't skip non-existent songs in "listplaylist"Max Kellermann2014-12-091-6/+7
| | | | | | | | | | | | | | | | Skipping those songs silently will confuse the client, because commands specifying the song index within a playlist (e.g. playlistdelete) will be out of sync. This copies spl_print()'s behavior to playlist_file_print().
* | Merge tag 'v0.18.20' into v0.19.xMax Kellermann2014-12-082-2/+7
|\|
| * decoder/ffmpeg: support FFmpeg 2.5Max Kellermann2014-12-081-0/+5
| | | | | | | | | | | | Version 2.5 fixed an API oddity, however it broke API compatibility, at least with C++. Disable the workaround when a libavformat version is detected that is recent enough.
| * thread/Id: drop "::" prefix before pthread function namesMax Kellermann2014-12-081-2/+2
| | | | | | | | | | | | The "::" to explicitly refer to the global namespace appeared like a good idea in C++, but it breaks with C libraries that implement standard functions using macros (e.g. musl).
* | Output: start with a null mixer.Nix2014-12-011-0/+1
| | | | | | | | | | | | | | | | | | | | | | There are code paths (mostly error cases) in which it is possible to initialize an AudioOutput and then kill it without ever calling audio_output_new(). In such a case, its destructor will attempt to free a mixer that was never initialized, leading to an attempt to take out a lock on a mutex that was similarly never initialized, which hangs forever. Fix by always initializing the mixer appropriately.