aboutsummaryrefslogtreecommitdiffstats
path: root/src (follow)
Commit message (Collapse)AuthorAgeFilesLines
* screen: simplify screen list stringsMax Kellermann2008-11-251-24/+20
| | | | | Removed the colon and the spaces from the translatable screen names. This aims to simplify the translator's job.
* list_window: reset cursor when list is emptyMax Kellermann2008-11-251-1/+3
| | | | | Due to a side effect of the old "if" condition, the cursor was never reset to the origin when the list was cleared.
* screen_lyrics: reset cursor when the song changesMax Kellermann2008-11-251-0/+2
| | | | | When the view is changed and a new song is about to be displayed, reset the list's state and scroll back to the origin.
* removed gcc.hMax Kellermann2008-11-242-71/+1
| | | | gcc.h has been replaced with GLib's G_GNUC_ macros.
* screen_search.c: replaced mpd_unused by G_GNUC_UNUSEDThomas Jansen2008-11-241-5/+4
|
* screen_play.c: replaced mpd_unused by G_GNUC_UNUSEDThomas Jansen2008-11-241-5/+6
|
* screen_lyrics.c: replaced mpd_unused by G_GNUC_UNUSEDThomas Jansen2008-11-241-3/+3
|
* screen_keydef.c: replaced mpd_unused by G_GNUC_UNUSEDThomas Jansen2008-11-241-4/+3
|
* screen_help.c: replaced mpd_unused by G_GNUC_UNUSEDThomas Jansen2008-11-241-4/+3
|
* screen_file.c: replaced mpd_unused by G_GNUC_UNUSEDThomas Jansen2008-11-241-4/+3
|
* screen_browser.c: replaced mpd_unused by G_GNUC_UNUSEDThomas Jansen2008-11-241-2/+1
|
* screen_artist.c: replaced mpd_unused by G_GNUC_UNUSEDThomas Jansen2008-11-241-3/+3
|
* main.c: replaced mpd_unused by G_GNUC_UNUSEDThomas Jansen2008-11-241-11/+11
|
* lyrics.c: replaced mpd_unused by G_GNUC_UNUSEDThomas Jansen2008-11-241-3/+2
|
* lirc: use GLib's G_GNUC_UNUSED instead of mpd_unusedMax Kellermann2008-11-231-2/+2
| | | | | The header gcc.h is going to fade away, in favor of GLib's G_GNUC_ macros.
* screen_play: scroll long song names in the playlistMatt Portas2008-11-211-1/+20
| | | | | If the song name under the cursor is too long for the terminal, scroll it like in the statusbar.
* screen_search: don't include ncurses.h directlyMax Kellermann2008-11-191-1/+0
| | | | | | screen.h has a check whether to include ncursesw/ncurses.h or ncurses.h. screen_search.c doesn't need to include it a second time, and was missing the check.
* screen_song: support CMD_SCREEN_LYRICSMax Kellermann2008-11-191-0/+10
| | | | Show the lyrics of the song currently being displayed.
* screen_song: free the song pointerMax Kellermann2008-11-191-0/+5
| | | | Fix a memory leak.
* screen_lyrics: support CMD_VIEWMax Kellermann2008-11-191-0/+10
| | | | Jump to the song viewer screen.
* screen_song: include cleanupMax Kellermann2008-11-191-5/+0
|
* screen_song: check CMD_VIEW only if song screen is enabledMax Kellermann2008-11-193-0/+6
|
* screen_song: new screen which views song informationMax Kellermann2008-11-188-0/+225
| | | | | This new screen views all information available on a song: its location, file name, and tags.
* libmpdclient: converted MPD_ERROR_ constants to enumMax Kellermann2008-11-181-11/+35
|
* libmpdclient: convert MPD_ACK_ constants to enumMax Kellermann2008-11-181-14/+17
|
* command: change 'locate' default hotkey to 'G'Max Kellermann2008-11-181-1/+1
| | | | Use the same hotkey as ncmpcpp.
* screen_browser: always declare variable "entry"Max Kellermann2008-11-181-2/+0
| | | | | The local variable "entry" was only declared when lyrics were enabled, but it is now used by CMD_LOCATE, too.
* screen: method cmd() returns boolMax Kellermann2008-11-188-54/+54
| | | | Return true/false instead of 1/0.
* ncu: include config.h, fix mouse and color supportMax Kellermann2008-11-181-0/+1
| | | | | Due to config.h not being included, mouse and color support was always disabled.
* command: added CMD_LOCATE to locate song in databaseMax Kellermann2008-11-188-0/+80
| | | | | Pressing 'l' switches to the file browser (screen_file) and locates the previously selected song in the server's database.
* screen_lyrics: duplicate current songMax Kellermann2008-11-181-4/+9
| | | | | | Don't store a pointer to the song passed to screen_lyrics_switch(), duplicate it instead. In the long term, it is too unsafe to work with a foreign pointer.
* screen_{file,artist,search}: repaint only if screen is visibleMax Kellermann2008-11-183-3/+6
| | | | | Don't repaint the screen after browser_cmd() if another screen has been selected meanwhile.
* filelist: filelist_find_song() returns position instead of pointerMax Kellermann2008-11-183-6/+8
| | | | | | Making the function return the index makes it more flexible: those who want the pointer can use filelist_get(), and the others may use the index for other purposes.
* screen_browser: eliminated local variable "entity"Max Kellermann2008-11-181-2/+0
| | | | "entity" is not being used after its initial assignment.
* screen_browser: check if filelist is setMax Kellermann2008-11-181-3/+8
| | | | | | | When calling browser_change_directory() before a filelist was set, ncmpc would crash due to a NULL pointer dereference. This scenario is not possible currently, since the open() method allocates the filelist.
* screen_browser: use bool for return valuesMax Kellermann2008-11-182-23/+23
| | | | Return true/false instead of 0/-1.
* screen_lyrics: added gettext markersMax Kellermann2008-11-181-6/+9
|
* Makefile.am: added screen_play.h to $(ncmpc_headers)Max Kellermann2008-11-171-0/+1
| | | | screen_play.h was missing in the tarball.
* screen_utils: check for NULL passwordMax Kellermann2008-11-171-1/+10
| | | | | | | Fix a NULL pointer dereference and a memory leak: check if screen_read_password() returns NULL, and don't call mpd_sendPasswordCommand(NULL) in this case. Free the password when done.
* lirc: refactored event handlerThomas Jansen2008-11-104-57/+55
| | | | | | | * moved lirc_event to lirc.c and split out the parts that depend on variables in main.c into three separate functions * changed keyboard_event accordingly to avoid duplicate code * merged lirc_event with ncmpc_lirc_get_command
* mpdclient: use g_utf8_collate()Max Kellermann2008-11-071-8/+3
| | | | | Use one g_utf8_collate() call instead of g_utf8_collate_key() twice plus strcmp().
* wreadln: return NULL instead of empty stringMax Kellermann2008-11-074-8/+6
| | | | | | No wreadln() caller cares about an empty string. Simplify the callers by returning NULL instead of an allocated empty string. This fixes several memory leaks.
* mpdclient: removed _utf8 suffix from function namesMax Kellermann2008-11-076-13/+13
| | | | | All functions must receive UTF-8 file names. Delete all which still work with locale strings, and remove the _utf8 suffix from the others.
* mpdclient: expect UTF-8 stringsMax Kellermann2008-11-078-99/+65
| | | | | | Don't convert the character set of strings to and from the current locale. This library cannot know what the strings are going to be used for, so it should not mess with them.
* screen_search: fixed 2 memory leaksMax Kellermann2008-11-071-0/+6
| | | | | Free the old pattern before prompting for a new one. Free the old filelist object before retrieving the new one.
* screen_play: free the wreadln() return valueMax Kellermann2008-11-071-0/+1
|
* screen_browser: free g_path_get_dirname() return valueMax Kellermann2008-11-071-0/+1
| | | | | The function browser_change_directory() did not free the return value of g_path_get_dirname().
* screen_file: optimized title formulaMax Kellermann2008-11-071-12/+10
| | | | Don't allocate and copy memory.
* main: optimized error_msg()Max Kellermann2008-11-071-1/+2
| | | | The pointer has already been checked for NULL, eliminate that check.
* Makefile.am: added custom rule with -fwhole-programMax Kellermann2008-11-071-0/+6
| | | | | | | To make the ncmpc binary even smaller, you can compile all sources at once with "--combine -fwhole-program". Unfortunately, automake does not support this mode. For further experiments, this patch adds a custom rule which creates the binary named "ncmpc-tiny" this way.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-30 04:45:53 +0000