aboutsummaryrefslogtreecommitdiffstats
path: root/src (follow)
Commit message (Collapse)AuthorAgeFilesLines
* directory: simplify list update handling logicEric Wong2008-10-063-111/+83
| | | | | | | | | | | | | | Now the "update" command can be issued multiple times regardless of whether the client is in list mode or not. We serialize the update tasks to prevent updates from trampling over each other and will spawn another update task once the current one is finished updating and reaped. Right now we cap the queue size to 32 which is probably enough (I bet most people usually run update with no argument anyways); but we can make it grow/shrink dynamically if needed. There'll still be a hard-coded limit to prevent DoS attacks, though.
* main_notify: define main_task so we can use it for assertionsEric Wong2008-10-062-1/+6
| | | | | It'll be easier to keep track of what code runs in what task/thread this way.
* directory: streamline deletesEric Wong2008-10-061-17/+15
| | | | | Instead of relying on the shortname, just pass the song pointer to prevent redundant lookups during deletes.
* pcm_utils: 24 bit supportMax Kellermann2008-09-291-0/+67
| | | | | | | Add support for 24 bit PCM samples to all functions. Note that pcm_convertAudioFormat() converts 24 bit samples to 16 bit; to preserve full quality, support for "real" 24 bit conversion should be added.
* pcm_utils: moved code to special 8/16 bit functionsMax Kellermann2008-09-291-72/+93
| | | | | | | Moved code into separate bit specific functions: - pcm_volumeChange() -> pcm_volume_change_X() - pcm_add() -> pcm_add_X() - pcm_convertTo16bit() -> pcm_convert_8_to_16()
* pcm_utils: pass only one buffer size to pcm_mix()Max Kellermann2008-09-293-22/+28
| | | | | | | | | pcm_mix() might overflow the destination buffer if it is smaller than the second buffer. This is ok because the physical buffer size passed by cross_fade_apply() is always big enough, but clutters pcm_mix() with complicated length checks and contains a dangerous buffer overflow pitfall. Simplify pcm_mix()/pcm_add() and pass only the smaller buffer size; let cross_fade_apply() do the memcpy().
* audio_output: added method pause()Max Kellermann2008-09-299-2/+73
| | | | | | | | | | | | pause() puts the audio output into pause mode: if supported, it may perform a special action, which keeps the device open, but does not play anything. Output plugins like "shout" might want to play silence during pause, so their clients won't be disconnected. Plugins which do not support pausing will simply be closed, and have to be reopened when unpaused. This pach includes an implementation for the shout plugin, which sends silence chunks.
* audio_output: added function audio_output_is_pending()Max Kellermann2008-09-292-0/+11
| | | | | | The function audio_output_is_pending() returns whether there is a pending command. This is useful for output plugins as a break condition for longer loops.
* use C99 struct initializersMax Kellermann2008-09-2920-190/+141
| | | | | | The old struct initializers are error prone and don't allow moving elements around. Since we are going to overhaul some of the APIs soon, it's easier to have all implementations use C99 initializers.
* decoder: renamed plugin methodsMax Kellermann2008-09-295-62/+67
| | | | | Why have a "_func" prefix on all method names? Also don't typedef the methods, there is no advantage in that.
* assume stdint.h and stddef.h are availableMax Kellermann2008-09-2911-82/+4
| | | | | | Since we use a C99 compiler now, we can assert that the C99 standard headers are available, no need for complicated compile time checks. Kill mpd_types.h.
* song: converted "type" to enumMax Kellermann2008-09-292-5/+8
| | | | | | Having an enum type is much nicer than an anonymous integer plus CPP macros. Note that the old code didn't save any space by declaring the variable 8 bit, due to padding.
* removed union const_hackMax Kellermann2008-09-292-7/+4
| | | | | The union const_hack is only used at one place in the shout plugin. Remove its global type declaration.
* switch to C99 types, part IIMax Kellermann2008-09-2917-58/+82
| | | | | Do full C99 integer type conversion in all modules which were not touched by Eric's merged patch.
* Switch to C99 types (retaining compat with old compilers)Eric Wong2008-09-2920-72/+437
| | | | | | | | | | | | | | | Seeing the "mpd_" prefix _everywhere_ is mind-numbing as the mind needs to retrain itself to skip over the first 4 tokens of a type to get to its meaning. So avoid having extra characters on my terminal to make it easier to follow code at 2:30 am in the morning. Please report any new issues you may come across on Free toolchains. I realize how difficult it can be to build/maintain cross-compiling toolchains and I have no intention of forcing people to upgrade their toolchains to build mpd. Tested with gcc 2.95.4 and and gcc 4.3.1 on x86-32.
* allow searching for albums with an empty tagEric Wong2008-09-292-1/+25
| | | | | | | | | | | | | | | | | | | | tfing wrote: > I have quite some files with an empty album tag as they do not come > from a particular album. > > If I want to look for those files and browse them, this happens: > :: nc localhost 6600 > OK MPD 0.12.0 > find album "" > ACK [2@0] {find} too few arguments for "find" > > I'd like to be able to browse those files in a client like gmpc. > So these 2 items would have to be developed: > - list album should report that some files have an empty tag > - it should be possible to search for an empty tag with the find command Patch-by: Marc Pavot ref: http://musicpd.org/mantis/view.php?id=464
* command: don't clobber next list value when preparsingEric Wong2008-09-291-3/+6
| | | | | | | This only breaks "update" under list command mode and no other commands. This can be done more optimally without the extra heap allocation via xstrdup(); but is uncommon enough to not matter.
* directory: isRootDirectory() is a one-linerEric Wong2008-09-291-4/+1
| | | | Improving the signal to noise ratio...
* directory: writeDirectoryInfo propagates errorsEric Wong2008-09-291-21/+19
| | | | | If a write failed, it's a good sign subsequent writes will fail, too, so propgate errors all the way up the stack.
* directory: make it clear that DIRECTORY_MTIME is deprecatedEric Wong2008-09-291-1/+1
| | | | A long time ago in an mpd far away...
* directory: remove "Mp3" referencesEric Wong2008-09-293-22/+22
| | | | | MPD has supported more audio formats than just MP3 for over five years...
* playlist: deleteASongFromPlaylist takes a const Song *Eric Wong2008-09-292-2/+2
| | | | We don't change the song pointer there, either.
* songvec: songvec_delete takes a const Song pointerEric Wong2008-09-292-2/+2
| | | | We don't modify the Song when we delete it
* directory: remove shortname arguments everywhereEric Wong2008-09-291-80/+41
| | | | | | It was a huge confusing mess of parameter passing around and around. Add a few extra assertions to ensure we're handling parent/child relationships properly.
* path: add mpd_basename() functionEric Wong2008-09-292-0/+20
| | | | | | | This is like basename(3) but with predictable semantics independent of C library or build options used. This is also much more strict and does not account for trailing slashes (mpd should never deal with trailing slashes on internal functions).
* directory.h: remove directory_sigChldHandler declEric Wong2008-09-291-2/+0
| | | | | We no longer fork for directory updates, so we no longer have children to reap.
* directory: replace DirectoryList with dirvecEric Wong2008-09-294-197/+175
| | | | | Small memory reduction compared to songvec since most users have much fewer dirs than songs, but still nice to have.
* directory: remove unused CPP definesEric Wong2008-09-291-4/+0
| | | | We no longer for for updates
* songvec_free => songvec_destroyEric Wong2008-09-293-3/+3
| | | | | "free" implies the songvec structure itself is freed, which is not the case.
* directory.c: kill unnecessary includesEric Wong2008-09-291-4/+1
|
* directory: update playlist version if updatedEric Wong2008-09-291-1/+6
| | | | | | | | | | | | If we updated the mpd metadata database; then there's a chance some of those songs in the playlist will have updated metadata. So be on the safe side and increment the playlist version number if _any_ song changed (this is how all released versions of mpd did it, too). This bug was introduced recently when making "update" threaded. Thanks to stonecrest for the bug report.
* pcm_utils: added pcm_range()Max Kellermann2008-09-281-10/+18
| | | | | | | Make the code more readable by moving the range checks to pcm_range(). gcc does quite a good job at optimizing it: the resulting binary is exactly the same, although it contains a parametrized shift instead of hard-coded boundaries.
* pcm_utils: added inline function pcm_dither()Max Kellermann2008-09-281-8/+10
| | | | | Merge some code into an inline function, so we can optimize it later only once.
* output: fix the "outputenabled" valueMax Kellermann2008-09-281-1/+1
| | | | | Patch 9a5b5998 broke the "outputenabled" value of the "outputs" response. Make it print "1" if the output is enabled, "0" otherwise.
* notify: protect notify->pending with the mutexMax Kellermann2008-09-266-41/+4
| | | | | | | | | | There was a known deadlocking bug in the notify library: when the other thread set notify->pending after the according check in notify_wait(), the latter thread was deadlocked. Resolve this by synchronizing all accesses to notify->pending with the notify object's mutex. Since notify_signal_sync() was never used, we can remove it. As a consequence, we don't need notify_enter() and notify_leave() anymore; eliminate them, too.
* song: removed type SongListMax Kellermann2008-09-264-46/+2
| | | | SongList has been superseded by struct songvec.
* audio_output: workaround for deadlockMax Kellermann2008-09-263-2/+19
| | | | | | | | During debugging, I found a deadlock between flushAudioBuffer() and the audio_output_task(): audio_output_task() didn't notice that there is a command, and flushAudioBuffer() waited forever in notify_wait(). I am not sure yet what is the real cause; work around this for now by waking up non-finished audio outputs in every iteration.
* update: send proper response to the clientMax Kellermann2008-09-251-5/+8
| | | | | | Due to a merge error, I broke the function handleUpdate(). It did not do anything for the global update, and it did not send a proper response to the client. This patch fixes both bugs.
* output: removed DEVICE_ON, DEVICE_OFFMax Kellermann2008-09-242-29/+20
| | | | | | | To check whether a device is really on or off, we should rather check audio_output.open, instead of managing another variable. Wrap audio_output.open in the inline function audio_output_is_open() and use it instead of DEVICE_ON and DEVICE_OFF.
* output: semi-asynchronous playbackMax Kellermann2008-09-244-23/+91
| | | | | | | Send an output buffer to all output plugins at the same time, instead of waiting for each of them separately. Make several functions non-blocking, and introduce the new function audio_output_wait_all() to synchronize with all audio output threads.
* output: call send_tag() only if device is onMax Kellermann2008-09-241-3/+3
| | | | Why send tags to a device which isn't enabled?
* output: document the audio_output_plugin methodsMax Kellermann2008-09-241-0/+44
|
* output: document the audio_output elementsMax Kellermann2008-09-241-4/+58
|
* output: make "struct audio_output" opaque for output pluginsMax Kellermann2008-09-2416-226/+267
| | | | | | | | | | | We have eliminated direct accesses to the audio_output struct from the all output plugins. Make it opaque for them, and move its real declaration to output_internal.h, similar to decoder_internal.h. Pass the opaque structure to plugin.init() only, which will return the plugin's data pointer on success, and NULL on failure. This data pointer will be passed to all other methods instead of the audio_output struct.
* output: added audio_output_closed()Max Kellermann2008-09-243-1/+11
| | | | | | The JACK output plugin needs to reset its "opened" flag when the JACK server fails. To prevent it from accessing the audio_output struct directly introduce the API function audio_output_closed().
* output: added audio_output_get_name()Max Kellermann2008-09-244-1/+28
| | | | | | Reduce direct accesses to the audio_output struct from the plugins: this time, eliminate all accesses to audio_output.name. The name is required by some plugins for log messages.
* output: set audio_output->open=1 in audio_output_task()Max Kellermann2008-09-2411-39/+8
| | | | | Since the output plugin returns a value indicating success or error, we can have the output core code assign the "open" flag.
* output: pass audio_format to plugin.init() and plugin.open()Max Kellermann2008-09-2413-34/+61
| | | | | | | Pass the globally configured audio_format as a const pointer to plugin.init(). plugin.open() gets a writable pointer which contains the audio_format requested by the plugin. Its initial value is either the configured audio_format or the input file's audio_format.
* output: one thread per audio outputMax Kellermann2008-09-246-38/+218
| | | | | | To keep I/O nastiness and latencies away from the core, move the audio output code to a separate thread, one per output. The thread is created on demand, and currently runs until mpd exits.
* notify: added macro NOTIFY_INITIALIZERMax Kellermann2008-09-241-0/+5
| | | | | With the macro NOTIFY_INITIALIZER, you can statically initialize a notify object.