aboutsummaryrefslogtreecommitdiffstats
path: root/src (follow)
Commit message (Collapse)AuthorAgeFilesLines
* input/curl: remove assertion after curl_multi_fdset()Max Kellermann2010-07-201-2/+0
| | | | | | | | | | | | | | | | | Some users reported that MPD crashes when using a new CURL version with the threaded DNS resolver enabled. It seems that curl_multi_fdset() returns no file descriptor when the DNS resolver runs in another thread, so MPD does not have any event to wait for. On the CURL mailing list, somebody suggested to sleep for a fixed amount of time. This is not an elegant solution, because daemons should never have to sleep without waiting for an event. I hope the CURL developers will review the API and remove the threaded DNS resolver. Meanwhile, I'm removing the assertion in question, to allow those unfortunate users running the latest CURL version to continue using MPD.
* input/curl: query timeout from CURLMax Kellermann2010-07-201-1/+18
| | | | | Use curl_multi_timeout() to determine the select() timeout, instead of hard-coding one second.
* tag_rva2: set "gain", not "peak"Max Kellermann2010-07-201-2/+2
| | | | RVA2 tags only store the "gain" value, there is no "peak" attribute.
* decoder/mad: parse_rva2() returns boolMax Kellermann2010-07-201-9/+8
|
* decoder/wildmidi: support version 0.2.3Max Kellermann2010-07-201-0/+4
| | | | | | | In libwildmidi 0.2.3, the function WildMidi_SampledSeek() was removed, without changing the SO name. This patch adds an autoconf check for that function. Fall back to WildMidi_FastSeek() if WildMidi_SampledSeek() is not available anymore.
* decoder/ffmpeg: fix libavformat 0.6 by using av_open_input_stream()Max Kellermann2010-06-301-82/+52
| | | | | | | | | | | | libavformat 0.6 does not pass the original URI pointer to the "open" method, which leads to a crash because MPD was using a dirty hack to pass a pointer to that method. This patch switches to av_open_input_stream() with a custom ByteIOContext class, instead of doing the URI string hack with av_open_input_file(). Loosely based on a patch from Jasper St. Pierre.
* decoder/ffmpeg: manual format probingMax Kellermann2010-06-301-4/+47
| | | | | | | | | Use the libavformat function av_probe_input_format() to probe the AVInputFormat, instead of letting av_open_input_file() do it implicitly. We will switch to av_open_input_stream() very soon, which does not have the probing code. Loosely based on a patch from Jasper St. Pierre.
* decoder/ffmpeg: free URI, fix memory leakMax Kellermann2010-06-301-1/+3
| | | | Free the string allocated by decoder_get_uri().
* decoder/vorbis: handle uri==NULLMax Kellermann2010-06-301-0/+3
| | | | This fixes a theoretical crash, which has never occurred in practice.
* ffmpeg: read more metadata.Anton Khirnov2010-06-301-1/+10
|
* decoder/ffmpeg: free AVFormatContext on errorMax Kellermann2010-06-301-0/+4
| | | | Fix a memory leak in some code paths.
* pcm_buffer: make the buffer pointer "void"Max Kellermann2010-06-301-1/+1
|
* decoder/mp4ff: support tag "album artist"Max Kellermann2010-06-301-0/+1
| | | | | We already supported "albumartist", but it seems some folks also use "album artist" (with a space).
* Make get_remote_uid() work on BSDAndreas Vögele2010-06-301-1/+7
| | | | | | I've attached a patch that will make file URIs work on operating systems that provide the getpeereid() function call to check the user ID of the peer connected to a UNIX domain socket.
* playlist: emit IDLE_OPTIONS when resetting single modeMax Kellermann2010-06-301-0/+3
|
* directory_print: return voidMax Kellermann2010-06-302-7/+3
| | | | There is no useful return value here.
* decoder/mikmod: fix memory leakMax Kellermann2010-06-301-2/+4
| | | | | The return value of Player_LoadTitle() is allocated with malloc(), and must be freed by the caller.
* decoder/mp4ff: remove duplicate entries in the tag name tableMax Kellermann2010-06-301-9/+5
| | | | Reuse the function tag_name_parse_i().
* decoder/mp4ff: moved code to mp4ff_tag_name_parse()Max Kellermann2010-06-301-1/+7
|
* tag_ape: remove duplicate entries in the tag name tableMax Kellermann2010-06-301-7/+5
| | | | Reuse the function tag_name_parse_i().
* tag: added function tag_name_parse()Max Kellermann2010-06-303-12/+60
| | | | Convert a string into a tag_type enum.
* tag_ape: move code to tag_ape_name_parse()Max Kellermann2010-06-301-1/+7
|
* decoder/vorbis: use single global ov_callbacks constantMax Kellermann2010-06-301-7/+9
| | | | Initialize the ov_callbacks struct at compile time.
* decoder/mp4ff: support tags "albumartist", "band"Max Kellermann2010-06-301-0/+2
| | | | | I'm not sure if mapping "band" to TAG_PERFORMER is correct, but it might be better than nothing.
* decoder/mp4ff: use tag_table.h to parse tag namesMax Kellermann2010-06-301-18/+15
| | | | Convert if/else/else/... to a loop.
* tag_ape: move table lookup to tag_table.hMax Kellermann2010-06-302-9/+52
| | | | Allow code sharing.
* tag_ape: support album artistMax Kellermann2010-06-301-0/+1
| | | | | | | | | | I took this tag name from a MusePack sample file I got from a user. It is not documented in the APE specification: http://wiki.hydrogenaudio.org/index.php?title=APE_key People seem to be using undocumented extensions to the specification anyway, and the best we can do is attempt to support them.
* tag_ape: simplified the apeItems arrayMax Kellermann2010-06-301-22/+12
| | | | | Make "enum tag_type" the array index, and convert apeItems to a sparse array.
* tag_ape: moved code to tag_ape_import_item()Max Kellermann2010-06-301-12/+22
| | | | Improve code readability.
* tag_ape: converted apeItems and tagItems to global varsMax Kellermann2010-06-301-20/+20
| | | | Don't initialize those arrays each time tag_ape_load() is called.
* decoder/mad: fix buffer variable name on !HAVE_ID3TAGMax Kellermann2010-05-301-3/+3
|
* input/mms: initialize the "eof" attributeMax Kellermann2010-05-181-0/+2
|
* input/mms: fix memory leak in error handlerMax Kellermann2010-05-181-0/+1
|
* decoder/mad: properly calculate ID3 size without libid3tagMax Kellermann2010-04-131-5/+25
| | | | | | | | | | Without libid3tag, we were trying to skip the ID3 frame (since 0.15.2). Its length however was not calculated at all, we were just dropping everything from the current input buffer. This lead to the first few seconds of the file being skipped. This patch attempts to calculate the ID3v2 frame size with the formula from: http://www.id3.org/id3v2.4.0-structure 3.1 and 6.2
* decoder/mpcdec: fix replay gain formula with v8Aleksei Kaveshnikov2010-03-191-0/+8
| | | | | | | | | | "When playing musepack files with mpd v0.15.8, rg seems to have no effect. Using sample file below, mpd says 'computing ReplayGain album scale with gain 122.879997, peak 0.549150'. One thing though, if I build mpd against old libmpcdec-1.2.6, rg works as expected: 'computing ReplayGain album scale with gain 16.820000, peak 0.099765'"
* player_thread: postpone song tags during cross-fadeMax Kellermann2010-03-171-0/+27
| | | | | | | | | Previously, tags of the new song being cross-faded in were sent immediately. That can cause wrong information being displayed, because the "previous" song might send its tag at the end again, overriding the "next" song's tag. This patch saves & merges the tag of the next song, and sends it when cross-fading is finished, and the next song really starts.
* tag: added function tag_merge_replace()Max Kellermann2010-03-173-21/+26
| | | | | Like tag_merge(), but can deal with NULL parameters, and frees both tag objects.
* decoder/mpcdec: fix negative shift on fixed-point samplesPiotr Gozdur2010-03-171-1/+1
| | | | | | "There is a bug in fixed-point musepack (musepack_src_r435) playback. In floating-point audio is OK but in fixed audio is distorted. I have made a patch for this"
* playlist: fix single+repeat in random modeMax Kellermann2010-03-071-1/+2
| | | | | | | With single+repeat enabled, it is expected that MPD repeats the current song over andd over. With random mode also enabled, this didn't work, because the song order was shuffled internally. This patch adds a special check for this case.
* decoder/mad: fix crash when seeking at end of songMax Kellermann2010-02-271-4/+0
| | | | | | Removed the decoder_command_finished() call at the end of mp3_decode(). This is invalid, because decoder_command_finished() has already been called in mp3_read().
* decoder/ffmpeg: added more MIME typesMax Kellermann2010-01-171-0/+6
| | | | Taken from the ffmpeg sources.
* decoder/ffmpeg: append file name suffix to virtual stream URLMax Kellermann2010-01-171-4/+28
| | | | | | | To allow libavformat to detect the format of the input file, append the suffix of the input file to the URL of the virtual stream. This specifically enables the "shorten" codec, which is supported by libavformat/raw.c, detected only by the suffix.
* queue: don't repeat current song in consume modeMax Kellermann2010-01-161-2/+2
| | | | | Check consume mode in queue_next_order(), because the current song would be deleted as soon as it's finished; it cannot be played again.
* decoder_thread: fix CUE track playbackMax Kellermann2010-01-161-5/+10
| | | | | | | | | | | | The patch "input/file: don't fall back to parent directory" introduced a regression: when trying to play a CUE track, decoder_run_song() tries to open the file as a stream first, but this fails, because the path is virtual. This patch fixes decoder_run_song() (instead of reverting the previous patch) to accept input_stream_open() failures if the song is a local file. It passes the responsibility to handle non-existing files to the decoder's file_decode() method.
* dbUtils: return empty tag value only if no value was foundMax Kellermann2010-01-021-1/+4
| | | | | | | | This fixes a regression in the patch "return multiple tag values per song": even when the song has values for the specified tag type, the empty string gets added to the set, because the "return" was removed. This patch adds a flag which remembers whether at least one value was found.
* input/curl: removed the built-in rewinding codeMax Kellermann2009-12-301-181/+10
| | | | This has been reimplemented in the "rewind" input plugin.
* input/rewind: new input_stream wrapper to allow stream rewindingMax Kellermann2009-12-295-0/+312
| | | | | | | | | | | | This replaces the rewinding buffer code from the CURL input plugin. It is more generic, and allows rewinding even when the server sends Icy-Metadata (which would have been too difficult to implement within the CURL plugin). This is a rather complex patch for the stable branch (v0.15.x), but it fixes a serious problem: the "vorbis" decoder plugin was unable to play streams with Icy-Metadata, because it couldn't rewind the stream after detecting the codec (Vorbis vs. FLAC).
* decoder/{ffmpeg,flac,vorbis}: added more flac/vorbis MIME typesMax Kellermann2009-12-294-4/+22
| | | | | Support deprecated MIME types such as "audio/x-ogg". Support new types such as "audio/flac".
* dbUtils: return multiple tag values per songMax Kellermann2009-12-271-1/+0
| | | | | | When collecting tag values for the result set, add all of a song's tag values of the searched type. This affects the "list" command. Previously, "list" only considered the first tag value of a song.
* decoder_thread: eliminate jitter after seek failureMax Kellermann2009-12-261-1/+5
| | | | | | Don't clear the music pipe when seeking has failed - check the "seeking" flag instead of "command==SEEK". Clear the "seeking" flag in decoder_seek_error().