aboutsummaryrefslogtreecommitdiffstats
path: root/src (follow)
Commit message (Collapse)AuthorAgeFilesLines
* alsa: initialize "device" with NULLMax Kellermann2008-11-031-2/+1
| | | | | When using autodetection, AlsaData.device wasn't properly initialized with NULL. This broke autodetection randomly.
* mod: removed boolean globals for lazy initMax Kellermann2008-11-031-15/+4
| | | | | The variables mod_mikModInitiated and mod_mikModInitError were used to control lazy initialization, but they are superfluous now.
* mod: always initialize libmikmodMax Kellermann2008-11-031-8/+1
| | | | | | | The "mod" decoder plugin was being initialized lazily, but was deinitialized unconditionally. That led to segmentation faults. Convert mod_initMikMod() to be the global module initialization method. The MPD core should care about lazy initialization.
* output: don't allow length==0Max Kellermann2008-11-023-0/+5
| | | | | Nobody should call playAudio() with an empty chunk. Add some assertions on that.
* player: don't play empty chunksMax Kellermann2008-11-021-0/+3
| | | | | An empty chunk may happen when it only contains a tag, but no PCM data. Don't call playAudio() then.
* ffmpeg: fix boolean inversion in ffmpeg_tag()Max Kellermann2008-11-021-1/+1
| | | | | | ffmpeg_tag() deleted the tag when ffmpeg_helper() returned success. The return value was interpreted incorrectly, it should return the tag on success.
* removed unused sourcesMax Kellermann2008-11-026-691/+0
| | | | | Cleaning up artifacts from a merge gone wrong. Also remove the ringbuf library, which is not being used.
* player: copy stream tag to the song structMax Kellermann2008-11-021-5/+19
| | | | | | Non-local songs used to have no tags. If the decoder sends us a tag, we should incorporate it into the song struct. This way, clients can always show the correct song name (if provided by the server).
* player: added player.songMax Kellermann2008-11-021-0/+7
| | | | | Always remember which song is currently being sent to the audio device.
* ffmpeg: don't rewind stream in url_close()Max Kellermann2008-11-021-4/+0
| | | | | Rewinding the stream here is not useful, but may consume valuable resources (and time).
* decoder: rewind input stream after try_decode()Max Kellermann2008-11-023-9/+8
| | | | | | | | | The try_decode() method may have read some data from the stream, which is now lost. To make this data available to other methods, get it back by rewinding the input stream after each try_decode() invocation. The ogg and wavpack plugins did this manually and inconsistently; this code can now be removed.
* decoder: moved code to decoder_try_decode()Max Kellermann2008-11-021-6/+13
|
* player: send chunk tag to audio deviceMax Kellermann2008-11-021-0/+3
| | | | | If a chunk contains a tag, send it to the audio output device. Few output plugins support this, e.g. shout has support for sending tags.
* crossfade: copy tagMax Kellermann2008-11-021-0/+5
| | | | | | If the source chunk has a tag, merge it into the destination chunk. The source chunk gets deleted after that, and this is our last chance to grab the tag.
* ffmpeg: use decoder_read() wrapper instead of direct input_stream_read()Max Kellermann2008-11-021-1/+2
| | | | | decoder_read() checks the decoder command. Without this patch, the ffmpeg plugin could become unresponsive.
* ogg, ffmpeg: try to decode, even when the stream is not seekableMax Kellermann2008-11-023-11/+1
| | | | | | | Ogg and ffmpeg detection was disabled when the stream was not seekable, because the detection was too expensive. Since the curl input stream can now rewind the stream cheaply, we can re-enable detection on streams.
* input_curl: buffered rewindingMax Kellermann2008-11-021-3/+115
| | | | | | | | During codec detection, the beginning of the stream is consumed. This is a common operation, which takes a lot of time when handling remote resources. To optimize this, remember the first 64 kB of a stream. This way, we can rewind the stream without actually fetching the start of the stream again.
* decoder_api: added decoder_tag()Max Kellermann2008-11-023-2/+30
| | | | Provide an API for submitting additional tags from the stream.
* aac, mod: moved decoder command check into loop conditionMax Kellermann2008-11-022-18/+9
| | | | | Avoid while(true) loops, and convert them to a loop with a proper condition.
* aac, mod: don't check for SEEK commandMax Kellermann2008-11-022-18/+2
| | | | | | Since the aac and mod plugins have told MPD that they cannot seek, MPD will never send a SEEK command to them. Removed the SEEK comand checks from both plugins.
* decoder_api: pass "seekable" flag to decoder_initialized()Max Kellermann2008-11-0215-44/+37
| | | | | | Don't pass the "seekable" flag with every decoder_data() invocation. Since that flag won't change within the file, it is enough to pass it to decoder_initialized() once per file.
* music_pipe: add tag pointer to the music_chunk structMax Kellermann2008-11-022-1/+41
| | | | | | Each music chunk can now carry a tag object. Decoder plugins which support it (e.g. oggvorbis) may use this to inject decoded tags into their output.
* music_pipe: added functions chunk_init() and chunk_free()Max Kellermann2008-11-021-10/+38
| | | | | These two functions will care about memory allocation and deallocation in the future.
* music_pipe: document struct music_chunkMax Kellermann2008-11-021-0/+11
| | | | Add doxygen compatible comments.
* music_pipe: removed "volatile"Max Kellermann2008-11-021-2/+2
| | | | | The "volatile" keyword doesn't help here, because we have proper memory barriers, but it disables some optimizations. Remove it.
* music_pipe: renamed "size" to "num_chunks"Max Kellermann2008-11-022-13/+12
| | | | The name "num_chunks" expresses the meaning of the variable better.
* music_pipe: no CamelCaseMax Kellermann2008-11-024-29/+29
| | | | Rename all variables and struct members.
* music_pipe: set bit_rate and time in music_pipe_append()Max Kellermann2008-11-021-10/+10
| | | | Don't bother to pass these values as parameters to tail_chunk().
* music_pipe: moved code to music_chunk_append()Max Kellermann2008-11-021-13/+28
|
* music_pipe: renamed "ob" to "music_pipe"Max Kellermann2008-11-022-49/+49
| | | | Last music_pipe rename patch: renamed the global variable (singleton).
* music_pipe: more wrapper functionsMax Kellermann2008-11-022-8/+33
| | | | | | Replace all direct music_pipe struct accesses with wrapper functions. The compiled machine code is the same, but this way, we can change struct internals more easily.
* music_pipe: use GLib instead of utils.hMax Kellermann2008-11-021-3/+3
| | | | Eliminate the deprecated utils.h memory allocation functions.
* decoder: replaced music_pipe.audioFormat with dc.out_audio_formatMax Kellermann2008-11-026-22/+34
| | | | | | | .. and rename dc.audioFormat to dc.in_audio_format. The music pipe does not need to know the audio format, and its former "audioFormat" property indicated the format of the most recently added chunk, which might be confusing when you are reading the oldest chunks.
* music_pipe: pass frame size to tail_chunk()Max Kellermann2008-11-021-3/+2
| | | | Don't make tail_chunk() calculate the frame size again.
* music_pipe: renamed ob_* functions to music_pipe_*Max Kellermann2008-11-026-55/+56
| | | | Rename all functions to the new prefix.
* music_pipe: renamed struct output_buffer to struct music_pipeMax Kellermann2008-11-025-19/+24
| | | | .. and rename ob_chunk to struct music_chunk.
* renamed outputBuffer.[ch] to pipe.[ch]Max Kellermann2008-11-028-10/+10
| | | | | | | No CamelCase in the file name. The output_buffer struct is going to be renamed to music_pipe. There are so many buffer levels in MPD, and calling this one "output buffer" is wrong, because it's not the last buffer before the music reaches the output devices.
* decoder: enable decoders even if they have no init() methodMax Kellermann2008-11-021-1/+1
| | | | | | Commit 1a4a3e1f moved decoders into a static array, but failed to enable those plugins who did not have an init() method at all. This patch corrects the "enabled" check.
* decoder: make the suffixes and mime_types arrays really constMax Kellermann2008-11-0111-32/+41
| | | | | The strings were constant, but the pointers weren't. C syntax is somewhat tricky..
* decoder: make all decoder_plugin structs constMax Kellermann2008-11-0112-23/+23
| | | | | All decoder_plugin structs are initialized at compile time, and must never change.
* decoder: manage decoder list in a static arrayMax Kellermann2008-11-014-109/+78
| | | | | Currently, there is no way to dynamically load decoder plugins, thus we don't need a dynamic list to manage them.
* decoder: return const decoder_plugin structsMax Kellermann2008-11-017-20/+24
| | | | | The decoder_plugin structs must never change. Don't work with non-const pointers.
* permission: store passwords in GHashTableMax Kellermann2008-11-011-17/+20
| | | | Eliminating the deprecated linked list library.
* tag: use GLib instead of utils.hMax Kellermann2008-11-011-8/+10
| | | | Don't use the deprecated functions from utils.h.
* utils: use GUINT32_FROM_LE() instead of readLEuint32()Max Kellermann2008-11-013-17/+8
| | | | Eliminate code already provided by GLib.
* tag: don't return const string from fix_utf8()Max Kellermann2008-11-011-13/+13
| | | | | Return NULL instead of the input value if there is nothing to fix. This way, the caller doesn't have to use the xfree() hack.
* alsa, jack: no const pointers for allocated stringsMax Kellermann2008-11-012-26/+42
| | | | | Make the pointers "device" and "name" non-const, so we don't need the xfree() hack. The default value is expressed as NULL.
* path: removed sanitizePathDup()Max Kellermann2008-10-313-47/+2
| | | | | We don't need to sanitize the path, because the mapper already checks for malformed paths.
* mapper: check for "." and ".."Max Kellermann2008-10-311-0/+5
| | | | | | Make map_directory_child_fs() refuse the names "." and "..". This is currently the interface where an attacker may inject a manipulated path (through the "update" command).
* update: check return valuesMax Kellermann2008-10-314-16/+28
| | | | | Nearly all mapper functions can fail and will then return NULL. Add checks to all callers.
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-04 11:37:34 +0000