aboutsummaryrefslogtreecommitdiffstats
path: root/src (follow)
Commit message (Collapse)AuthorAgeFilesLines
* output_all: include chunk.hMax Kellermann2009-03-141-0/+1
| | | | | The source output_all.c accesses music_chunk struct members, but did not include chunk.h directly.
* pcm_volume: use #ifdef instead of #if __i386__Max Kellermann2009-03-141-2/+2
|
* tag_pool: make "slots" staticMax Kellermann2009-03-141-1/+1
| | | | The variable is private.
* pcm_resample: return NULL on failureMax Kellermann2009-03-141-4/+4
| | | | Changed "0" to "NULL".
* pcm_convert: return NULL on failureMax Kellermann2009-03-141-1/+1
| | | | Changed "0" to "NULL".
* command: return COMMAND_RETURN_OK in handle_addid()Max Kellermann2009-03-141-1/+1
| | | | | | At the last line of handle_addid(), the playlist_result value has already been evaluated. Don't return this variable, it's the wrong type.
* command: handle the addToPlaylist() result properlyMax Kellermann2009-03-141-1/+2
| | | | | addToPlaylist() has a "enum playlist_result" return value. Convert that to "enum command_return" properly.
* faad: faad_decoder_decode() returns NULL, not falseMax Kellermann2009-03-141-1/+1
| | | | On failure, the function should return NULL, not a boolean.
* sticker: sticker_load_value() returns NULL on error, not falseMax Kellermann2009-03-141-4/+4
| | | | Turn the "return false" error handlers into "return NULL".
* sticker: initialize hash table in sticker_new()Max Kellermann2009-03-141-18/+26
| | | | | | Moved the hash table initialization from sticker_list_values() to the new function sticker_new(). This fixes a memory leak in sticker_list_values().
* sticker: don't export sticker_list_values()Max Kellermann2009-03-144-32/+1
| | | | | | sticker_list_values() is only used internally in sticker.c. Remove sticker_song_list_values() completely, it is superseded by sticker_song_get().
* command: use sticker_song_get() instead of sticker_song_list_values()Max Kellermann2009-03-141-11/+10
|
* sticker: added "struct sticker"Max Kellermann2009-03-144-0/+131
| | | | | The sticker struct can be used for enumerating values. This will replace the sticker_list_values() function.
* mixer_all: removed debug messageMax Kellermann2009-03-141-1/+0
| | | | Don't dump the volume of all mixers.
* mixer: protect the mixer struct with a mutexMax Kellermann2009-03-143-5/+37
| | | | | | | In some rare cases, there was a race condition between the output thread and the main thread: when you disable/enable an output device in the main thread, this caused a crash in the output thread. Protect the whole mixer struct with a GMutex to prevent that.
* mixer_api: moved mixer_init() to mixer_api.cMax Kellermann2009-03-142-9/+9
|
* mixer_api: moved mixer_plugin imports to mixer_list.hMax Kellermann2009-03-145-11/+36
| | | | | | This patch allows the output plugins to import only mixer_list.h, instead of the full mixer_api.h (which would expose internal structures).
* mixer_api: moved functions to mixer_control.cMax Kellermann2009-03-1411-82/+112
| | | | | | mixer_control.h should provide the functions needed to manipulate a mixer, without exposing the internal mixer API (which is provided by mixer_api.h).
* mixer_control: moved functions to mixer_all.cMax Kellermann2009-03-143-71/+61
|
* volume: moved code to mixer_all.cMax Kellermann2009-03-143-30/+111
|
* mixer_api: moved struct mixer_plugin to mixer_plugin.hMax Kellermann2009-03-142-41/+74
|
* volume: use bool instead of intMax Kellermann2009-03-143-15/+22
| | | | | Return true/false on success/failure, instead of 0/-1. Pass true/false instead of 1/0 for the "rel" boolean parameter.
* Removed superfluous if statement in update.c:453Jochen Keil2009-03-141-28/+22
| | | | Check for NULL not necessary here
* all: Update copyright header.Avuton Olrich2009-03-13265-1358/+1677
| | | | | | | | This updates the copyright header to all be the same, which is pretty much an update of where to mail request for a copy of the GPL and the years of the MPD project. This also puts all committers under 'The Music Player Project' umbrella. These entries should go individually in the AUTHORS file, for consistancy.
* crossfade: added missing '&'Jeffrey Middleton2009-03-121-1/+1
|
* crossfade: copy chunk.audio_format in !NDEBUGMax Kellermann2009-03-121-0/+10
| | | | | | | | When the destination chunk was empty in cross_fade_apply(), it had no audio_format attached (an attribute which is only used for assertion in the debug build). cross_fade_apply() should assign it the audio_format of the second chunk (if available), otherwise MPD will crash.
* output_all: fix off-by-one error in audio_output_all_check()Max Kellermann2009-03-121-1/+1
| | | | | | | | When there are chunks which are not yet finished, audio_output_all_check() returned the size of its music pipe minus one. I can't remember exactly why I subtracted 1 from the return value, it must have had something to do with a former meaning of this function. Now it induces assertion failures.
* mixer_control: don't touch mixers of disabled outputsMax Kellermann2009-03-122-0/+15
| | | | When an audio output device is disabled, also disable its mixer.
* audio: converted device number check to assertionMax Kellermann2009-03-121-4/+4
| | | | | No caller must ever pass an invalid device number to mixer_control_setvol() or mixer_control_getvol().
* audio: moved mixer functions to mixer_control.cMax Kellermann2009-03-125-56/+108
|
* volume: removed unused variable "default_mixer"Max Kellermann2009-03-121-1/+0
|
* Move from the opaque GPtrArray to GHashTable for sticker lists.Eric Wollesen2009-03-115-45/+34
|
* player_thread: added commentsMax Kellermann2009-03-112-24/+89
|
* player_thread: removed player_stop_decoder()Max Kellermann2009-03-111-14/+6
| | | | | Replaced both player_stop_decoder() invocations with player_dc_stop(), which also cleans up the pipe.
* player_thread: don't call dc_stop() twiceMax Kellermann2009-03-111-3/+1
| | | | | In the "CANCEL" command handler, the decoder is stopped twice: first by player_dc_stop(), then by dc_stop(). Remove the latter.
* output_control: removed audio_output_signal()Max Kellermann2009-03-102-14/+0
| | | | This function was part of a workaround which we don't need anymore.
* Cleaned up update_regular_file() method in update.cJochen Keil2009-03-101-83/+88
| | | | | | | After adding the container_scan() method the update_regular_file() method was quite hard to read. Now there's update_container_file() which deals with container files. That way normal container files (i.e. without embedded tracks) are handled by the old code like a regular file. This will fix some of the odd behaviour observed.
* alsa: use snd_pcm_sframes_t instead of intMax Kellermann2009-03-101-2/+1
| | | | | snd_pcm_writei() returns the type snd_pcm_sframes_t, not int. Use the correct variable type.
* alsa: don't close PCM handle in alsa_recover()Max Kellermann2009-03-101-13/+3
| | | | | | If the PCM handle gets disconnected, don't close and clear it in alsa_recover(). The MPD core will call alsa_close() anyway. This way, we can always assume that alsa_data.pcm is always valid.
* player_thread: fill buffer after seekingMax Kellermann2009-03-101-3/+9
| | | | | | After a seek, wait until enough new chunks are decoded before starting playback. If this takes too long, send silence chunks to the audio outputs meanwhile.
* output_all: clear input_audio_format on closeMax Kellermann2009-03-101-0/+2
| | | | | | When the audio outputs are closed, also clear the audio format. If we don't do this, every call to audio_output_all_update() will open the device, even if it's meant to be paused.
* output_all: don't allow audio_format==NULL in audio_output_all_open()Max Kellermann2009-03-101-5/+3
| | | | | | Don't allow reopening an audio device after pause with audio_format==NULL, force the caller to provide the audio_format each time.
* player_thread: pass format to audio_output_all_open() after resumeMax Kellermann2009-03-101-8/+12
| | | | | | | When playback is unpaused, pass the audio_format to audio_output_all_open(). Don't assume that output_all.c remembers the previous audio format. Also check if there has been an audio format yet.
* player_thread: moved code to player_send_silence()Max Kellermann2009-03-101-22/+39
|
* output_thread: check commands while playingMax Kellermann2009-03-101-1/+1
| | | | | | | Check audio_output.command after each sub-chunk has been played. It discards the rest of the chunk, but since all commands make the device stop anyway, this is not a problem, but part of the improvement. This improves the latency of audio output commands.
* player_thread: finish failed seek commandMax Kellermann2009-03-101-1/+5
| | | | | | When seeking into a new song, and the decoder for the new song fails to start up, MPD forgot to send the "command_finished" signal to the main thread.
* player_thread: clear player.queued after failureMax Kellermann2009-03-101-0/+1
| | | | | | When pc.next_song is reset due to a decoder failure, also reset the player.queued flag. player.queued must not be true when there is no pc.next_song.
* player_thread: moved code to player_seek_decoder()Max Kellermann2009-03-101-12/+15
| | | | | | Reset player.xfade and player.buffering from within player_seek_decoder(), not in the player_process_command() switch statement.
* music_chunk: increased chunk size to 4 kBMax Kellermann2009-03-101-2/+1
| | | | | | | | A larger chunk size means less overhead for managing them. 4 kB seems to be a reasonable choice: it contains 23 ms of 44.1 kHz 16 bit stereo data, or 3 ms of 192 kHz 24 bit stereo data. The original value of 1020 seemed to be too small, there were quite a lot of system calls and context switches.
* player_thread: don't free music buffer after decoder failureMax Kellermann2009-03-101-1/+0
| | | | | The music_buffer is a global variable, and must not be freed until the player thread exits.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-30 11:33:35 +0000