aboutsummaryrefslogtreecommitdiffstats
path: root/src (follow)
Commit message (Collapse)AuthorAgeFilesLines
* output/oss: AFMT_S24_PACKED is little-endianMax Kellermann2011-02-281-0/+12
| | | | | | | | | According to the Solaris dsp manpage, AFMT_S24_PACKED is little-endian: http://download.oracle.com/docs/cd/E19963-01/821-1475/6nmf5baot/index.html The Minix soundcard.h header says the same.
* general: whitespace cleanupThomas Jansen2011-02-099-29/+29
| | | | | Remove trailing whitespace found by this command: find -name '*.[ch]' | xargs grep "[[:space:]]$"
* output/httpd: initialize unflushed_inputThomas Jansen2011-02-091-0/+1
| | | | | | | | | | This fixes the following valgrind warning occuring on the first call of httpd_output_read_page: ==20124== Conditional jump or move depends on uninitialised value(s) ==20124== at 0x425E65: httpd_output_read_page (httpd_output_plugin.c:240) ==20124== by 0x426087: httpd_output_open (httpd_output_plugin.c:279) ==20124== by 0x41D862: ao_open (output_plugin.h:206) ==20124== by 0x41E133: audio_output_task (output_thread.c:590)
* Set fadeout in gme_decoder_plugin. Due to the nature of the gme library,Tony Miller2011-02-031-0/+3
| | | | this needs to be done for the end of songs to be detected.
* Merge branch 'v0.15.x' into v0.16.xMax Kellermann2011-01-073-2/+12
|\ | | | | | | | | | | | | Conflicts: NEWS configure.ac src/directory.h
| * encoder/lame: explicitly configure the output sample rateMax Kellermann2011-01-071-0/+7
| | | | | | | | | | | | | | | | | | When you don't explicitly set an output sample rate, liblame tries to guess an output sample rate from the input sample rate. You would think that this "guessing" consists of just setting both equal, but that is not the case. For 44.1kHz at 96kbit/s, liblame chooses 32kHz. This patch explicitly configures the output sample rate, to stop the bad guessing.
| * output/httpd: define G_LOG_DOMAIN in httpd_client.cMax Kellermann2011-01-071-0/+3
| |
| * directory: fix warning "comparison between signed and unsigned"Max Kellermann2010-12-211-2/+2
| | | | | | | | Cast the constant to dev_t, not to unsigned.
| * zeroconf-bonjour: use g_htons() instead of htons()Max Kellermann2010-12-211-1/+1
| | | | | | | | Fixes the gcc warning "implicit declaration of function 'htons'".
* | player_thread: discard empty chunks while cross-fadingMax Kellermann2011-01-071-0/+13
| | | | | | | | | | | | When a music_chunk to be crossfaded consists only of a tag, cross-fading is not possible, and led to an assertion failure. This patch just discards those, as if cross-fading was not enabled.
* | output_thread: fix double lockMax Kellermann2011-01-071-3/+0
| | | | | | | | | | | | | | | | During the whole output thread, the audio_output object is locked, and it is only unlocked while waiting for the GCond and while running a plugin method. The error handler in ao_play_chunk() attempted to lock the object again, which was code from MPD 0.15.x which should have been removed a long time ago.
* | player_thread: fix assertion failure due to early seekMax Kellermann2011-01-071-0/+4
| | | | | | | | | | | | | | Until the decoder plugin has called decoder_initialized(), the player may not submit seek commands. This however could occur with a slow decoder and a CUE file with a virtual song offset. This patch adds another check.
* | player_thread: make variables more localMax Kellermann2011-01-071-36/+19
| |
* | output/osx: fix up audio format first, then apply it to deviceMax Kellermann2011-01-071-9/+10
| | | | | | | | | | | | | | | | | | This is a MPD 0.16 regression: when playing a 24 bit file, the switch to 16 bit was made only partially, after mBytesPerPacket and mBytesPerFrame had already been applied. That means mBytesPerFrame referred to 24 bit, and mBitsPerChannel referred to 16 bits. Of course, that cannot work.
* | add void casts to suppress "result unused" warnings (clang)Max Kellermann2010-12-212-3/+3
| |
* | decoder/mad: work around build failure on SolarisAlex Viskovatoff2010-12-211-2/+2
| | | | | | | | | | | | | | | | Rename the "version" struct, because it seems to be a reserved name on Solaris: "src/decoder/mad_decoder_plugin.c", line 550: (enum) tag redeclared: version cc: acomp failed for src/decoder/mad_decoder_plugin.c
* | output/solaris: add missing parameter to open_cloexec() callAlex Viskovatoff2010-12-211-1/+1
| |
* | audio_check: fix parameter in prototypeAlex Viskovatoff2010-12-211-1/+1
| |
* | tag_id3: support multiple valuesMax Kellermann2010-12-071-10/+36
| | | | | | | | | | Loop over all frames with a specific id, and import all of them - not just the first one (index 0).
* | command: don't error when sticker list is run on song with no stickersAnton Khirnov2010-12-071-7/+3
| | | | | | | | | | | | this is inconsistent with other commands (e.g. find) and seems wrong -- a song with no stickers attached is a perfectly valid state and an empty list of stickers is also perfectly valid.
* | tag_ape: support multiple valuesMax Kellermann2010-11-241-1/+15
| | | | | | | | One APE tag may contain more than one value, separated by null bytes.
* | decoder_thread: load APE replay gain from music filesMax Kellermann2010-11-181-0/+15
| |
* | replay_gain_ape: parse replay gain from APE tagsMax Kellermann2010-11-182-0/+110
| | | | | | | | Based on the APE reader.
* | tag_ape: move code to ape.cMax Kellermann2010-11-183-93/+174
| | | | | | | | Generic library for scanning APE tags. Eliminated one "goto"!
* | timer: fix integer overflow in timer_delay()Max Kellermann2010-11-181-1/+1
| | | | | | | | | | | | | | Fixes a regression: for output_plugin.delay(), we added a method to the timer class which returns the delay in milliseconds. This fails to detect negative values, because the unsigned integer is divided by 1000, and then casted to signed.
* | playlist_song: calculate duration of last CUE trackMax Kellermann2010-11-081-0/+8
| |
* | Merge release 0.15.15 from branch 'v0.15.x'Max Kellermann2010-11-082-2/+2
|\| | | | | | | | | | | Conflicts: NEWS configure.ac
| * output/shout: artist comes first in stream titleMax Kellermann2010-11-081-1/+1
| | | | | | | | | | | | After popular demand, I've switched the order of "artist" and "title" in the stream title. There is no standard, and there is no reliable way to parse those from the stream title.
| * input/rewind: fix assertion failureMax Kellermann2010-11-081-1/+1
| | | | | | | | | | The assertion added in MPD 0.15.14 was too much, it failed when the MIME type of a stream was NULL.
* | update_walk: explicitly check for permission problemsMax Kellermann2010-11-081-0/+33
| | | | | | | | | | | | Call access() and print an extra error message when EACCES is returned. Hopefully this will reduce the number of support requests due to wrong file permissions.
* | Merge release 0.15.14 from branch 'v0.15.x'Max Kellermann2010-11-0710-45/+100
|\| | | | | | | | | | | | | | | | | | | | | | | Conflicts: NEWS configure.ac src/decoder_control.c src/decoder_control.h src/input/rewind_input_plugin.c src/output_control.c src/output_thread.c src/player_thread.c
| * player_thread: fix assertion failure due to wrong music pipe on seekMax Kellermann2010-11-051-0/+8
| | | | | | | | | | | | | | | | | | When one song is played twice, and the decoder is working on the second "instance", but the first should be seeked, the check in player_seek_decoder() may assume that it can reuse the decoder without exchanging pipes. The last thing was the mistake: the pipe pointer was different, which led to an assertion failure. This patch adds another check which exchanges the player pipe.
| * decoder_control: pass music_pipe to dc_start()Max Kellermann2010-11-053-12/+18
| | | | | | | | More abstraction for decoder_control.pipe.
| * player_thread: add helper function player_dc_at_next_song()Max Kellermann2010-11-051-6/+33
| | | | | | | | Some abstraction for decoder_control.pipe access.
| * pipe: add helper function music_pipe_empty()Max Kellermann2010-11-053-4/+10
| |
| * input/rewind: remove redundant NULL check before g_free() callMax Kellermann2010-11-051-2/+1
| |
| * input/rewind: add two assertionsMax Kellermann2010-11-051-0/+3
| |
| * input/rewind: fix double free bugMax Kellermann2010-11-051-0/+1
| | | | | | | | | | Duplicate the "mime" attribute of the inner input_stream object, instead of copying the pointer.
| * decoder/{mp4ff,ffmpeg}: add extension ".m4b" (audio book)Max Kellermann2010-11-052-2/+10
| | | | | | | | Same as ".m4a".
| * output_thread: fix assertion failure due to race condition in OPENMax Kellermann2010-11-041-1/+9
| | | | | | | | | | | | Change the assertion on "fail_timer==NULL" in OPEN to a runtime check. This assertion crashed when the output thread failed while the player thread was calling audio_output_open().
| * output_internal: protect attribute "fail_timer" with mutexMax Kellermann2010-11-042-1/+7
| |
| * output_control: lock object in audio_output_open()Max Kellermann2010-11-041-6/+19
| | | | | | | | Protect the attributes "open" and "fail_timer".
| * output_control: lock object in audio_output_close()Max Kellermann2010-11-041-2/+28
| | | | | | | | Protect the attributes "open" and "fail_timer".
* | output/alsa: dump buffer and period limitsMax Kellermann2010-11-051-0/+20
| |
* | output/httpd: implement delay()Max Kellermann2010-11-051-2/+11
| |
* | output/shout: implement delay()Max Kellermann2010-11-051-8/+13
| | | | | | | | | | This makes the plugin more responsive to control commands, because it will listen to control events while waiting.
* | output_plugin: add method delay()Max Kellermann2010-11-053-3/+51
| | | | | | | | | | This method is used to reduce the delay of commands issued to the shout plugin.
* | timer: add function timer_delay()Max Kellermann2010-11-052-0/+19
| |
* | server_socket: remove AI_ADDRCONFIGMantas Mikulenas2010-11-041-3/+0
| | | | | | | | | | | | | | When you pass the flag AI_ADDRCONFIG to getaddrinfo(), it does not consider address families on the loopback device. When run on a machine without an external network card, just with "lo", it was unable to look up any address.
* | output/ffado: transfer_playback_buffers() returns a booleanMax Kellermann2010-11-041-1/+4
| | | | | | | | | | libffado documentation says this function returns -1 on error, but that is a lie - it returns a boolean value, and "false" means error.