| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
| |
strcasecmp() is locale dependent, making it a bad choice for internal
string comparisons.
|
| |
|
|
| |
This allows you to select controls with duplicate names.
|
| |
|
|
|
|
| |
Database update was broken due to the dc.pipe!=NULL assertion. This
assertion is only valid while MPD decodes a song, not during database
update.
|
| |
|
|
|
|
|
| |
libvorbis goes into a very long loop if we try to add data after a
flush was invoked by vorbis_analysis_wrote(0). This seems to be a
problem with the internal end-of-stream marker. Thus, we cannot reuse
the vorbis_dsp_state object.
|
| |
|
|
|
|
|
| |
When the decoder thread has a pending command, send the STOP command
to cancel this command. Send STOP again if the decoder thread is
still running after that, just in case the decoder thread has executed
the previous command (which was overwritten).
|
| |
|
|
|
| |
dc.pipe must be non-NULL while the decoder thread is running. Ensure
that with a load of assertions.
|
| | |
|
| |
|
|
|
| |
To determine whether to rewind the current song or to go to the
previous song, use a GTimer instead of manually diffing time(NULL).
|
| |
|
|
|
|
| |
Using two different kinds of locks may result in a race condition with
a deadlock. The libpulse callbacks need no locks at all, because the
mainloop object can be assumed to be already locked.
|
| |
|
|
|
| |
The old global settings "http_proxy_host", "http_proxy_port",
"http_proxy_user" and "http_proxy_password" continue to work.
|
| | |
|
| |
|
|
|
|
| |
When all audio outputs have been closed due to failures, pause the
playback instead of stopping it. This way, the user may resume
at the current position after the problem has been dealt with.
|
| |
|
|
|
|
|
|
|
| |
When no audio outputs could be opened while seeking, leave MPD seeked
at that position and pause playback. The user may continue from this
point at any time, as soon as the audio outputs are fixed. The old
behaviour triggered an assertion failure: the failure wasn't passed
properly to the do_play() function, which attempted to play audio
chunks.
|
| |
|
|
|
| |
spl_append_song() can crash when fopen() fails, because it attempts to
close the invalid file handle (NULL) in the error handler.
|
| |
|
|
|
| |
Call snd_config_update_free_global() manually in our finish() method,
don't use atexit().
|
| |
|
|
|
|
|
|
| |
snd_config_update_free_global() frees cached ALSA configuration. This
keeps valgrind a little bit more quiet. This patch moves the call
from the open() method into the finish() method, which seems more
natural: it allows the use of the config cache, and improves the
cleanup phase.
|
| |
|
|
|
| |
For non-global mixers (only "pulse" currently), close the mixer when
MPD playback is paused.
|
| |
|
|
|
| |
This patch fixes a memory leak: the fifo_buffer object was not freed
when the client connection was closed.
|
| |
|
|
|
| |
icy_server_metadata_string() is only called by
icy_server_metadata_page().
|
| |
|
|
| |
Plain "bool" consumes only one byte instead of four.
|
| |
|
|
| |
In HTTP, header names are case insensitive.
|
| |
|
|
|
|
| |
[mk: folded with patch "Put icy related functions in extra source
files"; moved icy_server.c from HAVE_CURL to ENABLE_HTTPD_OUTPUT;
removed an unused variable]
|
| |
|
|
|
|
| |
When a new song starts playing, send its tag (song->tag) to the music
pipe. This allows output plugins to render tags for all songs, not
only those with embedded tags understood by the decoder plugin.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
The httpd_client_check_queue() callback function does not use its
"user_data" argument. Don't pass any, and fix the gcc warning.
|
| | |
|
| |
|
|
|
| |
This command allows clients to search for stickers with a specified
name.
|
| |
|
|
|
|
|
|
| |
db_get_song was being called once for all sub-handlers, but with the
addition of the find command, we don't have a URI coming in, so doing
db_get_song once won't work anymore.
[mk: fixed initialization order]
|
| |
|
|
| |
This is a wrapper for sticker_find(), which looks up the song object.
|
| |
|
|
| |
sticker_find() finds stickers with the specified name.
|
| |
|
|
| |
Moved code from db_get_song().
|
| |
|
|
|
| |
Renamed directory_get_directory() to directory_lookup_directory().
Added API documentation.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
On both locations, the result of write() can be ignored safely. In
event_pipe_emit_fast(), that can only be "EAGAIN", which means that
the pipe buffer is full - no further notification required. In
client_init(), that would be a fatal connection error, which would be
caught by the next event.
This patch fixes gcc warnings.
|
| |
|
|
|
| |
g_set_error() is a printf-like function, and expects a format string.
Using the return value of gai_strerror() is unsafe.
|
| |
|
|
| |
Move the declaration of "i" into the "for" loop.
|
| |
|
|
|
|
|
| |
Cuesheets are often saved as vorbis comment
flac files (CUESHEET=.. case doesn't matter).
We can parse this now and use the information to
tag the subtracks (from the embedded cuesheets).
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
With these methods a tag struct can be created
from the cdtext information in a cue sheet.
The methods depend on a cue parsing library.
Reading from strings (char*) as well as from
a file (FILE*) is supported.
|
| |
|
|
|
|
| |
This is a little ugly, but as nextSongInPlaylist is both called when
queued is update (in case playlist ended) and for user "next" command,
there isn't any other (simple) solution
|
| | |
|
| | |
|
| | |
|
