aboutsummaryrefslogtreecommitdiffstats
path: root/src (follow)
Commit message (Collapse)AuthorAgeFilesLines
* playlist: don't shuffle if not in random modeMax Kellermann2009-01-231-1/+1
| | | | | | One of the previous patches removed the "random" mode check from nextSongInPlaylist(), which caused a shuffle whenever MPD wrapped to the first song in "repeat" mode. Re-add that "random" check.
* playlist: removed unreachable "playing" checkMax Kellermann2009-01-231-11/+7
| | | | | | In playPlaylist(), the second "song==-1 && playing" check can never be reached, because at this point, the function has already returned (after unpausing).
* playlist: removed stopOnError flag from playPlaylist()Max Kellermann2009-01-233-10/+10
| | | | All callers pass false. Don't bother to collect that parameter.
* playlist: restart playing in deleteFromPlaylist()Max Kellermann2009-01-231-22/+9
| | | | | | When a song is deleted, start playing the next song immediately, within deleteFromPlaylist(). This allows us to remove the ugly playlist_noGoToNext flag, and the currentSongInPlaylist() function.
* playlist: calculate next song before deleting the current oneMax Kellermann2009-01-231-11/+5
| | | | | | | By calling queue_next_order() before playlist.current is invalidated (by the deletion of a song), we get more robust results, and the code becomes a little bit easier. incrPlaylistCurrent() is unused now, and can be removed.
* playlist: return early from shufflePlaylist()Max Kellermann2009-01-231-23/+24
| | | | | Remove one indent level by returning diretly after the check. This makes the function more readable.
* playlist: replaced playlist_state with flag playlist.playingMax Kellermann2009-01-232-33/+32
| | | | | | There were only two possible states: STOP and PLAY. The code looks a lot easier if we use a bool instead. Move the variable into the playlist struct.
* queue: added queue_shuffle_order()Max Kellermann2009-01-233-35/+53
| | | | | | | | | | | The function shuffles the virtual order of songs, but does not move them physically. This is used in random mode. The new function replaces playlist.c's randomizeOrder() function, which was aware of playlist.current and playlist.queued. The latter is always -1 anyway, and the former as preserved by the caller, by converting playlist.current to a position, and then back to an order number.
* playlist: check if repeat mode changesMax Kellermann2009-01-231-1/+4
| | | | | | Add a "changed" check to setPlaylistRepeatStatus(): when the new repeat mode is the same as the old one, don't do anything at all. No more checks, no "idle" event.
* playlist: recalculate the queued song after random is toggledMax Kellermann2009-01-231-0/+3
| | | | | | When the random mode is toggled, MPD did not clear the queue. Because of this, MPD continued with the next (random or non-random) song according to the previous mode. Clear the queued song to fix that.
* playlist: moved code to playlist_queue_song_order()Max Kellermann2009-01-231-23/+20
| | | | Merged duplicate code from queueNextSongInPlaylist().
* playlist: documented struct membersMax Kellermann2009-01-231-0/+13
| | | | Added several comments.
* queue: merged songs, songMod, positionToId into struct queue_itemMax Kellermann2009-01-232-56/+52
| | | | | Move everything which belongs together into one common struct. This simplifies the implementation of several queue operations.
* playlist: moved code to queue.cMax Kellermann2009-01-225-357/+777
| | | | | Attempt to untie the playlist.c knot: moved the playlist storage code to queue.c, struct queue.
* playlist: corrected shuffle underflow testMax Kellermann2009-01-221-2/+2
| | | | Check for current>=0, not queued>=0.
* playlist: fix buffer underflow when getting current songMax Kellermann2009-01-221-7/+10
| | | | | | The function moveSongInPlaylist() attempted to read the position of the current song, even if it was -1. Check that first. The same bug was in shufflePlaylist().
* locate: use const pointersMax Kellermann2009-01-224-32/+28
| | | | Pass const pointers where no writes are performed.
* null: added option to disable timer synchronizationMax Kellermann2009-01-221-1/+11
| | | | | | | The null plugin synchronizes the playback so it will happen in real time. This patch adds a configuration option which disables this: the playback will then be as fast as possible. This can be useful to profile MPD.
* null: implemented finish() methodMax Kellermann2009-01-221-0/+13
| | | | Free memory in the finish() method to make valgrind happy.
* null: no CamelCaseMax Kellermann2009-01-222-15/+20
| | | | Renamed functions and variables.
* playlist: convert assertion to check in TAG event handlerMax Kellermann2009-01-211-2/+3
| | | | | | It is possible that playlist.current is reset before the TAG event handler playlist_tag_event() is called. Convert the assertion into a run-time check.
* player_thread: emit PLAYLIST event when new song failsMax Kellermann2009-01-211-1/+1
| | | | | | Break from the loop instead of returning the function. This calls player_stop_decoder(), which in turn emits the PLAYLIST event. This allows the playlist to re-start the player.
* player_thread: check for decoder failure before seekingMax Kellermann2009-01-211-1/+4
| | | | | The function player_seek_decoder() starts the decoder, but does not check the return value of player_wait_for_decoder().
* player_thread: use bool instead of intMax Kellermann2009-01-211-12/+13
| | | | | Make player_wait_for_decoder() and play_chunk() return a bool instead of 0/-1.
* command: don't restart player in the "status" commandMax Kellermann2009-01-213-4/+3
| | | | | | Don't attempt to restart the player if it was stopped, but there were still songs left on the playlist. This looks like it has been a workaround for a bug which has been fixed long time ago.
* playlist: use the "enum player_error" typeMax Kellermann2009-01-211-1/+1
| | | | Don't assign the result of getPlayerError() to an integer.
* playlist: free memory with g_free()Max Kellermann2009-01-211-10/+5
| | | | | Use g_free() consistently with g_malloc(). Don't clear the pointers after freeing them.
* player_thread: request next song only if new one starts playingMax Kellermann2009-01-211-11/+0
| | | | | | | | | The player_thread loop requests the next song from the playlist as soon as the decoder finishes the song which is currently being played. This is superfluous, and can lead to synchronization errors and wrong results. The playlist already knows when the player starts playing the next song (player_wait_for_decoder() triggers the PLAYLIST event), and will then trigger the scheduler to provide the next song.
* use config_get_positive() instead of manual parsingMax Kellermann2009-01-213-81/+21
| | | | | Simplify some code by using config_get_positive(), instead of doing manual parsing and validation each time.
* conf: added config_get_positive()Max Kellermann2009-01-212-0/+23
| | | | | This convenience function parses a configuration value into a positive integer. It aborts if parsing fails.
* archiveapi: adding seeking support in zip archivesViliam Mateicka2009-01-211-2/+8
|
* player_thread: eliminated duplicate PLAYLIST eventMax Kellermann2009-01-201-2/+0
| | | | | player_wait_for_decoder() emits the PLAYLIST event on success, remove the duplicate PLAYLIST event in its caller.
* event_pipe: added "TAG" eventMax Kellermann2009-01-204-34/+22
| | | | | | The "TAG" event is emitted by the player thread when the current song's tag has changed. Split this event from "PLAYLIST" and make it a separate callback, which is more efficient.
* Add space after sticker: to make it consistent.Qball Cow2009-01-201-1/+1
|
* command: added "sticker" commandMax Kellermann2009-01-191-0/+72
| | | | | | | The "sticker" command allows clients to query or manipulate the sticker database. This patch implements the sub-commands "get" and "set"; more will follow soon (enumeration), as well as extended "lsinfo" / "playlistinfo" versions.
* update: delete stickers of deleted songsMax Kellermann2009-01-191-0/+9
| | | | | | | When a song is deleted from the database, remove its sticker, too. What's still missing is some sort of garbage collector after a fresh database create (--create-db).
* sticker: added song sticker libraryMax Kellermann2009-01-193-1/+122
| | | | | This is a wrapper for the backend sticker library. It provides several glue functions which take a song object instead of type/uri.
* sticker: new library for storing dynamic information about songsMax Kellermann2009-01-196-0/+466
| | | | | | | "Stickers" are pieces of information attached to existing MPD objects (e.g. song files, directories, albums). Clients can create arbitrary name/value pairs. MPD itself does not assume any special meaning in them.
* flac: include config.hMax Kellermann2009-01-191-0/+1
| | | | | The plugin queries build-time configuration variables, and should include config.h.
* output: don't include conf.h from output_control.hMax Kellermann2009-01-181-2/+1
| | | | Minimize header dependencies.
* conf: added config_get_block_unsigned()Max Kellermann2009-01-186-39/+33
| | | | Eliminate some more getBlockParam() invocations.
* conf: added config_get_block_string()Max Kellermann2009-01-1811-98/+95
| | | | This replaces lots of getBlockParam() invocations.
* jack: parse "ports" setting with g_strsplit()Max Kellermann2009-01-181-20/+7
| | | | Don't modify the configured string.
* jack: use audio_output_get_name()Max Kellermann2009-01-181-11/+1
| | | | | Determine the audio output name with audio_output_get_name() instead of obtaining the name from the configuration again.
* conf: removed parseConfigFilePath()Max Kellermann2009-01-183-46/+19
| | | | Use config_get_path() instead in mapper.c.
* mixer: don't check for NULL before g_free()Max Kellermann2009-01-182-16/+11
| | | | | The g_free() function includes a NULL check. We don't have to do it twice.
* daemon: removed unused variable "userpwd"Max Kellermann2009-01-181-8/+4
| | | | This causes a segmentation fault...
* daemon: pass "detach" flag to daemonize()Max Kellermann2009-01-183-6/+7
| | | | | This way, we don't have to pass the full "Options" object to daemonize().
* daemon: added daemonize_init(), daemonize_finish()Max Kellermann2009-01-183-45/+72
| | | | | | The constructor/destructor functions parse and free the configuration properly. This way, we don't have to load the pid file path more than once.
* main: moved the save_state timer to state_file.cMax Kellermann2009-01-182-20/+26
| | | | The state_file library should manage its own regular saves.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-30 22:59:19 +0000