aboutsummaryrefslogtreecommitdiffstats
path: root/src (follow)
Commit message (Collapse)AuthorAgeFilesLines
* stored_playlist: no CamelCaseMax Kellermann2008-10-225-34/+39
| | | | Renamed all public functions, prefix is "spl_".
* renamed storedPlaylist.c to stored_playlist.cMax Kellermann2008-10-226-8/+8
| | | | No CamelCase in file names.
* command: added "commands" array instead of registering manuallyMax Kellermann2008-10-221-193/+145
| | | | | | The list of commands is known at compile time. Instead of creating a linked list on startup, we can just register all commands in a static sorted array.
* command: make command pointers constantMax Kellermann2008-10-221-12/+13
| | | | | | The command pointers which are passed around aren't being modified - in fact, no command pointer must be modified once it has been added to the commandList.
* command: renamed CommandEntry to struct commandMax Kellermann2008-10-221-12/+10
| | | | No CamelCase and no struct typedefs.
* pcm_utils: added pcm_convert_init()Max Kellermann2008-10-214-2/+9
| | | | | | Instead of manually calling memset(0) on the pcm_convert_state struct, client code should use a library function from pcm_utils.c. This way, we can change the semantics of the struct easily.
* pcm_utils: no CamelCaseMax Kellermann2008-10-215-88/+89
| | | | Renamed all functions which were still in CamelCase.
* pcm_utils: renamed ConvState to struct pcm_convert_stateMax Kellermann2008-10-215-9/+12
| | | | No CamelCase, and a struct instead of a typedef.
* ffmpeg: don't pass pointer as hexadecimal stringMax Kellermann2008-10-211-20/+27
| | | | | | | | | | | | | | Casting a pointer to some sort of integer and formatting it into a string isn't valid. A pointer derived from this hex string won't work reliably. Since ffmpeg doesn't provide a nice API for passing our pointer, we have to think of a different hack: ffmpeg passes the exact URL pointer to mpdurl_open(), and we can make this string part of a struct. This reduces the problem to casting the string back to the struct. This is still a workaround, but this is "sort of portable", unless the ffmpeg people start messing with the URL pointer (which would be valid according to the API definition).
* ffmpeg: detect which ffmpeg headers should be includedMax Kellermann2008-10-211-0/+6
| | | | | | | | | Since ffmpeg svn r12865, you have to include libavcodec/avcodec.h instead of avcodec.h. This cannot be checked at compile time, instead we have to add a check to configure.ac. Viliam's original ffmpeg plugin was based on the newer ffmpeg library, while my Debian installation had the older version. My attempt to correct his include statements wasn't correct after all.
* update: fix multiple deletes from *vec iteratorsEric Wong2008-10-212-2/+10
| | | | | | | | | | | {song,dir}vec_for_each each failed to gracefully handle deleted files when iterating through. While we were thread-safe, we were not safe within the calling thread. If a callback we passed caused sv->nr to shring, our index would still increment; causing files to stay in the database. A way to test this is to remove 10 or so contiguous songs from a >10 song directory.
* dirvec: introduce locking for all iteratorsEric Wong2008-10-211-6/+25
| | | | | | | Like the songvec nr_lock, only one lock is used for all traversals since they're rarely changed. This only projects traversals, but not the individual structures themselves.
* {dir,song}vec: these structs are constEric Wong2008-10-212-2/+2
| | | | We definitely don't modify them here.
* dirvec: add dirvec_for_each iteratorEric Wong2008-10-212-0/+19
| | | | This will make it easier to introduce locking
* path: removed pathcpy_trunc()Max Kellermann2008-10-203-24/+2
| | | | There was only one user of pathcpy_trunc(), which can be eliminated.
* path: replaced parent_path() with g_path_get_dirname()Max Kellermann2008-10-203-42/+7
| | | | Again, GLib's version is more robust than ours.
* path: replaced mpd_basename() with g_path_get_basename()Max Kellermann2008-10-206-29/+30
| | | | | | GLib's g_path_get_basename() is much more reliable than mpd_basename(). The latter could be tricked into an assertion failure.
* signal_check.c: don't use leading underscoresMax Kellermann2008-10-201-8/+8
| | | | | Identifiers with two leading underscores are reserved for the C compiler's internal use. Don't use them in the source.
* mapper: don't return database path with leading slashMax Kellermann2008-10-191-1/+1
| | | | | Due to an off-by-one bug in map_fs_to_utf8(), the function returned database paths with a leading slash.
* listen: fix "struct ucred" checkAndrzej Rybczak2008-10-181-3/+3
| | | | The macro name is HAVE_STRUCT_UCRED, not HAVE_UCRED.
* input_stream: don't declare method typedefsMax Kellermann2008-10-181-14/+8
| | | | | The typedefs aren't using by anybody but struct input_stream. Remove them and declare the method type within struct input_stream.
* ffmpeg: make internal functions staticMax Kellermann2008-10-181-22/+12
| | | | | The mpdurl_* code is internal, don't expose them. Also don't initialize struct members with NULL.
* client: converted permissions to unsignedMax Kellermann2008-10-175-22/+22
| | | | client->permission is a bit set, and should be unsigned.
* client: eliminate variable "left" in client_write()Max Kellermann2008-10-171-5/+5
| | | | Reduce two temporary variables to only one.
* client: fixed send bufferMax Kellermann2008-10-171-49/+4
| | | | | There is no sense in using the kernel's send buffer size (SO_SNDBUF) for MPD's send buffer. Convert it into a static buffer of 4 kB.
* client: removed CLIENT_MAX_BUFFER_LENGTHMax Kellermann2008-10-171-3/+2
| | | | | | | Use a literal in the struct declaration, and sizeof(client->buffer) everywhere else. Also shrink the buffer from 40 kB to 4 kB. The buffer must only be large enough to hold one line of input, and 4 kB is still more than enough.
* client: added assertions on the buffer pointersMax Kellermann2008-10-171-0/+6
| | | | The buffer pointers must not exceed the buffer size.
* client: read() return value is ssize_tMax Kellermann2008-10-171-2/+2
| | | | Use ssize_t instead of int.
* client: handle partial lines correctlyMax Kellermann2008-10-171-2/+2
| | | | | | Commit 6eb62e47 didn't obey partial lines correctly: when a line wasn't finished in one read, the first part was ignored when the rest arrived.
* ffmpeg: new decoder pluginViliam Mateicka2008-10-173-0/+426
| | | | | | [mk: fixed indent, changed copyright statement, added autoconf test, fixed includes paths, fixed 2 gcc warnings, don't close input stream twice]
* Makefile.am: don't compile disabled decoder pluginsMax Kellermann2008-10-1716-159/+83
| | | | | Don't compile the sources of disabled decoder plugins at all, and don't attempt to register these.
* Makefile.am: don't compile disabled sourcesMax Kellermann2008-10-174-28/+21
| | | | | If a feature is disabled, don't compile the source file at all, disable it completely in Makefile.am instead.
* input_stream: removed nmemb argumentMax Kellermann2008-10-178-16/+12
| | | | | The nmemb argument isn't actually useful, and one of nmemb and size was always passed as 1. Remove it.
* input: declare struct input_streamMax Kellermann2008-10-177-43/+50
| | | | | Provide a struct type which can be forward-declared. The typedef InputStream is deprecated now.
* decoder: notify player after entering decodeStart()Max Kellermann2008-10-171-0/+1
| | | | | Wake up the player as soon as the decoder thread has entered its loop. This fixes a dead lock when the input is blocking.
* command: expect "file:///" url for local filesMax Kellermann2008-10-171-4/+7
| | | | | | When adding a local file, clients have to use the "file" URI schema described in RFC 1738 3.10. By adding this schema to "urlhandlers", a client can detect whether this feature is available.
* listen: fixed unused variable warning without HAVE_UCREDMax Kellermann2008-10-171-0/+2
| | | | The local variable "passcred" was only used by ucred code.
* configure.ac: check if "struct ucred" is availableMax Kellermann2008-10-161-2/+2
| | | | | | | | | | | By default, glibc 2.8 hides struct ucred behind the _GNU_SOURCE macro. I don't want to enable that globally, because it may encourage the use of non-portable functions. Test if "struct ucred" is available, and enable _GNU_SOURCE if required. For details about that issue, see glib's bug database: http://sources.redhat.com/bugzilla/show_bug.cgi?id=6545
* configure.ac: find more libraries with pkg-configMax Kellermann2008-10-161-0/+6
| | | | | Detect the following libraries with pkg-config: libshout, libid3tag, libmad.
* command: special case for "add /"Max Kellermann2008-10-161-1/+1
| | | | | The undocumented command "add /" adds the full music database to the playlist. Don't interpret this special path as a local file path.
* playlist: also allow world-readable local filesMax Kellermann2008-10-151-1/+1
| | | | | Allow a local user to not only add his own files, but also all world-readable files (mode 0444).
* song: check file type in song_file_update()Max Kellermann2008-10-151-1/+1
| | | | Don't load non-regular files.
* playlist: added support for adding songs not in the music databaseMax Kellermann2008-10-156-6/+59
| | | | | Clients which have authenticated via unix socket may add local files to the MPD playlist, provided that they own the file.
* command: print error message on "addid" failureMax Kellermann2008-10-151-1/+1
| | | | | | Returning the playlist_result value from a command handler does not make sense. Call print_playlist_result() there, and forward its return value.
* playlist: moved code to song_by_url()Max Kellermann2008-10-151-4/+17
| | | | | Replace some complicated checks from addToPlaylist() to the simpler function song_by_url().
* song: added song_in_database()Max Kellermann2008-10-152-9/+14
| | | | | | | Some functions assume that a song is not in the database when it is a remote song. Based on that, they decide whether they are responsible for freeing the song struct. Add a special function which checks whether a song is in the database (currently equal to song_is_file()).
* listen, client: enable SO_PASSCRED, get client's uidMax Kellermann2008-10-153-3/+41
| | | | | Enable authentication over unix sockets. Store the client's uid in the client struct.
* update: don't skip hidden filesMax Kellermann2008-10-151-3/+5
| | | | | Skip only the special directory entries "." and "..", don't skip all other "hidden" files.
* shout: check for vorbisenc libraryMax Kellermann2008-10-151-2/+2
| | | | | The switch from ogg.m4 to pkg-config intentionally disabled libvorbisenc. Enable it when shout_ogg is used.
* fixing several imports to work via pkg-configEnrico Weigelt2008-10-151-3/+10
| | | | | This patch fixes several imports to use pkg-config instead of certain esoteric tests.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-16 11:55:50 +0000