aboutsummaryrefslogtreecommitdiffstats
path: root/src (follow)
Commit message (Collapse)AuthorAgeFilesLines
* command: allow clients to subscribe to specific idle eventsMarc Pavot2008-11-225-20/+60
| | | | | | The client may provide the names of idle events as arguments to the "idle" command to inform MPD that it is only interested in these events.
* decoder: check audio_format_valid() in all decodersMax Kellermann2008-11-2110-7/+71
| | | | Refuse to play audio formats which are not supported by MPD.
* audio_format: added audio_format_valid()Max Kellermann2008-11-211-0/+11
|
* decoder: ignore decoder_data() calls with length==0Max Kellermann2008-11-211-1/+2
| | | | | Pushing buffers with a zero length into the MPD core causes failures; don't let them pass beyond the decoder plugi API.
* flac, oggflac: use GLib instead of utils.h/log.hMax Kellermann2008-11-214-33/+29
|
* ffmpeg: use GLib instead of log.hMax Kellermann2008-11-211-8/+11
|
* audiofile: use GLib instead of log.hMax Kellermann2008-11-211-8/+10
|
* aac: use GLib instead of utils.h/log.hMax Kellermann2008-11-211-10/+10
| | | | Removed the superfluous my_usleep() call.
* log: print the log_domainMax Kellermann2008-11-211-2/+6
|
* state_file: save state_file every 5 minutesMax Kellermann2008-11-211-0/+9
| | | | | | | | | | | | When MPD quits in a non-clean way, the state file isn't written, and on the next start, MPD time warps to the previous clean shutdown. Save the state file every 5 minutes; this will probably be configurable at a later time. Note that we don't set a wakeup timer for that: when there is no MPD traffic, MPD won't wake up to save the state file. This minor bug is tolerated, because usually there is no change in MPD's state when the main thread is idle.
* input_curl: try to seek by fast-forwarding the bufferMax Kellermann2008-11-211-0/+26
| | | | | | If the caller attempts to seek only a few bytes forward, chances are good that the offset is already in the buffer. In this case, simply fast-forward the buffer.
* input_curl: moved code to consume_buffer()Max Kellermann2008-11-211-12/+26
| | | | Added some assertions.
* input_curl: don't do temporary calculations with input_stream.offsetMax Kellermann2008-11-211-4/+4
| | | | | | | If someone calls seek() with an invalid (negative) offset, the curl implementation of that method returned false, but left this invalid offset in input_stream.offset. Move the calculation to a temporary variable.
* decoder: ignore the SEEK command during startupMax Kellermann2008-11-201-1/+1
| | | | | | While waiting for the input stream to become ready, ignore all commands except STOP. This fixes seeking errors with (remote) songs which the decoder has already finished.
* ogg: moved the "errorStr" variable into the error handlerMax Kellermann2008-11-201-1/+2
|
* aac: get rid of gcc warningsLaszlo Ashin2008-11-201-2/+2
|
* update: pass UTF-8 path to skip_symlink()Konstantin Sobolev2008-11-201-3/+2
| | | | | | skip_symlinks() expects an UTF-8 encoded file name, but updateDirectory() passed ent->d_name (in file system encoding) to it. Convert it to UTF-8 first.
* mapper: use the utf8_to_fs_charset() resultKonstantin Sobolev2008-11-201-1/+1
| | | | | | In map_directory_child_fs(), the result of utf8_to_fs_charset() was never used, because it passed the unmodified "name" parameter to pfx_dir().
* path: fix g_convert() argument orderKonstantin Sobolev2008-11-201-2/+2
| | | | | g_convert() wants the destination character set first. This was mixed up.
* ogg: check the ov_read() return value before the vorbis_info evaluationMax Kellermann2008-11-201-7/+6
| | | | | | The ov_info() return value may be corrupt when ov_read() did not return a positive value. First check for success, then check ov_info().
* input_curl: don't fail when seek to EOF is requestedMax Kellermann2008-11-201-0/+8
| | | | | | | HTTP servers respond with "416 Requested Range Not Satisfiable" when a client attempts to seek to the end of the file. Catch this special case in input_curl_seek(). This fixes a glitch in the ogg vorbis decoder plugin.
* curl: don't check running_handles for EOFMax Kellermann2008-11-201-7/+1
| | | | | | Since we are using curl_multi_info_read() / CURLMSG_DONE for detecting end-of-response, we can remove all running_handles==0 checks. For some reason, that has never worked correctly.
* input_curl: always set eof=true on CURLMSG_DONEMax Kellermann2008-11-201-5/+7
| | | | | | | curl_multi_info_read() is the authoritative source of the "end-of-response" information. Always set c->eof when a CURLMSG_DONE message is received, and check the result (success/failure) after that.
* wavpack: redo using audio_format_frame_size()Laszlo Ashin2008-11-191-6/+1
| | | | Somehow we lost 600e1322 after renaming some variables in ed6f6046.
* decoder: pass the correct buffer length to pcm_convert()Max Kellermann2008-11-181-5/+6
| | | | | | | | When a global audio format is configured (setting "audio_output_format"), decoder_data() overwrote the "length" parameter with the size of the output buffer (result of pcm_convert_size()). Declare a separate variable for the output buffer length.
* ffmpeg: read tags from AVFormatContextViliam Mateicka2008-11-181-5/+16
| | | | | The ffmpeg library provides some of the song metadata in the AVFormatContext struct. Pass it from there to MPD.
* audiofile: fixed misplaced ifViliam Mateicka2008-11-181-2/+1
| | | | [mk: by definition, tag_new() cannot fail - removed check]
* music_pipe: narrowed assertion on chunk indexMax Kellermann2008-11-181-1/+1
| | | | | The chunk index passed to successor() must be valid, i.e. it must be smaller than num_chunks.
* input_stream: size==-1 means unknown sizeMax Kellermann2008-11-166-2/+15
| | | | | | Define the special value "-1" as "unknown size". Previously, there was no indicator for streams with unknown size, which might confuse some decoders.
* ffmpeg: fixed AVSEEK_SIZEMax Kellermann2008-11-161-3/+9
| | | | | | With whence==AVSEEK_SIZE, the seek function should return the file size, not the current offset. Check the return value of input_stream_seek().
* aac: detect whether to pass "uint32_t*" to NeAACDecInit2()Max Kellermann2008-11-162-7/+31
| | | | | | | | | neaacdec.h declares all arguments as "unsigned long", but internally expects uint32_t pointers. This triggers gcc warnings on 64 bit architectures. To avoid that, make configure.ac detect whether we're using Debian's corrected headers or the original libfaad headers. In any case, pass a pointer to an uint32_t, conditionally casted to "unsigned long*".
* decoder: check length==0 in decoder_read()Max Kellermann2008-11-152-0/+7
| | | | | When the caller passes length==0, decoder_read() entered an endless loop. Check that condition before entering the "while" loop.
* aac: fix compiler warnings on amd64Laszlo Ashin2008-11-151-2/+2
|
* aac: don't try to free static bufferLaszlo Ashin2008-11-151-4/+0
| | | | | In 432da18e a dynamic buffer was replaced by a static one but some frees were accidently left there which caused some segfaults.
* log: check the log threshold in log_func()Max Kellermann2008-11-141-0/+3
| | | | | The threshold was only checked in the deprecated logging functions (ERROR(), WARNING(), ...). Add the check to the GLib logging handler.
* volume: eliminate alloca() usageMax Kellermann2008-11-141-11/+4
| | | | | | alloca() is not a portable function. Don't use it. Using strncasecmp() is much more efficient anyway, because no memory needs to be allocated and copied.
* volume: moved code to oss_mixer_find()Max Kellermann2008-11-141-14/+23
|
* player: don't queue song when there are 2 songs in the pipeMax Kellermann2008-11-141-0/+5
| | | | | | | | | Don't send a "next song" request to the main thread when the current song hasn't started playing yet, i.e. there are already two different songs in the music pipe. This would erase information about the song boundary within the music pipe, and thus triggered an assertion failure. The bug could occur when playing very short songs which fit into the pipe as a whole.
* player: wake up decoder before waiting for xfade chunksMax Kellermann2008-11-141-0/+1
| | | | | | Fix a deadlock: when the decoder waited for buffer space, the player could enter a deadlock situation because it waits for more chunks for crossfading chunks. Signal the decoder before entering notify_wait().
* wavpack: be more robust if the underlying stream is not seekableLászló Áshin2008-11-141-1/+5
| | | | | | | | The wavpack open function gives us an option called OPEN_STREAMING. This provides more robust and error tolerant playback, but it automatically disables seeking. (More exactly the wavpack lib will not return the length information.) So, if the stream is already not seekable we can use this option safely.
* wavpack: tolerate less decoded data than requestedLászló Áshin2008-11-141-1/+1
| | | | | Wavpack plugin doesn't stop decoding if a block couldn't be fully decoded, rather it tries to go on.
* wavpack: renamed variables and modified coding style slightlyLászló Áshin2008-11-141-80/+113
|
* mp3: fix SEEK command check after mp3_synth_and_send()Max Kellermann2008-11-131-5/+3
| | | | | | mp3 seeking was broken, because the command==SEEK check was never reached. Swap the command check order (==SEEK before !=NONE) to fix that.
* decoder: additional dc.command checks in decoder_data()Max Kellermann2008-11-131-0/+3
| | | | | When a command is sent while the decoder waits for a free chunk in the music pipe, it was not returned by decoder_data().
* decoder: wait for the player only if the music pipe is fullMax Kellermann2008-11-131-4/+5
| | | | Prevent superfluous wakeups and a deadlock condition.
* decoder: check dc.command at the beginning of decoder_data()Max Kellermann2008-11-131-0/+4
| | | | | | Seeking was somewhat broken in some decoder plugins because they sent empty chunks, and never got a command. Check the decoder command before doing anything else in decoder_data().
* player: chop the tail of the music pipe after CANCELMax Kellermann2008-11-133-0/+19
| | | | | | When a CANCEL command is received, the player should drop all chunks of the next song. Added new funciton music_pipe_chop() which is used for that.
* music_pipe: continuously check the sample format of all chunksMax Kellermann2008-11-133-0/+29
| | | | | Provide a debug function which asserts on the sample format of all chunks. Call this function in each iteration of the player main loop.
* decoder: ignore SEEK commands during initializationMax Kellermann2008-11-131-1/+4
| | | | | When the decoder receives a SEEK during initialization, it should ignore that for now. The old code made most decoders abort.
* music_pipe: check for partial frames in appended chunkMax Kellermann2008-11-131-0/+2
| | | | | Added an additional assertion which checks partial frames in the existing tail chunk.