| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
Allocate the buffer dynamically using av_malloc(), and free
AVIOContext.buffer in the destructor, as mandated by the libavformat
documentation.
Fixes http://bugs.musicpd.org/view.php?id=4446
|
|
|
|
|
|
| |
Eliminates some duplicate code, and as a side effect, this works
around clang 3.8 compiler warning because a negative value was
shifted.
|
| |
|
| |
|
|
|
|
|
|
|
| |
Copy to encoder->audio_format *after* adjusting the sample format to
S24_P32.
Fixes http://bugs.musicpd.org/view.php?id=4433
|
| |
|
|
|
|
| |
Fixes missing SongBorder() call, which causes "single" mode breakage.
|
|
|
|
|
| |
If there's a stream tag, don't let the song tag override it in the
next update_stream_tag() call.
|
|
|
|
|
|
|
| |
If the song tag comes from a stream, and MPD playback restarts, MPD
would believe the tag should override the newly received tag. This
makes the previous tag appear stuck. This change passes the song tag
only if it's authoritative - i.e. if it's a song file.
|
|
|
|
| |
Reduce runtime overhead.
|
|
|
|
|
|
| |
Right after booting, the monotonic clock starts with a very small
value, and AudioOutput::LockUpdate() may believe that the fail_timer
has not recovered yet.
|
| |
|
|
|
|
|
| |
When seeking to the beginning of a packet, skip the samples that come
before the desired time stamp.
|
|
|
|
|
|
| |
Ask FFmpeg to seek to the next packet boundary *before* the seek
position, so we don't miss audio data. Now we get too much, but we'll
solve that in the next commit.
|
| |
|
|
|
|
| |
Fixes deadlock on small responses.
|
|
|
|
|
|
| |
The Connect method can be called between Schedule and lock. In that case, when
locked, the state is already set to CONNECTING of READY and the condition won't
be signaled anymore.
|
| |
|
|
|
|
|
|
|
| |
Not initialising granulepos leads to it having arbitrary values in the
encoded stream including possibly negative values which are not valid
and confuse opusdec. Explicitly initialise opus_encoder::granulepos
to avoid that problem.
|
|
|
|
|
|
|
|
|
| |
The file handle is never reset to INVALID_HANDLE_VALUE, and thus the
destructor will assume the operation shall be cancelled and will
delete the temporary file.
This was a major breakage for saving the database file and the state
file.
|
|
|
|
|
|
|
|
|
|
| |
Build a table of pre-existing tag types before adding new items. The
old way would check HasType() each time, which would return true after
the first instance of that tag type had been added, preventing
duplicate tag types to be merged.
This broke duplicate tag types loaded from the state file, because
this code path uses TagBuilder::Complement().
|
|
|
|
|
| |
std::auto_ptr is deprecated, and std::unique_ptr is much better
anyway.
|
|
|
|
|
| |
This is Darwin specific: the previous implementation was causing an integer
overflow when base.numer is very large. On PPC Darwin, the timebase info is 1000000000/33330116 and this is too large for integer arithmetic.
|
|
|
|
|
| |
Don't abort the process if there's not enough memory. This buffer is
not important and can be large.
|
|
|
|
| |
Merge two free() calls.
|
|
|
|
|
| |
A bug report was submitted with a 600 kB ID3 tag that could not be
read by MPD.
|
|\ |
|
| | |
|
| |
| |
| |
| |
| | |
This file has been removed in newer MPD versions, so don't care about
it now.
|
| |
| |
| |
| | |
Fixes gcc5 warning.
|
| |
| |
| |
| | |
This can eliminate the ad-hoc "#ifdef WIN32" and can also support other platforms lacking it as well (including Darwin 9).
|
| |
| |
| |
| |
| | |
Caused a build failure with uClibc because snprintf() was not
available.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Fixes a problem with the "curl" input plugin: IsEOF() always returns
true because the "open" flag was cleared by
CurlInputStream::RequestDone() when end-of-stream was reached. This
flag stays false even when seeking to another position has succeeded.
This patch resets the "open" flag to true after seeking successfully.
|
| |
| |
| |
| |
| |
| |
| | |
NetBSD's pthread_setname_np() prototype is incompatible with the rest
of the world, and it requires to pass the string argument as a
non-const pointer. Instead of working around this misdesign, I hereby
disable the feature on NetBSD.
|
| |
| |
| |
| |
| |
| | |
Add macro HAVE_THREAD_NAME which is set when any method to set the
thread name is available. Use that macro in FormatThreadName()
instead of just checking for HAVE_PTHREAD_SETNAME_NP.
|
| | |
|
| |
| |
| |
| |
| | |
Return false on error, not nullptr.
|
| |
| |
| |
| | |
New in clang 3.6.
|
| |
| |
| |
| | |
Fixes -Winconsistent-missing-override (clang 3.6).
|
|\| |
|
| |
| |
| |
| | |
Return false on error, not nullptr.
|
| |
| |
| |
| | |
Fixes -Winconsistent-missing-override (clang 3.6).
|
| |
| |
| |
| | |
New in clang 3.6.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|