aboutsummaryrefslogtreecommitdiffstats
path: root/src (unfollow)
Commit message (Collapse)AuthorFilesLines
2014-11-24archive/zzip: fix inverted error handlerMax Kellermann1-4/+5
Set the Error when zzip_seek()==-1 and not on success. Fixes a crash after seeking.
2014-11-18Client: assume uid==0 is local socketMax Kellermann2-2/+2
A negative uid value means it's not a "local socket" (PF_LOCAL). uid==0 means user "root" connected.
2014-11-18event/ServerSocket: fix get_remote_uid() error valueMax Kellermann1-1/+1
Must return -1 on error, not 0. 0 is root.
2014-11-11Construct a Null AllocatedPath if the filename conversion into UTF8 failedFlorent Le Coz1-1/+5
2014-11-10decoder/ffmpeg: support opusMax Kellermann1-1/+2
2014-11-02input/curl: fix curl_easy_setopt() parameter typesMax Kellermann1-4/+4
2014-11-02Decoder, Playlist: ignore URI query string for plugin detectionMax Kellermann2-6/+8
Use the new uri_get_suffix() overload that removes the query string.
2014-11-02util/UriUtil: add uri_get_suffix() overload that ignores query stringMax Kellermann2-0/+28
2014-11-02PlaylistFile: don't allow empty playlist nameMax Kellermann1-0/+4
2014-11-02playlist/m3u: recognize the file suffix ".m3u8"Max Kellermann2-1/+3
2014-11-02decoder/faad: remove workaround for ancient libfaad2 ABI bugMax Kellermann1-10/+2
Many years ago, FAAD had a serious ABI bug: the NeAACDecInit() prototype in its header declared the "samplerate" parameter to be "unsigned long *", but internally, the function assumed it was "uint32_t *" instead. On 32 bit machines, that was no difference, but on 64 bit, this left one portion of the return value uninitialized; and worse, on big-endian, the wrong word was filled. This bug had to be worked around in MPD (commit 9c4e97a6). A few months later, the bug was fixed in the FAAD CVS in commit 1.117 on file libfaad/decoder.c; the commit message was: "Use public headers internally to prevent duplicate declarations" The commit message was too brief at best; the problem was not duplicate declarations, but a prototype mismatch. No mention of the bug fix in the ChangeLog. The MPD project never learned about this bug fix, and so MPD would always pass a "uin32_t *" dressed up as a "unsigned long *". Nearly 6 years later, it's about time to fix this second ABI problem. Let's kill the workaround!
2014-11-02decoder/ffmpeg: recognize MIME type audio/aacpSteven OBrien1-0/+1
2014-11-02output/roar: remove unnecessary "volatile" keywordMax Kellermann1-1/+1
A mutex acts as a memory barrier, and thus "volatile" is not necessary.
2014-11-02TagString: use g_strndup() for unterminated stringMax Kellermann1-1/+1
Fixes buffer overflow bug.
2014-09-26CommandLine: update copyright yearMax Kellermann1-2/+2
2014-09-26configure.ac: add option to disable the DSD decodersMax Kellermann1-0/+2
Allow building a smaller MPD binary for people who don't need DSD.
2014-09-26playlist/embcue: change name string to "embcue"Max Kellermann1-1/+1
The name "cue" was listed twice in "mpd --version".
2014-09-18OutputThread: retain negative mix ratioMax Kellermann1-1/+10
Fixes MixRamp breakage.
2014-09-18command/list: reset used size after the list has been processedAndrzej Rybczak1-0/+1
2014-09-13thread/Posix{Cond,Mutex}: don't ues PTHREAD_*_INITIALIZER on NetBSDMax Kellermann3-1/+29
On NetBSD, PTHREAD_MUTEX_INITIALIZER and PTHREAD_COND_INITIALIZER are not compatible with C++11 "constexpr" (see Mantis ticket 0004110). As a workaround, don't ues "constexpr", and use the functions pthread_mutex_init(), pthread_mutex_destroy(), pthread_cond_init() and pthread_cond_destroy() instead. This adds some runtime overhead, but is portable to POSIX implementations that have awkward initializer macros.
2014-09-09decoder/ffmpeg: use memset() to initialize AVProbeDataMax Kellermann1-0/+6
2014-09-07decoder/ffmpeg: pass MIME type to ffmpeg/libav version 11Max Kellermann1-0/+7
That attribute was uninitialized before, which could crash libavformat. See Debian bug 760669
2014-09-07Decoder*: add more assertionsMax Kellermann2-0/+7
2014-09-07DecoderThread: clear the pipe when handling late SEEKMax Kellermann1-1/+11
See code comment. Fixes assertion failure in decoder_command_finished().
2014-09-06decoder/audiofile: fix crash after seekingMax Kellermann1-1/+1
Log call was added to the wrong branch. Fixes regression by commit ca1a1149
2014-09-04protocol/ArgParser: fix integer overflow in parse_range()Max Kellermann1-2/+2
Casting std::numeric_limits<unsigned>::max() to "long" leads to an overflow if sizeof(unsigned)==sizeof(long), and the result will be -1. This happens on some 32 bit architectures, for example ARM and WIN32. Workaround: use std::numeric_limits<int>::max(), which is the largest signed integer. Since sizeof(long)>=sizeof(int), this will never overflow. Fixes Mantis ticket 0004080.
2014-08-31PlaylistControl: use SeekSongOrder(current) to keep current songMax Kellermann1-1/+1
The "current" attribute is a "song order", not a "song position". This is usually the same - except in random mode. Fixes Mantis ticket 0004073.
2014-08-31PlaylistControl: move code to new method SeekSongOrder()Max Kellermann2-7/+19
2014-08-31output/alsa: fix endless loop at end of file in dsd_usb modeMax Kellermann1-0/+9
2014-08-31output/{alsa,oss}: add assertionsMax Kellermann2-0/+6
2014-08-29decoder/gme: fix song durationMax Kellermann1-1/+1
The unit of gme_info_t::length is milliseconds, not centiseconds.
2014-08-24event/TimeoutMonitor: really reset "active" flag before invoking OnTimeout()Max Kellermann1-1/+1
The previous commit was broken. D'oh!
2014-08-24event/TimeoutMonitor: reset "active" flag before invoking OnTimeout()Max Kellermann1-1/+3
The IsActive() method returned true even if the timer was not active, after it completed once. This broke the state file timer, and the state file was not saved periodically.
2014-08-23system/ByteOrder: <endian.h> is a non-standard header that only Linux provides.Thomas Klausner1-0/+10
2014-08-21decoer/dsdiff: fix endless loop on malformed fileMax Kellermann1-1/+1
Same bug as in the previous commit.
2014-08-21decoer/dsf: fix endless loop on malformed fileMax Kellermann1-1/+1
When the data chunk size is not a multiple of the frame size, the last partial frame lead to an endless loop. We fix this by checking chunk_sze>=frame instead of chunk_sze>0. This way, the partial frame is simply skipped.
2014-08-16util: Fix header for strcasecmpFrançois Revol1-1/+1
According to POSIX and both OSX and Linux manpages, strcasecmp comes from strings.h, not string.h. Most OSes also have them available in string.h, but we just fixed the headers on Haiku and it now only provides them in strings.h. We might want to fall back to string.h for other OSes though... cf. http://pubs.opengroup.org/onlinepubs/009695399/functions/strcasecmp.html http://linux.die.net/man/3/strcasecmp https://developer.apple.com/library/mac/documentation/Darwin/Reference/ManPages/man3/strcasecmp.3.html
2014-08-13decoder/ffmpeg: use avcodec_descriptor_get() to determine codec nameMax Kellermann1-0/+9
In version 11, both ffmpeg and libav deprecate AVCodecContext::codec_name. The function avcodec_descriptor_get() has been introduced long ago.
2014-08-07event/BufferedSocket: fix inversed buffer checkMax Kellermann1-1/+1
This was broken by commit 84d20d9e, which deleted the "!" from the check.
2014-08-02Win32Main: move to win32/Max Kellermann3-1/+1
2014-07-12decoder/dsdiff: simplify dsdlib_skip() callMax Kellermann1-4/+3
2014-07-12decoder/dsdiff: simplify loop condition, merge branchesMax Kellermann1-7/+2
2014-07-12decoder/dsdiff: ignore garbage null byte at end of fileMax Kellermann1-1/+1
Failure to read another chunk header is not fatal. Continue to read metadata.
2014-07-12decoder/dsdiff: fix metadata parser bug (uninitialized variables)Max Kellermann1-1/+4
2014-07-12decoder/faad: estimate song duration for remote filesMax Kellermann1-0/+22
Previously, MPD tried to slurp the whole song file, count the number of frames and calculate the song duration from that. That however is extremely expensive for remote files, and will delay playback for a long time. Workaround: check only the first 128 frames and try to extrapolate from here. Fixes Mantis ticket 0004035.
2014-07-12DecoderBuffer: add method _available()Max Kellermann2-0/+13
2014-07-12DecoderBuffer: add method _get_stream()Max Kellermann2-0/+10
2014-07-12decoder/faad: bail out early if sample rate is invalidMax Kellermann1-0/+2
2014-07-12decoder/faad: use adts_check_frame() in faad_song_duration()Max Kellermann1-2/+1
Eliminate more duplicate code.
2014-07-12decoder/faad: test "seekable" after ADTS frame checkMax Kellermann1-1/+5
Don't bother to check for ADIF just because the stream is not seekable.