aboutsummaryrefslogtreecommitdiffstats
path: root/src (unfollow)
Commit message (Collapse)AuthorFilesLines
2009-05-11music_chunk: added more audio_format_valid() assertionsMax Kellermann1-0/+2
Check the validity of the audio_format during write operations.
2009-05-11music_pipe: added assertion on chunk->audio_formatMax Kellermann1-0/+1
Always assert that the audio format of the new chunk is valid.
2009-05-10latest git, httpd_output_plugin compile fix, mac os xPatrik Weiskircher1-0/+4
Hello, While compiling latest git I've received a compile error in the httpd_output_plugin. Small patch attached. Patrik
2009-05-07pcm_resample: fixed typo in libsamplerate runtime checkMax Kellermann1-1/+1
The string comparison should be "!= 0", not "== 0". Ouch.
2009-05-06player_control: assert that pc.next_song is NULL after seekingMax Kellermann1-0/+2
The player thread must reset pc.next_song after seeking, even if that operation has failed. This patch adds an assertion.
2009-05-06player_control: removed pc.error check from pc_seek()Max Kellermann1-6/+3
The only pc_seek() caller clears the error, rendering the check useless. Even if the previous PLAY command resulted in a player error, this check is not very useful.
2009-05-06player_control: renamed playerSeek(), return boolMax Kellermann3-9/+15
Renamed playerSeek() to pc_seek() to get rid of CamelCase. Convert the return value to bool.
2009-05-06tag_id3: added support for the UFID frameMax Kellermann1-0/+40
If the UFID frame's owner is "http://musicbrainz.org", assume its value is the MusicBrainz track id.
2009-05-05httpd_output: save the page generated by encoder_tag()Max Kellermann1-0/+21
Flush the encoder before calling encoder_tag(). The first page generated by the encoder after sending the tag will be the new "header" page, which is sent to all HTTP clients when they connect. This is a little bit specific to the vorbis encoder, but there are no other encoders which support tags (yet).
2009-05-05httpd_output: moved code to httpd_output_encoder_to_clients()Max Kellermann1-14/+32
Moved some code from httpd_output_encode_and_play() into separate functions httpd_output_broadcast_page() and httpd_output_encoder_to_clients().
2009-05-05httpd_output: disable Icy-Metadata when encoder supports tagsMax Kellermann3-18/+35
There's no reason to send both encoder tags and Icy-Metadata to the client. Let's disable Icy-Metadata when the encoder supports embedded tags.
2009-05-05vorbis_encoder: start a new stream in tag()Max Kellermann1-6/+9
When a new tag is set, end the current stream and begin a new one. Use vorbis_analysis_headerout() to write a full ogg header. This fixes a problem with icecast: after a song change in MPD, icecast stops forwarding ogg packets to its clients.
2009-05-05vorbis_encoder: moved code to vorbis_encoder_headerout()Max Kellermann1-5/+10
2009-05-05httpd_output: assert that tag!=NULLMax Kellermann1-8/+7
In the tag() method, MPD guarantees that it does not pass tag==NULL. Converted the runtime check to an assertion.
2009-05-04archive/zip: pass NULL instead of 0 to zzip_dir_open()Max Kellermann1-2/+2
The second parameter of zzip_dir_open() is a pointer. Pass the NULL pointer instead of 0 (with implicit conversion at compile time).
2009-04-28output_init: added option to disable the hardware mixerMax Kellermann1-1/+2
Added the per-device option "mixer_enabled" which allows users to disable the hardware mixer of an audio output.
2009-04-28command: added "sticker delete" commandMax Kellermann1-0/+22
2009-04-28sticker: added sticker_delete_value()Max Kellermann4-0/+85
sticker_delete_value() deletes only one value in a sticker, while the old function sticker_delete() deletes all values.
2009-04-28song_save: don't call tag_free(NULL)Max Kellermann2-1/+4
When a song was in the database twice (which shouldn't happen), and the first song had no tag items, MPD calledd tag_free(NULL). Add a check to that source location, and an assertion to tag_free().
2009-04-28libsamplerate: use g_ascii_strncasecmp() instead of strncasecmp()Max Kellermann1-1/+1
strncasecmp() is locale dependent, making it a bad choice for internal string comparisons.
2009-04-28command: use g_ascii_strcasecmp() instead of strcasecmp()Max Kellermann1-1/+1
strcasecmp() is locale dependent, making it a bad choice for internal string comparisons.
2009-04-28utils: use g_ascii_strcasecmp() instead of strcasecmp()Max Kellermann1-1/+1
strcasecmp() is locale dependent, making it a bad choice for internal string comparisons.
2009-04-28tag: use g_ascii_strcasecmp() instead of strcasecmp()Max Kellermann2-3/+3
strcasecmp() is locale dependent, making it a bad choice for internal string comparisons.
2009-04-28conf: use g_ascii_strcasecmp() instead of strcasecmp()Max Kellermann1-2/+2
strcasecmp() is locale dependent, making it a bad choice for internal string comparisons.
2009-04-28locate: use g_ascii_strcasecmp() instead of strcasecmp()Max Kellermann1-4/+4
strcasecmp() is locale dependent, making it a bad choice for internal string comparisons.
2009-04-28input_curl: use g_ascii_strcasecmp() instead of strcasecmp()Max Kellermann1-7/+7
strcasecmp() is locale dependent, making it a bad choice for internal string comparisons.
2009-04-28mad_decoder: use g_ascii_strcasecmp() instead of strcasecmp()Max Kellermann1-4/+4
strcasecmp() is locale dependent, making it a bad choice for internal string comparisons.
2009-04-28mp4ff_decoder: use g_ascii_strcasecmp() instead of strcasecmp()Max Kellermann1-8/+9
strcasecmp() is locale dependent, making it a bad choice for internal string comparisons.
2009-04-28alsa_mixer: use g_ascii_strcasecmp() instead of strcasecmp()Max Kellermann1-2/+2
strcasecmp() is locale dependent, making it a bad choice for internal string comparisons.
2009-04-28alsa_mixer: add mixer_index optionDaniel Kahn Gillmor1-2/+7
This allows you to select controls with duplicate names.
2009-04-26decoder_api: removed dc.pipe assertion from decoder_read()Max Kellermann1-1/+0
Database update was broken due to the dc.pipe!=NULL assertion. This assertion is only valid while MPD decodes a song, not during database update.
2009-04-25vorbis_encoder: reinitialize vorbis_dsp_state after flushMax Kellermann1-0/+7
libvorbis goes into a very long loop if we try to add data after a flush was invoked by vorbis_analysis_wrote(0). This seems to be a problem with the internal end-of-stream marker. Thus, we cannot reuse the vorbis_dsp_state object.
2009-04-25decoder_control: properly cancel an existing command in dc_stop()Max Kellermann1-2/+8
When the decoder thread has a pending command, send the STOP command to cancel this command. Send STOP again if the decoder thread is still running after that, just in case the decoder thread has executed the previous command (which was overwritten).
2009-04-25decoder: added assertions on dc.pipeMax Kellermann2-0/+13
dc.pipe must be non-NULL while the decoder thread is running. Ensure that with a load of assertions.
2009-04-25client: use GTimer to track timeoutsMax Kellermann1-7/+14
2009-04-25playlist_control: use GTimer in previousSongInPlaylist()Max Kellermann3-6/+15
To determine whether to rewind the current song or to go to the previous song, use a GTimer instead of manually diffing time(NULL).
2009-04-25pulse_mixer: use PULSE's mainloop lock instead of GMutexMax Kellermann1-27/+13
Using two different kinds of locks may result in a race condition with a deadlock. The libpulse callbacks need no locks at all, because the mainloop object can be assumed to be already locked.
2009-04-25curl: moved proxy settings to "input" blockMax Kellermann1-24/+26
The old global settings "http_proxy_host", "http_proxy_port", "http_proxy_user" and "http_proxy_password" continue to work.
2009-04-25fluidsynth: added "experimental" comments in the source fileMax Kellermann1-0/+9
2009-04-25player_thread: pause when all audio outputs fail to playMax Kellermann1-2/+7
When all audio outputs have been closed due to failures, pause the playback instead of stopping it. This way, the user may resume at the current position after the problem has been dealt with.
2009-04-25player_thread: pause when output fails while seekingMax Kellermann1-7/+11
When no audio outputs could be opened while seeking, leave MPD seeked at that position and pause playback. The user may continue from this point at any time, as soon as the audio outputs are fixed. The old behaviour triggered an assertion failure: the failure wasn't passed properly to the do_play() function, which attempted to play audio chunks.
2009-04-24stored_playlist: don't close NULL file on errorMax Kellermann1-5/+1
spl_append_song() can crash when fopen() fails, because it attempts to close the invalid file handle (NULL) in the error handler.
2009-04-21alsa_output: don't use atexit() to clean up the ALSA libraryMax Kellermann1-7/+3
Call snd_config_update_free_global() manually in our finish() method, don't use atexit().
2009-04-21alsa_mixer: call snd_config_update_free_global() in finish()Max Kellermann1-1/+3
snd_config_update_free_global() frees cached ALSA configuration. This keeps valgrind a little bit more quiet. This patch moves the call from the open() method into the finish() method, which seems more natural: it allows the use of the config cache, and improves the cleanup phase.
2009-04-21output_control: close mixer on pauseMax Kellermann1-0/+6
For non-global mixers (only "pulse" currently), close the mixer when MPD playback is paused.
2009-04-17client: free the fifo bufferMax Kellermann1-0/+2
This patch fixes a memory leak: the fifo_buffer object was not freed when the client connection was closed.
2009-04-13icy_server: don't export icy_server_metadata_string()Max Kellermann2-4/+1
icy_server_metadata_string() is only called by icy_server_metadata_page().
2009-04-13httpd: use C99 "bool" instead of GLib's gbooleanMax Kellermann1-7/+7
Plain "bool" consumes only one byte instead of four.
2009-04-13httpd: use g_ascii_strncasecmp() to compare headersMax Kellermann1-1/+1
In HTTP, header names are case insensitive.
2009-04-13Implemented basic icy support for the httpd outputHagen Schink6-12/+409
[mk: folded with patch "Put icy related functions in extra source files"; moved icy_server.c from HAVE_CURL to ENABLE_HTTPD_OUTPUT; removed an unused variable]