aboutsummaryrefslogtreecommitdiffstats
path: root/src (unfollow)
Commit message (Collapse)AuthorFilesLines
2008-10-13playlist: don't use isPlaylist() in deletePlaylist()Max Kellermann3-22/+3
The only caller of deletePlaylist() appends PLAYLIST_FILE_SUFFIX, so we can be sure it's already there. We don't need to stat the file, since unlink() does all the checking.
2008-10-13audio: don't clear input_audio_format on openAudioDevice(NULL)Max Kellermann1-3/+1
Commit 80a2c937 broke resume after pause: it cleared the input_audio_format when it attempted to simplify a complicated expression. Don't clear it, just assign input_audio_format if a new format was specified.
2008-10-13directory: pass const pointers to inline functionsMax Kellermann1-2/+2
The inline functions directory_is_empty() and directory_get_path() don't modify the object - pass constant object pointers to them.
2008-10-13songvec: avoid holding nr_lock during free(3)Eric Wong1-3/+5
We only need to lock sv->nr changes to prevent traversals ( why it's called "nr_lock"). free(3) is a "slow" function on my system; so we can avoid unnecessarily holding a lock long for longer than needed.
2008-10-13update: allow music_root updates to be queuedEric Wong1-3/+2
Previously only updates with subdirectories being specified could be queued. No harm in queueing full updates.
2008-10-13directory: use mpd_sizeof_str_flex_array for path, tooEric Wong2-7/+8
This way we avoid unnecessary heap allocations.
2008-10-13tag_item: avoid wasting space when struct is unpackableEric Wong2-2/+4
Not all compilers support struct packing, and those that don't shouldn't be punished for it.
2008-10-13song: song_get_url: fix "/" prefix for songs in music_rootEric Wong1-1/+1
2008-10-12shout: make the protocol configurableAaron McEwan1-2/+25
Added configuration parameter "protocol" which lets the user choose from 3 shout protocols. This adds support for real shoutcast servers.
2008-10-12shout: use strcmp() instead of strncasecmp()Max Kellermann1-2/+2
Case insensitivity isn't helpful, and comparing only the first 3 bytes of a configured value may encourage users to supply wrong or misleading values.
2008-10-12alsa: fall back to 16 bit outputMax Kellermann1-0/+11
If the sample format isn't supported by the device (i.e. 24 bit on low-end sound chips), fall back to 16 bit output. There is code in pcm_utils.c which converts PCM data to 16 bit.
2008-10-12pcm_utils: support any number of channels in pcm_sizeOfConvBuffer()Max Kellermann1-11/+2
When calculating the conversion buffer size, don't hard-code the formulas for only mono<->stereo.
2008-10-12pcm_utils: support converting N channels to stereoMax Kellermann1-0/+26
Convert any number of channels to stereo. In fact, this isn't really stereo, it's rater mono blown up to stereo. This patch should only make it possible to play 5.1 files at all; "real" conversion to stereo should be implemented, but for now, this is better than nothing.
2008-10-12pcm_utils: pass output channel count to pcm_convertChannels()Max Kellermann1-35/+22
In order to be able to deal with non-trivial conversions, pcm_convertChannels() needs to know both the input and the output channel count. Simplify buffer allocation in that function.
2008-10-12pcm_utils: moved code from pcm_convertChannels() to separate functionsMax Kellermann1-20/+32
Moved code from pcm_convertChannels() to pcm_convert_channels_1_to_2() and pcm_convert_channels_2_to_1(). Improved the quality of pcm_convert_channels_2_to_1() by calculating the arithmetic mean value of both samples.
2008-10-12alsa: moved code to alsa_configure()Max Kellermann1-13/+18
Move code which loads configuration to alsa_configure(). This removes one indent level.
2008-10-12pcm_utils: pass int16_t* where appropriateMax Kellermann1-12/+15
Pass int16_t pointers instead of char pointers to functions which can deal with 16 bit audio only.
2008-10-12player: replaced buffered_before_play with buffering flagMax Kellermann1-9/+10
buffered_before_play was copied to struct player because it was used to disable buffering when seeking. Instead of mainaining a copy of this number, move just the flag to the player struct.
2008-10-12audio: renamed the audio_format variablesMax Kellermann1-17/+13
Renamed audio_configFormat to configured_audio_format. Renamed audio_buffer.format to input_audio_format. Simplified its initialization in openAudioDevice().
2008-10-12audio: removed enum ad_stateMax Kellermann1-22/+14
All what's left from ad_state is a simple boolean flag (ENABLE / DISABLE). Convert it to a C99 bool.
2008-10-12audio: removed audio_buffer.bufferMax Kellermann1-69/+2
audio.c maintained one of MPD's many layers of audio buffers. It was without any benefit, since playAudio() can simply send the source buffer directly to the audio output plugin.
2008-10-12output_buffer: converted ob_is_empty() to inlineMax Kellermann2-6/+4
The function ob_is_empty() is called very often. It's worth it to convert it to an inline function.
2008-10-12player: added commands QUEUE and CANCELMax Kellermann4-155/+74
QUEUE adds a new song to the player's queue. CANCEL clears the queue. These two commands replace the old and complex queueState and queueLockState code.
2008-10-12playlist: call clearPlayerQueue() only if song is queuedMax Kellermann1-23/+15
Simplify and merge several if clauses before the clearPlayerQueue() invocation. Call clearPlayerQueue() only if a song is actually queued; add an assertion for that in clearPlayerQueue().
2008-10-12player: added struct playerMax Kellermann1-48/+75
The player struct holds the local variables which used to be passed to all those helper functions in player_thread.c.
2008-10-11player: removed set_current_song()Max Kellermann1-13/+5
set_current_song() is an internal function and consists of only one assignment. Eliminate it.
2008-10-11player: removed player_control.fileTimeMax Kellermann3-3/+2
This variable is superfluous, it is only used to copy its value to player_control.totalTime. Since the original source of this value (song->tag->time) will still be available at this point, we can safely remove fileTime.
2008-10-11alsa: don't override libasound's buffer_time and period_timeMax Kellermann1-20/+19
ALSA does a good job measuring its buffer_time and period_time. Don't override its defaults, unless the user demands it.
2008-10-11alsa: re-enable blocking modeMax Kellermann1-15/+2
Revert e4f5d6bd "re-enable-nonblocking, but sleep if busy". Non-blocking mode with manual sleeping doesn't help at all (by the way, the patch should have used snd_pcm_wait() instead of my_usleep()). ALSA knows much more about the hardware quirks, so we just let it do the job.
2008-10-11oss: fix opening default OSS deviceMax Kellermann1-1/+1
Leftover from the output API changes: oss_open_default() was changed to return a void*, but it still returned "0" to report success. Report the OssData pointer instead.
2008-10-10player: don't wake up decoder after every frameMax Kellermann1-1/+7
The decoder was woken up after each chunk which had been played. That caused a lot of superfluous context switches. Wake up the decoder only when a certain amount of the buffer has been consumed. This formula is somewhat arbitrary, and has to be proven experimentally.
2008-10-10mp3: dither an arbitrary number of channelsMax Kellermann1-6/+3
The mp3 plugin did not use the MAD_NCHANNELS() value correctly: when a stream was not stereo, it was assumed to be mono, although the correct number was passed to MPD. libmad doesn't support more than 2 channels, but this change allows gcc to optimize its inlining strategy.
2008-10-10mp3: hard-code dithering to 16 bitsMax Kellermann1-8/+6
The dithering function audio_linear_dither() worked for signed 16 bits only anyway, having a variable "bits" just disables important gcc optimizations.
2008-10-10player: added player_get_audio_format()Max Kellermann3-22/+8
player_get_audio_format() replaces getPlayerSampleRate(), getPlayerBits(), getPlayerChannels().
2008-10-10player: added player_control.audio_formatMax Kellermann4-17/+12
This replaces the attributes bits, channels, sampleRate.
2008-10-10mvp: unsinged integersMax Kellermann1-4/+5
Fix some gcc warnings by using unsigned where appropriate. Declare numfrequencies as "const", and replaced the magic number 12 with a sizeof.
2008-10-10mvp: adapt to the new output device APIMax Kellermann1-20/+21
2008-10-10mvp: missing includesMax Kellermann1-0/+5
Again, a plugin which was disabled in my test environment and suffered from compilation errors.
2008-10-10oss: added OssData.audio_formatMax Kellermann1-19/+20
This replaces the separate properties channels, sampleRate, bits.
2008-10-10audio_format: added audio_format_frame_size()Max Kellermann5-7/+12
A frame contains one sample per channel, thus it is sample_size * channels. This patch includes some cleanup for various locations where the sample size for 24 bit audio was still 3 bytes (instead of 4).
2008-10-10audio_format: renamed sampleRate to sample_rateMax Kellermann27-97/+96
The last bit of CamelCase in audio_format.h. Additionally, rename a bunch of local variables.
2008-10-10audio_format: unsigned integersMax Kellermann6-15/+15
"bits" and "channels" cannot be negative.
2008-10-09update: replaced update_return with global "modified" flagMax Kellermann1-65/+41
There is only once update thread at a time. Make the "modified" flag global and remove the return values of most functions. Propagating an error is only useful for updateDirectory(), since updateInDirectory() will delete failed subdirectories.
2008-10-09update: make the variable "progress" staticMax Kellermann1-1/+1
2008-10-09update: don't print debug message when song was not modifiedMax Kellermann1-4/+5
When a song file was not modified, MPD printed the debug message "not a directory or music", because the first "if" branch did not return.
2008-10-09update: fix memory leak in directory_update_init()Max Kellermann1-1/+4
When the update queue is full, directory_update_init() did not free the path argument.
2008-10-09update: make the job id unsignedMax Kellermann4-9/+13
Since the return value cannot be -1 anymore, we can make it unsigned.
2008-10-09update: job ID must be positiveMax Kellermann4-20/+16
The documentation for directory_update_init() was incorrect: a job ID must be positive, not non-negative. If the update queue is full and no job was created, it makes more sense to return 0 instead of -1, because it is more consistent with the return value of isUpdatingDB().
2008-10-09update: check progress!=IDLE in reap_update_task()Max Kellermann1-0/+3
When the update task is idle, there is no need to check for deleted songs. Return early from reap_update_task().
2008-10-09update: fixed stack corruption due to pthread_join() callMax Kellermann1-1/+3
pthread_join() expects a "pointer to a pointer" parameter, but it got a "pointer to an enum". On AMD64, an enum is smaller than a pointer, leading to a buffer overflow.