aboutsummaryrefslogtreecommitdiffstats
path: root/src (unfollow)
Commit message (Collapse)AuthorFilesLines
2011-02-09general: whitespace cleanupThomas Jansen9-29/+29
Remove trailing whitespace found by this command: find -name '*.[ch]' | xargs grep "[[:space:]]$"
2011-02-09output/httpd: initialize unflushed_inputThomas Jansen1-0/+1
This fixes the following valgrind warning occuring on the first call of httpd_output_read_page: ==20124== Conditional jump or move depends on uninitialised value(s) ==20124== at 0x425E65: httpd_output_read_page (httpd_output_plugin.c:240) ==20124== by 0x426087: httpd_output_open (httpd_output_plugin.c:279) ==20124== by 0x41D862: ao_open (output_plugin.h:206) ==20124== by 0x41E133: audio_output_task (output_thread.c:590)
2011-02-03Set fadeout in gme_decoder_plugin. Due to the nature of the gme library,Tony Miller1-0/+3
this needs to be done for the end of songs to be detected.
2011-01-07player_thread: discard empty chunks while cross-fadingMax Kellermann1-0/+13
When a music_chunk to be crossfaded consists only of a tag, cross-fading is not possible, and led to an assertion failure. This patch just discards those, as if cross-fading was not enabled.
2011-01-07output_thread: fix double lockMax Kellermann1-3/+0
During the whole output thread, the audio_output object is locked, and it is only unlocked while waiting for the GCond and while running a plugin method. The error handler in ao_play_chunk() attempted to lock the object again, which was code from MPD 0.15.x which should have been removed a long time ago.
2011-01-07player_thread: fix assertion failure due to early seekMax Kellermann1-0/+4
Until the decoder plugin has called decoder_initialized(), the player may not submit seek commands. This however could occur with a slow decoder and a CUE file with a virtual song offset. This patch adds another check.
2011-01-07player_thread: make variables more localMax Kellermann1-36/+19
2011-01-07encoder/lame: explicitly configure the output sample rateMax Kellermann1-0/+7
When you don't explicitly set an output sample rate, liblame tries to guess an output sample rate from the input sample rate. You would think that this "guessing" consists of just setting both equal, but that is not the case. For 44.1kHz at 96kbit/s, liblame chooses 32kHz. This patch explicitly configures the output sample rate, to stop the bad guessing.
2011-01-07output/httpd: define G_LOG_DOMAIN in httpd_client.cMax Kellermann1-0/+3
2011-01-07output/osx: fix up audio format first, then apply it to deviceMax Kellermann1-9/+10
This is a MPD 0.16 regression: when playing a 24 bit file, the switch to 16 bit was made only partially, after mBytesPerPacket and mBytesPerFrame had already been applied. That means mBytesPerFrame referred to 24 bit, and mBitsPerChannel referred to 16 bits. Of course, that cannot work.
2010-12-21directory: fix warning "comparison between signed and unsigned"Max Kellermann1-2/+2
Cast the constant to dev_t, not to unsigned.
2010-12-21zeroconf-bonjour: use g_htons() instead of htons()Max Kellermann1-1/+1
Fixes the gcc warning "implicit declaration of function 'htons'".
2010-12-21add void casts to suppress "result unused" warnings (clang)Max Kellermann2-3/+3
2010-12-21decoder/mad: work around build failure on SolarisAlex Viskovatoff1-2/+2
Rename the "version" struct, because it seems to be a reserved name on Solaris: "src/decoder/mad_decoder_plugin.c", line 550: (enum) tag redeclared: version cc: acomp failed for src/decoder/mad_decoder_plugin.c
2010-12-21output/solaris: add missing parameter to open_cloexec() callAlex Viskovatoff1-1/+1
2010-12-21audio_check: fix parameter in prototypeAlex Viskovatoff1-1/+1
2010-12-07tag_id3: support multiple valuesMax Kellermann1-10/+36
Loop over all frames with a specific id, and import all of them - not just the first one (index 0).
2010-12-07command: don't error when sticker list is run on song with no stickersAnton Khirnov1-7/+3
this is inconsistent with other commands (e.g. find) and seems wrong -- a song with no stickers attached is a perfectly valid state and an empty list of stickers is also perfectly valid.
2010-11-24tag_ape: support multiple valuesMax Kellermann1-1/+15
One APE tag may contain more than one value, separated by null bytes.
2010-11-18decoder_thread: load APE replay gain from music filesMax Kellermann1-0/+15
2010-11-18replay_gain_ape: parse replay gain from APE tagsMax Kellermann2-0/+110
Based on the APE reader.
2010-11-18tag_ape: move code to ape.cMax Kellermann3-93/+174
Generic library for scanning APE tags. Eliminated one "goto"!
2010-11-18timer: fix integer overflow in timer_delay()Max Kellermann1-1/+1
Fixes a regression: for output_plugin.delay(), we added a method to the timer class which returns the delay in milliseconds. This fails to detect negative values, because the unsigned integer is divided by 1000, and then casted to signed.
2010-11-08playlist_song: calculate duration of last CUE trackMax Kellermann1-0/+8
2010-11-08output/shout: artist comes first in stream titleMax Kellermann1-1/+1
After popular demand, I've switched the order of "artist" and "title" in the stream title. There is no standard, and there is no reliable way to parse those from the stream title.
2010-11-08update_walk: explicitly check for permission problemsMax Kellermann1-0/+33
Call access() and print an extra error message when EACCES is returned. Hopefully this will reduce the number of support requests due to wrong file permissions.
2010-11-08input/rewind: fix assertion failureMax Kellermann1-1/+1
The assertion added in MPD 0.15.14 was too much, it failed when the MIME type of a stream was NULL.
2010-11-05player_thread: fix assertion failure due to wrong music pipe on seekMax Kellermann1-0/+8
When one song is played twice, and the decoder is working on the second "instance", but the first should be seeked, the check in player_seek_decoder() may assume that it can reuse the decoder without exchanging pipes. The last thing was the mistake: the pipe pointer was different, which led to an assertion failure. This patch adds another check which exchanges the player pipe.
2010-11-05decoder_control: pass music_pipe to dc_start()Max Kellermann3-12/+18
More abstraction for decoder_control.pipe.
2010-11-05player_thread: add helper function player_dc_at_next_song()Max Kellermann1-6/+33
Some abstraction for decoder_control.pipe access.
2010-11-05pipe: add helper function music_pipe_empty()Max Kellermann3-4/+10
2010-11-05input/rewind: remove redundant NULL check before g_free() callMax Kellermann1-2/+1
2010-11-05input/rewind: add two assertionsMax Kellermann1-0/+3
2010-11-05input/rewind: fix double free bugMax Kellermann1-0/+1
Duplicate the "mime" attribute of the inner input_stream object, instead of copying the pointer.
2010-11-05output/alsa: dump buffer and period limitsMax Kellermann1-0/+20
2010-11-05output/httpd: implement delay()Max Kellermann1-2/+11
2010-11-05output/shout: implement delay()Max Kellermann1-8/+13
This makes the plugin more responsive to control commands, because it will listen to control events while waiting.
2010-11-05output_plugin: add method delay()Max Kellermann3-3/+51
This method is used to reduce the delay of commands issued to the shout plugin.
2010-11-05timer: add function timer_delay()Max Kellermann2-0/+19
2010-11-05decoder/{mp4ff,ffmpeg}: add extension ".m4b" (audio book)Max Kellermann2-2/+10
Same as ".m4a".
2010-11-04output_thread: fix assertion failure due to race condition in OPENMax Kellermann1-1/+9
Change the assertion on "fail_timer==NULL" in OPEN to a runtime check. This assertion crashed when the output thread failed while the player thread was calling audio_output_open().
2010-11-04output_internal: protect attribute "fail_timer" with mutexMax Kellermann2-1/+7
2010-11-04output_control: lock object in audio_output_open()Max Kellermann1-6/+19
Protect the attributes "open" and "fail_timer".
2010-11-04output_control: lock object in audio_output_close()Max Kellermann1-2/+28
Protect the attributes "open" and "fail_timer".
2010-11-04server_socket: remove AI_ADDRCONFIGMantas Mikulenas1-3/+0
When you pass the flag AI_ADDRCONFIG to getaddrinfo(), it does not consider address families on the loopback device. When run on a machine without an external network card, just with "lo", it was unable to look up any address.
2010-11-04output/ffado: transfer_playback_buffers() returns a booleanMax Kellermann1-1/+4
libffado documentation says this function returns -1 on error, but that is a lie - it returns a boolean value, and "false" means error.
2010-11-04decoder/ffmpeg: check AVCodecContext.sample_fmt valueMax Kellermann1-7/+9
.. instead of av_get_bits_per_sample_format(). The SampleFormat enum value is authoritative.
2010-11-04winmm_output: handle empty string case when parsing device idDenis Krjuchkov1-1/+1
2010-11-04winmm_output: added "device" configuration optionDenis Krjuchkov1-2/+35
Device can be specified either by magic index (starting with 0) or by device name.
2010-11-03winmm_output: improved test_default_deviceDenis Krjuchkov1-2/+1
If no device is available test_default_device returns false.