aboutsummaryrefslogtreecommitdiffstats
path: root/src (unfollow)
Commit message (Collapse)AuthorFilesLines
2009-01-25tag: remove unused variable paramLaszlo Ashin1-3/+2
This variable doesn't have a role since 80799fa8.
2009-01-25database: eliminate "goto" usageMax Kellermann1-7/+8
http://xkcd.com/292/
2009-01-25use g_free() instead of free()Max Kellermann18-40/+36
On some platforms, g_free() must be used for memory allocated by GLib. This patch intends to correct a lot of occurrences, but is probably not complete.
2009-01-25mixer_api: removed struct mixer_dataMax Kellermann4-39/+45
The mixer plugins should re-use the mixer struct and incorporate it in their object class.
2009-01-25mixer: merged methods "init" and "configure"Max Kellermann4-68/+20
Both methods are always called together. There is no point in having them separate. This simplifies the code, because the old configure() method could be called more than once, and had to free old allocations.
2009-01-25mixer: removed mixer_configure_legacy(), AC_MIXER_CONFIGUREMax Kellermann5-30/+0
Those have been superseded by the new legacy configuration code.
2009-01-25mixer: configure legacy mixer before the audio outputsMax Kellermann2-22/+70
Reimplemented the legacy mixer configuration: copy the deprecated configuration values into the audio_output section. Don't configure the mixers twice (once for the audio_output, and a second time for the legacy values). This requires volume_init() to be called before initAudioDriver().
2009-01-25mixer: removed mixer_configure(), configure mixer in mixer_new()Max Kellermann4-20/+7
Allocate the mixer object when it is configured. Merged mixer_configure() into mixer_new(). mixer_new() was quite useless anyway.
2009-01-25mixer: return a mixer struct pointerMax Kellermann4-15/+40
Don't use statically allocated mixer objects.
2009-01-25mixer: make all mixer_plugin pointers constMax Kellermann4-7/+7
The plugin structures must never be modified.
2009-01-25mixer: added missing copyright headersMax Kellermann4-0/+68
2009-01-25conf: added config_add_param()Max Kellermann2-0/+17
The function config_add_param() allows adding new configuration parameters.
2009-01-25Add idle event on sticker deletion, update and insertionQball Cow3-1/+9
2009-01-25conf: allow param==NULLMax Kellermann6-33/+13
Return the default value in the conf_get_block_*() functions when param==NULL was passed. This simplifies a lot of code, because all initialization can be done in one code path, regardless whether configuration is present.
2009-01-25conf: const pointers in block get functionsMax Kellermann27-49/+49
All config_get_block_*() functions should accept constant config_param pointers.
2009-01-25use config_get_string() instead of config_get_param()Max Kellermann5-31/+24
config_get_string() is easier to use than config_get_param() because it unpacks the config_param struct.
2009-01-25playlist: moved is_valid_playlist_name() to stored_playlist.cMax Kellermann4-22/+32
2009-01-25playlist: moved savePlaylist() and loadPlaylsit() to playlist_save.cMax Kellermann5-65/+83
2009-01-25playlist: removed g_rand, PLAYLIST_HASH_MULTMax Kellermann1-10/+0
Both are unused.
2009-01-25queue: added queue_shuffle_order_last()Max Kellermann3-6/+18
This function shuffles the last song of a range. This is used by addSongToPlaylist().
2009-01-25stored_playlist: moved configuration variables from playlist.cMax Kellermann7-19/+32
Don't declare and export variables specific to stored playlists in playlist.c/playlist.h.
2009-01-25player_thread: start decoder thread in player threadMax Kellermann2-2/+3
Start the decoder thread when the player thread starts. The decoder thread is already stopped by the player thread.
2009-01-25player_control: added player_control.threadMax Kellermann3-2/+12
player_control.thread contains the handle of the player thread, or NULL if the player thread isn't running.
2009-01-25decoder_control: added decoder_control.threadMax Kellermann4-6/+17
decoder_control.thread contains the handle of the decoder thread, or NULL if the decoder thread isn't running.
2009-01-25mapper: added dot to PLAYLIST_FILE_SUFFIXMax Kellermann3-9/+6
Some code will be a little bit simpler if the dot is part of the string literal.
2009-01-25alsa: added commentsMax Kellermann1-3/+21
Document alsa_data members.
2009-01-25alsa: frame_size is size_t, not intMax Kellermann1-1/+1
frame_size is a memory size and should be a size_t, not a signed integer.
2009-01-25alsa: no CamelCaseMax Kellermann1-93/+103
Renamed types, functions, variables.
2009-01-25alsa: fix option parsing and restore default period_timeDan McGee1-3/+6
Two bugs here led to a large number of interrupts being generated on the sound card when ALSA output is being used. Because we specify no default period_time, the sound card gives us 3000 interrupts/sec rather than a more sane 20 or 30. This completes the revert of dd7711 already started by 4ca24f. The larger bug was in the change to config_get_block_unsigned() and using 0 as the default value for both 'buffer_time' and 'period_time'. This means any pre-setting of these options in newAlsaData() gets wiped out. Add a new default for period_time, and ensure default values for buffer_time and period_time are used if none are provided by the user. Signed-off-by: Dan McGee <dan@archlinux.org> [mk: set defaults in newAlsaData() to fix auto-configuration; renamed "_MS" back to "_US" because ALSA expects microseconds, not milliseconds] Signed-off-by: Max Kellermann <max@duempel.org>
2009-01-25Fix tag not being set when casefolding the locate_item_listQball Cow1-1/+3
2009-01-24renamed the "mod" decoder plugin to "mikmod"Max Kellermann3-5/+5
We have two mod plugins now: modplug and mod. Rename the latter to a more useful name.
2009-01-24tag_id3: added MusicBrainz tag supportMax Kellermann1-0/+79
Added support for the MusicBrainz TXXX tags, documented on: http://musicbrainz.org/doc/MusicBrainzTag
2009-01-24tag_id3: always allocate tag objectMax Kellermann1-30/+27
Save some code: always allocate the tag object, and free it when it turns out to be empty.
2009-01-24tag: added support for MusicBrainz tagsMax Kellermann2-1/+13
Added all important id tags from the MusicBrainz wiki: http://musicbrainz.org/doc/MusicBrainzTag This should automatically enable its suport in the vorbis and flac decoder plugins.
2009-01-24modplug: removed EOF check from the while loopMax Kellermann1-2/+4
EOF is checked by input_stream_read() (decoder_read() here). Don't do it twice. The check was wrong anyway, it was reversed.
2009-01-24modplug: check for input_stream errorsMax Kellermann1-2/+8
When input_stream_read() returns 0, and input_stream_eof() returns false, an I/O error has occured. Skip this song.
2009-01-24modplug: use size_t instead of int for buffer sizesMax Kellermann1-1/+1
2009-01-24modplug: check size limit before appending new bufferMax Kellermann1-4/+4
Don't enlarge the GByteArray when the size limit may overflow in this operation; check the size limit first.
2009-01-24modplug: use GByteArray.len, remove total_lenMax Kellermann1-4/+2
The local variable "total_len" is superfluous because GByteArray always knows its size.
2009-01-24modplug: unknown size is -1; check for empty fileMax Kellermann1-5/+12
The input_stream API sets size to -1 when the size of the resource is not known. The modplug decoder checked for size==0, which would be an empty file.
2009-01-24modplug: header cleanupMax Kellermann1-2/+0
Don't include utils.h and log.h, they are relics from the past.
2009-01-24modplug: define G_LOG_DOMAINMax Kellermann1-0/+3
Make sure that log messages are decorated correctly.
2009-01-24modplug: declare constants as enumMax Kellermann1-4/+6
Don't write CPP if you can write C.
2009-01-24modplug: use only decoder_read(), not input_stream_read()Max Kellermann1-5/+1
You are allowed to call decoder_read() with decoder==NULL. It is a convenience function provided by the decoder API. Don't manually fall back to input_stream_read().
2009-01-24locate: added locate_item_list_casefold()Max Kellermann4-11/+22
Merged casefolding code from two locations into this one library function.
2009-01-24queue_print, dbUtils: use struct locate_item_listMax Kellermann7-74/+58
Changed the function prototypes to get locate_item_list objects instead of num_items/items.
2009-01-24locate: added struct locate_item_listMax Kellermann5-87/+111
Instead of passing two parameters around (number of items, array of items), combine both in a variable size struct.
2009-01-24locate: initialize the whole visited_types arrayMax Kellermann1-2/+6
The declaration initialized only the first element. Initialize the whole array with memset() instead.
2009-01-24locate: use bool instead of intMax Kellermann2-33/+33
Use the C99 bool type instead of integer values (1/0 or 0/-1).
2009-01-24locate: no CamelCaseMax Kellermann5-89/+76
Renamed functions and variables.