Commit message (Collapse) | Author | Files | Lines | ||
---|---|---|---|---|---|
2014-12-17 | LogBackend: force-flush stderr on WIN32 | Max Kellermann | 1 | -0/+6 | |
setvbuf() does not seem to have an effect on Windows. | |||||
2014-12-17 | LogInit: make stderr line-buffered | Max Kellermann | 1 | -0/+3 | |
Make sure everything gets logged right away. No delays because stdio's buffer is not yet full. | |||||
2014-12-17 | util/HugeAllocator: enable MEM_COMMIT on Windows | Max Kellermann | 1 | -1/+3 | |
Without MEM_COMMIT, the reserved address space is not accessible, and MPD crashes. | |||||
2014-12-16 | playlist/embcue: fix filename suffix detection | k44 | 1 | -1/+1 | |
The definition of the playlist_plugin struct member of the embcue plugin was incorrect. | |||||
2014-12-15 | storage/nfs: add timeout | Max Kellermann | 2 | -3/+13 | |
2014-12-15 | decoder/ffmpeg: detect and fix negative time stamps | Max Kellermann | 1 | -4/+7 | |
Works around assertion failure due to something that appears to be a (minor) FFmpeg bug. | |||||
2014-12-15 | storage/nfs: clear last_error in SetState() | Max Kellermann | 1 | -0/+1 | |
Fixes bogus assertion failure. | |||||
2014-12-15 | lib/nfs/Connection: unregister socket with SocketMonitor::Steal() | Max Kellermann | 1 | -1/+1 | |
SocketMonitor::Cancel() does not actually unregister the socket; it only disables the event. | |||||
2014-12-15 | lib/nfs/Connection: implement mount timeout | Max Kellermann | 2 | -2/+31 | |
2014-12-15 | lib/nfs/Connection: add debug flag "in_destroy" | Max Kellermann | 2 | -0/+11 | |
2014-12-14 | lib/nfs/Connection: add assertion | Max Kellermann | 1 | -0/+2 | |
2014-12-14 | lib/nfs/Connection: fix reconnect after mount failure | Max Kellermann | 1 | -1/+1 | |
When mounting had not yet finished, SocketMonitor::IsDefined() was always false, due to the workaround at the beginning of the function that calls SocketMonitor::Steal(). This commit drops the IsDefined() check because it was never necessary and breaks reconnect. | |||||
2014-12-14 | lib/nfs/Connection: fix typo in code comment | Max Kellermann | 1 | -1/+1 | |
2014-12-14 | lib/nfs/Connection: fix memory leak (and assertion failure) | Max Kellermann | 3 | -0/+28 | |
nfs_destroy_context() will invoke all pending callbacks with err==-EINTR. In CancellableCallback::Callback(), this will invoke NfsConnection::DeferClose(), which however is only designed to be called from nfs_service(). In non-debug mode, this will leak memory because nfs_close_async() is never called. Workaround: before nfs_destroy_context(), invoke nfs_close_async() on all pending file handles. | |||||
2014-12-14 | lib/nfs/Connection: move code to Service() | Max Kellermann | 2 | -12/+28 | |
2014-12-14 | lib/nfs/Connection: add assertions | Max Kellermann | 1 | -0/+2 | |
2014-12-14 | lib/nfs/Connection: move code to method InternalClose() | Max Kellermann | 2 | -3/+17 | |
2014-12-14 | lib/nfs/Connection: make in_service and in_event debug-only flags | Max Kellermann | 2 | -0/+11 | |
2014-12-14 | lib/nfs/Connection: fix crash while canceling a failing Open() | Max Kellermann | 1 | -2/+4 | |
The method NfsConnection::CancellableCallback::Callback() will always invoke NfsConnection::Close() on the file handle, even if the void pointer is not a nfsfh. This can happen if the Open() was not successful, e.g. when the file does not exist. | |||||
2014-12-14 | event/Loop: read the "again" flag while holding mutex | Max Kellermann | 1 | -1/+2 | |
2014-12-14 | lib/nfs/Connection: add assertions | Max Kellermann | 1 | -0/+31 | |
2014-12-12 | util/HugeAllocator: disable MEM_LARGE_PAGES on Windows | Max Kellermann | 1 | -1/+2 | |
MEM_LARGE_PAGES does not appear to work. Instead, MEM_RESERVE appears to be necessary. Until I figure this out, this large pages are disabled. | |||||
2014-12-12 | input/Init: eliminate double colon from log message | Max Kellermann | 1 | -1/+1 | |
2014-12-09 | playlist/Print: don't skip non-existent songs in "listplaylist" | Max Kellermann | 1 | -6/+7 | |
Skipping those songs silently will confuse the client, because commands specifying the song index within a playlist (e.g. playlistdelete) will be out of sync. This copies spl_print()'s behavior to playlist_file_print(). | |||||
2014-12-08 | decoder/ffmpeg: support FFmpeg 2.5 | Max Kellermann | 1 | -0/+5 | |
Version 2.5 fixed an API oddity, however it broke API compatibility, at least with C++. Disable the workaround when a libavformat version is detected that is recent enough. | |||||
2014-12-08 | thread/Id: drop "::" prefix before pthread function names | Max Kellermann | 1 | -2/+2 | |
The "::" to explicitly refer to the global namespace appeared like a good idea in C++, but it breaks with C libraries that implement standard functions using macros (e.g. musl). | |||||
2014-12-01 | Output: start with a null mixer. | Nix | 1 | -0/+1 | |
There are code paths (mostly error cases) in which it is possible to initialize an AudioOutput and then kill it without ever calling audio_output_new(). In such a case, its destructor will attempt to free a mixer that was never initialized, leading to an attempt to take out a lock on a mutex that was similarly never initialized, which hangs forever. Fix by always initializing the mixer appropriately. | |||||
2014-11-25 | lib/nfs/FileReader: clean up on disconnect | Max Kellermann | 1 | -1/+1 | |
Avoids crash because Close() invokes a call on a destructed NfsConnection. | |||||
2014-11-25 | lib/nfs/FileReader: move code to CancelOrClose() | Max Kellermann | 2 | -0/+16 | |
2014-11-25 | lib/nfs/FileReader: reset state in OnNfsConnectionFailed() | Max Kellermann | 1 | -0/+2 | |
Avoid calling NfsConnection::RemoveLease(), because the lease has been removed already. | |||||
2014-11-25 | lib/nfs/FileReader: update "state" in OnNfsError() | Max Kellermann | 1 | -0/+24 | |
Clean up the "state" to indicate that there is no longer any asynchronous operation. Fixes another NFS-related crash due to cleanup of a non-existing asynchronous operation. | |||||
2014-11-25 | lib/nfs/Manager: defer NfsConnection destruction | Max Kellermann | 2 | -9/+54 | |
Avoids a crash that occurs when NfsConnection::OnSocketReady() dereferences itself before returning. | |||||
2014-11-25 | lib/nfs/Connection: broadcast error before closing connection | Max Kellermann | 1 | -4/+4 | |
During the NfsLease::OnNfsConnectionFailed() call, the old (defunct) nfs_context may be used to close file handles. Such code does not yet exist, but will be added soon to fix other bugs. | |||||
2014-11-25 | lib/nfs/Connection: cancel DeferredMonitor on disconnect | Max Kellermann | 1 | -0/+4 | |
Fixes potential second mount attempt after the old connection to the NFS server was shut down. | |||||
2014-11-25 | lib/nfs/FileReader: include Compiler.h for "final" fallback | Max Kellermann | 1 | -0/+1 | |
2014-11-25 | decoder/mp4v2: remove because of incompatible license | Max Kellermann | 3 | -359/+0 | |
libmp4v2 is licensed under MPL 1.1, which is incompatible with GPLv2. Unfortunately, this means that we must remove the plugin. More information can be found in the Debian bug report: http://bugs.debian.org/767504 | |||||
2014-11-25 | event/DeferredMonitor: include cleanup | Max Kellermann | 2 | -3/+2 | |
2014-11-24 | archive/zzip: fix inverted error handler | Max Kellermann | 1 | -4/+5 | |
Set the Error when zzip_seek()==-1 and not on success. Fixes a crash after seeking. | |||||
2014-11-24 | decoder/{dsdiff,dsf,opus}: fix deadlock while seeking | Max Kellermann | 2 | -3/+3 | |
2014-11-24 | Java/File: fix include guard | Max Kellermann | 1 | -1/+1 | |
2014-11-18 | QueueCommands: workaround for buggy clients that send "add /" | Max Kellermann | 1 | -1/+10 | |
2014-11-18 | Client: assume uid==0 is local socket | Max Kellermann | 2 | -2/+2 | |
A negative uid value means it's not a "local socket" (PF_LOCAL). uid==0 means user "root" connected. | |||||
2014-11-18 | event/ServerSocket: fix get_remote_uid() error value | Max Kellermann | 1 | -1/+1 | |
Must return -1 on error, not 0. 0 is root. | |||||
2014-11-12 | decoder/opus: add MIME types audio/ogg and application/ogg | Max Kellermann | 1 | -0/+7 | |
2014-11-11 | Construct a Null AllocatedPath if the filename conversion into UTF8 failed | Florent Le Coz | 1 | -1/+5 | |
2014-11-11 | decoder/opus: support chained streams | Max Kellermann | 1 | -1/+36 | |
2014-11-11 | decoder/opus: move code to HandleEOS() | Max Kellermann | 1 | -1/+8 | |
2014-11-11 | decoder/opus: improved error logging | Max Kellermann | 1 | -4/+11 | |
2014-11-11 | decoder/opus: fix mistyped LoadEOSPacket() return value | Max Kellermann | 1 | -1/+1 | |
2014-11-11 | decoder/opus: eliminate flag "found_opus" | Max Kellermann | 1 | -5/+3 | |
Check opus_decoder!=nullptr instead. |